Page MenuHomeSchine - Phabricator
Create Task
Maniphest T2008

Starmade | Typo in customBlockBehaviorConfig/customBlockBehaviorConfig.xml causes server to seek non-existant file
Closed, RejectedPublic
Actions

Description

The following customBlockBehaviorConfig/customBlockBehaviorConfig.xml file has a typo:

<BlockBehavior>
        <SalvageBeam>
                <BasicValues>
                        <Distance>0.25</Distance> <!-- 1 is equal to 100% sector radius --> <!-- timeBetweenHits = 1 / (unitSize^pow)*mult -->
                <BasicValues>
        </SalvageBeam>
</BlockBehavior>

Attempting to start a server with this typo results in the server frantically seeking (e.g. hundreds of repeated log entries) data/config/revertBlockBehaviorConfig.xml

Oct 13 16:37:50 stars SMStage: java.lang.NullPointerException
Oct 13 16:37:50 stars SMStage: #011at org.schema.game.common.controller.elements.UsableElementManager.parse(SourceFile:154)
Oct 13 16:37:50 stars SMStage: #011at org.schema.game.common.controller.elements.ManagerContainer.reparseBlockBehavior(SourceFile:300)
Oct 13 16:37:50 stars SMStage: #011at org.schema.game.common.controller.elements.ManagerContainer.<init>(SourceFile:210)
Oct 13 16:37:50 stars SMStage: #011at org.schema.game.common.controller.elements.StationaryManagerContainer.<init>(SourceFile:253)
Oct 13 16:37:50 stars SMStage: #011at org.schema.game.common.controller.elements.SpaceStationManagerContainer.<init>(SourceFile:9)
Oct 13 16:37:50 stars SMStage: #011at obfuscated.Xt.<init>(SourceFile:94)
Oct 13 16:37:50 stars SMStage: #011at org.schema.game.common.data.world.Universe.loadEntity(SourceFile:431)
Oct 13 16:37:50 stars SMStage: #011at obfuscated.ahR.a(SourceFile:1430)
Oct 13 16:37:50 stars SMStage: #011at obfuscated.ahR.a(SourceFile:1402)
Oct 13 16:37:50 stars SMStage: #011at obfuscated.ahR.a(SourceFile:1289)
Oct 13 16:37:50 stars SMStage: #011at org.schema.game.common.data.world.Universe.loadOrGenerateSector(SourceFile:955)
Oct 13 16:37:50 stars SMStage: #011at org.schema.game.common.data.world.Universe.getSector(SourceFile:651)
Oct 13 16:37:50 stars SMStage: #011at org.schema.game.common.data.world.Universe.getSector(SourceFile:645)
Oct 13 16:37:50 stars SMStage: #011at org.schema.game.server.controller.GameServerController.onLoggedIn(SourceFile:1745)
Oct 13 16:37:50 stars SMStage: #011at org.schema.schine.network.server.ServerController.registerClient(SourceFile:151)
Oct 13 16:37:50 stars SMStage: #011at org.schema.schine.network.commands.LoginRequest.login(SourceFile:95)
Oct 13 16:37:50 stars SMStage: #011at org.schema.schine.network.commands.LoginRequest.run(SourceFile:204)
Oct 13 16:37:50 stars SMStage: #011at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
Oct 13 16:37:50 stars SMStage: #011at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
Oct 13 16:37:50 stars SMStage: #011at java.lang.Thread.run(Thread.java:745)
Oct 13 16:37:50 stars SMStage: java.io.FileNotFoundException: ./data/config/revertBlockBehaviorConfig.xml (No such file or directory)
Oct 13 16:37:50 stars SMStage: #011at java.io.FileInputStream.open0(Native Method)
Oct 13 16:37:50 stars SMStage: #011at java.io.FileInputStream.open(FileInputStream.java:195)
Oct 13 16:37:50 stars SMStage: #011at java.io.FileInputStream.<init>(FileInputStream.java:138)
Oct 13 16:37:50 stars SMStage: #011at obfuscated.f.a(SourceFile:39)
Oct 13 16:37:50 stars SMStage: #011at org.schema.game.server.controller.GameServerController.c(SourceFile:2950)
Oct 13 16:37:50 stars SMStage: #011at org.schema.game.common.controller.elements.ManagerContainer.reparseBlockBehavior(SourceFile:310)
Oct 13 16:37:50 stars SMStage: #011at org.schema.game.common.controller.elements.ManagerContainer.<init>(SourceFile:210)
Oct 13 16:37:50 stars SMStage: #011at org.schema.game.common.controller.elements.StationaryManagerContainer.<init>(SourceFile:253)
Oct 13 16:37:50 stars SMStage: #011at org.schema.game.common.controller.elements.SpaceStationManagerContainer.<init>(SourceFile:9)
Oct 13 16:37:50 stars SMStage: #011at obfuscated.Xt.<init>(SourceFile:94)
Oct 13 16:37:50 stars SMStage: #011at org.schema.game.common.data.world.Universe.loadEntity(SourceFile:431)
Oct 13 16:37:50 stars SMStage: #011at obfuscated.ahR.a(SourceFile:1430)

The file data/config/revertBlockBehaviorConfig.xml does not exist as per T1549

Expected behavior:
Don't crash while reporting the ONLY error as seeking a file you don't expect to normally find anyways. This is confusing, and does not help your average server admin do anything useful. Please, be a little more sane: report an error relevant to where the actual typo is.

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
uncertain
Category
Blockconfig
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Related Objects

Event Timeline

SmilingDemon shifted this object from the S1 Public space to the S3 Starmade space.Dec 21 2016, 6:53 PM
SmilingDemon changed the visibility from "Custom Policy" to "Public (No Login Required)".
SmilingDemon changed the edit policy from "Task Author" to "Starmade (Project)".
SmilingDemon changed Affected Gamemode(s) from none/unspecified to Single and Multi.
SmilingDemon changed Category from none/unspecified to Blockconfig.
SmilingDemon claimed this task.
SmilingDemon triaged this task as Normal priority.

-Feedback-

i am probably looking stupid here .. but what is the typo ???

erthparadine added a comment.Dec 22 2016, 6:53 PM

I think this is a non-issue now.

If I remember correctly *sips more coffee* there was a typo in what the game expected the file to contain...I guess. As I distinctly remember running into this issue, and the file not loading because of transposed characters in the configs, which the game engine was requiring...but it appears that what I pasted in this ticket's OP was the correct spelling, and it also appears that the current release is running with no transposed letters in the relevant portions.

On the other hand, I could be also overlooking the "obvious" and just need more coffee.

I'll open a new ticket if I see this issue re-emerge.

SmilingDemon closed this task as Rejected.Dec 22 2016, 7:19 PM

-Rejected-

OK .. then i do clean up this report by rejecting it ^^

Restricted Application removed a project: Issue Navigation. · View Herald TranscriptDec 22 2016, 7:19 PM
Restricted Application added a project: Blockconfig. · View Herald TranscriptMar 10 2017, 6:07 PM
AndyP moved this task from Unclassed to Archived on the Starmade board.Mar 29 2017, 1:26 PM