Page MenuHomeSchine - Phabricator

Starmade | Storage over capacity drops too many items / drops items when exactly full
Confirmed task for development, NormalPublic

Description

Storage always drops full stacks instead of only dropping the part of a stack that is over capacity.

Storage that is exactly at 100% counts as over capacity.

  • It's not possible to add another item to a storage, if it would reach exactly 100% capacity, neither by hand or by pulling from another storage
  • It is possible to reach 100% by manually placing a stack with the correct size in an empty storage block, but not by pulling

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.199.253
Category
Control Block System: Functional
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  • Create core + 1 storage block
  • Fill storage with an item from creative inventory (not a multi-slot item)
  • Wait until storage drops entire stack
  • Now try to fill storage with a stack of 2001 hull blocks, it won't work (as intended)
  • Try again with 2000 hull blocks, this should work, since that's the exact capacity limit of a single storage block
  • The storage should show that it's over capacity, wait for items to drop
  • Fill storage with 1999 hull blocks, then try to add a single hull block, this won't work
Tester information (Internal use only)

Tested this with 1000 Power Generator Blocks

putting in by hand 1000 of them fills the storage to 100% and counts as overcapacity
pulling up to 1000 into a storage isnt working .. it stops at 999 (99.9%)
putting in 999 and trying to add 1 isnt possible either

seems to be a problem with checking the content as < than Max not as having reached it exactly

Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

Malacodor created this task.Oct 5 2016, 8:35 PM
SmilingDemon shifted this object from the S1 Public space to the S3 Starmade space.Oct 16 2016, 1:24 PM
SmilingDemon changed the visibility from "Custom Policy" to "Public (No Login Required)".
SmilingDemon changed the edit policy from "Task Author" to "Starmade (Project)".
SmilingDemon edited Tester information (Internal use only). (Show Details)
SmilingDemon changed Affected Gamemode(s) from none/unspecified to Single and Multi.
SmilingDemon changed Last tested (version) from 0.199.234 to 0.199.253.
SmilingDemon triaged this task as Normal priority.
SmilingDemon edited Tester information (Internal use only). (Show Details)Oct 16 2016, 1:28 PM
SmilingDemon changed the task status from Open to In Queue (Game).Oct 16 2016, 1:31 PM

-Validated-
-confirmed-

Restricted Application edited projects, added Game Development; removed Issue Navigation. · View Herald TranscriptOct 16 2016, 1:31 PM
AndyP changed the task status from In Queue (Game) to In Queue.Mar 10 2017, 5:16 PM
Restricted Application added a project: CBS: Functional. · View Herald TranscriptMar 10 2017, 5:16 PM