Page MenuHomeSchine - Phabricator
Create Task
Maniphest T1934

Starmade | Inconsistent metaobject vs meta item references - inventories swapped, randomized, only final 4 of 6 total digits in new ID is sometimes stored, and typo in logs.
Closed, FinishedPublic
Actions

Description

Inconsistent metaobject vs meta item references, only final 4 of 6 total digits in new ID is sometimes stored, and typo in logs.

The terms "meta item" and "metaobject" appear to be used interchangeably in logs (code too?), but seemingly reference the same (sometimes) underlying item. This is confusing.

The routine behind "[METAITEM] Creating new meta item" appears to be jumbling player inventories.

Log entries pertaining to "[METAITEM] Creating new meta item" was first seen in release 0.199.214 Players first started noticing this the jumbled inventory a few days following that.

Also typo:
Awnsering Client request for...

Should be:
Answering Client request for...

Kudos to Spocklin, for eyeballing this inventory oddity first. Ongoing player discussion (and perhaps more info) can be found at: http://forums.bitminery.com/index.php?topic=373.0

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
none/unspecified
Reproducible
uncertain
Category
none/unspecified
First occurrence (version)
0.199.214
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce

his is really difficult to consistently replicate. Although what appears to be happening:

  • "[METAITEM] Creating new meta item" generates a 6-digit int, identified by ID.
  • If final four digits of ID match an already existing value available accessible via "[SERVER] Awnsering Client request for metaobject", then original contents of "new meta item" are discarded and replaced with contents returned by the 4-digit "metaobject" entry.
  • Items jumbled within inventories appears limited to metaobjects identified by only 4-digits, wheras metaobjects identified by 6-digits appear unaffected.
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

AndyP updated the task description. (Show Details)Sep 17 2016, 7:20 PM
AndyP edited Steps to reproduce. (Show Details)
AndyP changed the visibility from "Custom Policy" to "Public (No Login Required)".
AndyP changed the edit policy from "Task Author" to "Starmade (Project)".
AndyP moved this task from New / Unconfirmed to Feedback on the Issue Navigation board.
AndyP renamed this task from Inconsistent metaobject vs meta item references, only final 4 of 6 total digits in new ID is sometimes stored, and typo in logs. to Inconsistent metaobject vs meta item references - inventories swapped, randomized, only final 4 of 6 total digits in new ID is sometimes stored, and typo in logs..
AndyP claimed this task.
AndyP triaged this task as Pre-Release Quality Assurance priority.

Trying to reproduce

erthparadine added a comment.EditedSep 19 2016, 5:17 PM

From ongoing player discussions, is it possible to distill this issue down to something simpler: considering that there was a very obvious shift to 6-digit metaobject IDs in release 0.199.217. Are client requests for 4-digit metaobjects simply resulting in an odd search/response behavior from the server?

Another thought: are metaobject query/response routines authenticated (e.g. to ensure a player has permission to request that metaobject)

AndyP changed the task status from Open to Feedback.Feb 21 2017, 8:53 PM
Restricted Application added a project: Waiting on Author. · View Herald TranscriptFeb 21 2017, 8:53 PM
AndyP shifted this object from the S1 Public space to the S3 Starmade space.Feb 24 2017, 12:56 PM
Restricted Application edited projects, added Customer responded; removed Waiting on Author. · View Herald TranscriptFeb 24 2017, 12:56 PM
Restricted Application changed the task status from Feedback to Open. · View Herald Transcript
AndyP closed this task as Closed.Feb 24 2017, 12:57 PM

Issue has been fixed according to development.
Not seen it happen again in the last weeks.

AndyP moved this task from Unclassed to Archived on the Starmade board.Feb 24 2017, 12:57 PM