Page MenuHomeSchine - Phabricator

Starmade | converted blueprints have undocked entities as response fleet
Closed, FinishedPublic

Description

If a blueprint is converted into chunk32 from a chunk16 version of starmade, when that blueprint is used as part of a response fleet the docked entities will separate.

This can be worked around since spawning the blueprint as admin without use of a response fleet will spawn the entity with all docks connected, you can then blueprint this one in the chunk 32 environment and the new blueprint will function correctly in response fleets.

https://youtu.be/VmJEABd06q0

chunk16 test print:

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.199.484
Category
Engine
First occurrence (version)
0.199.132
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. blueprint a ship with docked entities in chunk 16 version of starmade (0.19556 in my case)
  2. copy that blueprint into release version (0.199.132)
  3. for ease of testing remove other blueprints leaving only the chunk16 one or turn off all permissions for enemy use except for this blueprint
  4. start game and make sure the blueprint has permissions enabled for all in the admin tab for blueprints
  5. trigger a response fleet from trade guild stick shop or pirate station

At this point the response fleets should spawn with all docked entities detached.

Tester information (Internal use only)

Only happens wit'h a response fleet, newly made blueprints are fine and only the converted ones are affected.

All entities undock from each other including the chains themselves.

Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

spunkie created this task.Aug 4 2016, 5:23 AM
spunkie updated the task description. (Show Details)Aug 4 2016, 5:47 AM
lancake added a subscriber: lancake.Aug 5 2016, 6:07 PM
lancake claimed this task.

-validated-

lancake shifted this object from the S1 Public space to the S3 Starmade space.Aug 5 2016, 6:12 PM
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
lancake edited Steps to reproduce. (Show Details)
lancake edited Tester information (Internal use only). (Show Details)
lancake set Last tested (version) to 0.199.132.
lancake changed Category from none/unspecified to Engine.
lancake changed First occurrence (version) from 0.199.132 rel to 0.199.132.
lancake renamed this task from Converted to chunk32 blueprints losing docked entities as response fleet to converted blueprints have undocked entities as response fleet.
lancake triaged this task as Release Blocker priority.
Restricted Application added a subscriber: AndyP. · View Herald TranscriptAug 5 2016, 6:12 PM
lancake moved this task from New / Unconfirmed to Open / Validated on the Issue Navigation board.EditedAug 5 2016, 6:12 PM
lancake moved this task from Open / Validated to Confirmed on the Issue Navigation board.
lancake changed the task status from Open to In Queue (Game).

-confirmed-

Only happens with a response fleet, newly made blueprints are fine and only the converted ones are affected.

All entities undock from each other including the chains themselves.

Restricted Application edited projects, added Game Development; removed Issue Navigation. · View Herald TranscriptAug 5 2016, 6:13 PM

Rabid stated in T1837:

"This started on our server recently. When the trade guild spawn in their turrets are there but detached, making turreted ships useless.

Occurs every time without exception. Players have reported the same for pirates but I am yet to confirm that.

The ships will spawn in properly if the /initiate_wave command is used to spawn the Trade Guild fleet or they are spawned in via the ship catalog.

Ships spawn properly when spawned in individually via blueprints."

schema added a subscriber: schema.Mar 9 2017, 5:11 PM

added admin command /simulation_send_response_fleet
added "remove all enemy usable" in admin tab

schema added a commit: Restricted Diffusion Commit.Mar 9 2017, 5:44 PM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptMar 9 2017, 5:44 PM
schema added a comment.Mar 9 2017, 5:44 PM

needs check for all things that spawn in db (including NPC faction fleet ships, although none of them are chunk16, so there isnt a problem)

Restricted Application added a project: Engine. · View Herald TranscriptMar 10 2017, 6:09 PM
AndyP moved this task from Backlog / Unclassed to Data on the Engine board.Mar 15 2017, 7:59 PM
AndyP edited projects, added Engine (Data); removed Engine.
AndyP moved this task from Backlog / Unclassed to Beta on the Engine (Data) board.Mar 16 2017, 7:14 PM
lancake changed the task status from Resolved to In Queue.Mar 16 2017, 11:01 PM

-QA Testing-

Blueprint spawns fine and checked "for all things that spawn in db"
There's one issue that I don't know if it's intended or not.

The response fleet doesn't save if you unload the sector and there wasn't an auto save before you did that. Every response fleet so far is gone when I TP back to their sector, unless I did a /force_save before I left.
Are they supposed to despawn after a while?

Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptMar 16 2017, 11:01 PM
lancake changed Last tested (version) from 0.199.132 to 0.199.484.Mar 16 2017, 11:01 PM

they despawn, yeah

schema changed the task status from In Queue to Resolved.Mar 21 2017, 12:19 AM

Intended behavior (to not clutter database with data)

Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptMar 21 2017, 12:19 AM
lancake closed this task as Closed.Apr 28 2017, 1:24 PM
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptApr 28 2017, 1:24 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript