Page MenuHomeSchine - Phabricator
Create Task
Maniphest T1683

Starmade | sell/buy prices affect purchase/sale orders and vice versa
Confirmed task for development, LowPublic
Actions

Description

Depending on which part of the shop interface is used, buy/sell prices appear in the opposite category in the other interface.

"Traditional" interface sell prices become "trade network" buy orders, buy prices become sell orders; likewise "trade network" sell orders become "traditional" buy prices and vice versa.

  1. Initial conditions (ignore existing orders): no order for Yellow Paint:
    no price set for Yellow Paint:
  2. Buy Yellow Paint at 10 cr.:
  3. Trade network shows sell order at 10 cr.:
  4. Order removed:
  5. Add buy order for Yellow Paint at 10 cr.:
  6. Shop now sells Yellow Paint at 10 cr.:

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.199.615
Category
Tradenetwork/Shops
First occurrence (version)
0.198.477
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. Create a shop and connect it to the trade network
  1. a)

Edit an item's SELL price from the basic shop interface ("SHOP" tab)
Check the shop's buy/sell orders ("SET PRICES" tab)
Item appears under "PURCHASES" category (lower half)

analogous:

2.b)
Edit an item's BUY price
Check orders
Item appears under "SALES" category (upper half)

analogous:

2.c)
Add a sale order from the trade network interface ("SET PRICES" tab)
Check the shop's items ("SHOP" tab)
Item's "BUY" price has been modified

analogous:

2.d)
Add a purchase order from the trade network interface ("SET PRICES" tab)
Check the shop's items ("SHOP" tab)
Item's "SELL" price has been modified

Tester information (Internal use only)

The dialogue menus for SET PURCHASE PRICE and SET SALE PRICE have the wrong title still (Edit Buy Price / Edit Sell Price).

Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

Valck created this task.Jul 15 2016, 1:38 PM
lancake added a subscriber: lancake.Jul 25 2016, 7:59 PM
lancake claimed this task.

-feedback-

Setting orders changes the shop price too, and wipes it if you remove the order. That's intended.

  • A sale sets the buy price.
  • A purchase sets the sell price.

The *shop* tab is used by other people, the *set price* tab is set by the shop owners. Meaning that if the owner wants to sell something, he changes the buy price for other players to use. Vice versa for sale/selling.

I don't see anything wrong with this.

lancake shifted this object from the S1 Public space to the S3 Starmade space.Jul 25 2016, 8:00 PM
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.
lancake changed Reproducible from uncertain to Yes.
lancake changed Last tested (version) from 0.198.477 to 0.199.112.
lancake changed Category from none/unspecified to Engine.
lancake set First occurrence (version) to 0.198.477.
lancake moved this task from New / Unconfirmed to Feedback on the Issue Navigation board.
lancake triaged this task as Low priority.
Valck added a comment.Jul 25 2016, 9:17 PM

As the shop owner, I find it surprising that if I set a sell order, the shop's sell price doesn't reflect this, but the buy price does.
What the customer gets to see is another thing entirely, but I think to me as the shop owner, the interface should coherently refer to sales prices as sales and purchase prices as purchases, no matter which part of the interface I view. If I place a buy order, I want to buy something; likewise, if I set the shop sell price, I intend to sell something to somebody at that price, and expect to find a sell order to that effect.

While you may call it working as intended, I at least find this interpretation confusing and frankly, opposite of how I'd expect it to work.

AndyP changed the task status from Open to Feedback.Feb 21 2017, 8:53 PM
Restricted Application added a project: Waiting on Author. · View Herald TranscriptFeb 21 2017, 8:53 PM
Restricted Application added a project: Waiting on Author. · View Herald TranscriptMar 10 2017, 5:44 PM
Valck added a comment.Mar 11 2017, 2:53 AM

No idea why this is repeatedly being tagged as "Waiting on Author"; without further input from Schine or more feedback from other players, all has been said as far as I am concerned.

Restricted Application edited projects, added Customer responded; removed Waiting on Author. · View Herald TranscriptMar 11 2017, 2:53 AM
Restricted Application changed the task status from Feedback to Open. · View Herald Transcript
lancake moved this task from Feedback to Confirmed on the Issue Navigation board.Jun 9 2017, 12:44 PM

I see. Main issue is then that the "Set price to Buy" and "Set price to Sell" for the shop owner (only the shop owner gets this anyway), should be switched around when it comes to function.
We might as well give them the exact same name as in the Trade Order one

SET PRICE TO BUY -> SET PURCHASE PRICE + Have it change purchase price instead of sale
SET PRICE TO SELL -> SET SALE PRICE + Have it change sale price instead of purchase.

lancake edited Tester information (Internal use only). (Show Details)Jun 9 2017, 12:45 PM
lancake changed Last tested (version) from 0.199.112 to 0.199.535.
lancake changed Category from Engine to Tradenetwork/Shops.
lancake renamed this task from Shops: sell/buy prices affect buy/sell orders and vice versa to sell/buy prices affect purchase/sale orders and vice versa.
lancake changed the task status from Open to In Queue.
lancake added a commit: Restricted Diffusion Commit.Jun 10 2017, 3:48 PM
lancake changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJun 10 2017, 3:48 PM
lancake changed the task status from Resolved to In Queue.Jun 22 2017, 2:59 PM

-QA Testing-

The dialogue menus for SET PURCHASE PRICE and SET SALE PRICE have the wrong title still (Edit Buy Price / Edit Sell Price).

Restricted Application edited projects, added Game Development, QA-Return; removed Quality Assurance. · View Herald TranscriptJun 22 2017, 2:59 PM
lancake edited Tester information (Internal use only). (Show Details)Jun 22 2017, 2:59 PM
lancake changed Last tested (version) from 0.199.535 to 0.199.615.