Page MenuHomeSchine - Phabricator

Launcher | Beta Launcher Allows blank install directories.
Closed, FinishedPublic

Description

Leaving the install directory blank defaults to '/' which on windows is the root drive you are operating on.

Expected:
To show an error with a blank path or substitute a default.

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Launcher
Reproducible
Yes
Last tested (version)
2.1.0 (build 907fae7) v169
Category
Launcher
First occurrence (version)
151
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

AndyP shifted this object from the S1 Public space to the S5 Launcher space.Jul 12 2016, 11:17 PM
AndyP changed the visibility from "Custom Policy" to "Public (No Login Required)".
AndyP changed the edit policy from "Task Author" to "Starmade (Project)".
AndyP changed the task status from Open to In Queue (Launcher).
AndyP claimed this task.
Restricted Application edited projects, added Launcher Development; removed Issue Navigation. · View Herald TranscriptJul 12 2016, 11:18 PM
calani added a subscriber: AndyP.Jul 13 2016, 2:21 AM
calani claimed this task.
calani triaged this task as Normal priority.
calani added a commit: Restricted Diffusion Commit.Jul 26 2016, 2:13 AM
calani changed the task status from In Queue (Launcher) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Launcher Development. · View Herald TranscriptJul 26 2016, 2:13 AM
calani added a commit: Restricted Diffusion Commit.Jul 26 2016, 2:13 AM
SmilingDemon changed the task status from Resolved to In Queue (Launcher).

-QA Testing-

placed a new launcher in D:\Starmade\Neuer Ordner
deleted the default install folder path
didnt got an error but ended up with this install path instead
D:\Starmade\Neuer Ordner\.cache\StarMade

this isnt good either because its unexpected for the user

either drop an error message or revert to the Path from the start
D:\Starmade\Neuer Ordner\StarMade

Restricted Application edited projects, added Launcher Development; removed Quality Assurance. · View Herald TranscriptAug 1 2016, 10:28 AM
SmilingDemon changed Last tested (version) from 151 to 158 fe18f38.Aug 1 2016, 11:29 AM
calani added a commit: Restricted Diffusion Commit.Sep 10 2016, 2:50 AM
calani changed the task status from In Queue (Launcher) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Launcher Development. · View Herald TranscriptSep 10 2016, 2:50 AM
lancake added a subscriber: lancake.

-QA Testing-

Fix confirmed on Windows 10 64 bit.

lancake changed Last tested (version) from 158 fe18f38 to 2.1.0 (build 907fae7) v169.Sep 26 2016, 3:35 PM
AndyP closed this task as Closed.Dec 15 2016, 12:44 AM
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptDec 15 2016, 12:44 AM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript