Page MenuHomeSchine - Phabricator
Create Task
Maniphest T1658

Starmade | shop price not set allows you to take and store for free
Closed, FinishedPublic
Actions

Description

When a block price is "not set" in a shop, anyone with sufficient permissions can store or take those blocks.

With shops having limited cargo now, anyone putting blocks into your shop could mess your day up.
And anyone able to take blocks you forgot to set the price for is even worse.

Both selling and buying shouldn't work when no price is set, only the owners should be able to take and put it in there for free.

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.199.533
Category
Tradenetwork/Shops
First occurrence (version)
0.198.416
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake created this task.Jul 8 2016, 6:06 PM
Restricted Application added a subscriber: AndyP. · View Herald TranscriptJul 8 2016, 6:06 PM
Benevolent27 added a subscriber: Benevolent27.Jul 31 2016, 5:51 AM
This comment was removed by Benevolent27.
lancake moved this task from Unclassed to Issue affecting current release on the Starmade board.Aug 9 2016, 6:04 PM
lancake raised the priority of this task from Pre-Release Quality Assurance to Release Blocker.
AndyP lowered the priority of this task from Release Blocker to Pre-Release Quality Assurance.Aug 22 2016, 7:07 AM
AndyP changed the task status from In Queue (Game) to In Queue.Mar 10 2017, 5:05 PM
Restricted Application added a project: Engine. · View Herald TranscriptMar 10 2017, 5:05 PM
AndyP changed Category from Engine to Tradenetwork/Shops.Mar 15 2017, 6:37 PM
Restricted Application edited projects, added Tradenetwork; removed Engine. · View Herald TranscriptMar 15 2017, 6:37 PM
AndyP moved this task from Backlog / Unclassed to Alpha on the Tradenetwork board.Mar 24 2017, 11:25 AM
AndyP edited projects, added Game Development (Alpha); removed Game Development.
schema changed the task status from In Queue to Resolved.Apr 5 2017, 1:18 PM
Restricted Application added a project: Quality Assurance. · View Herald TranscriptApr 5 2017, 1:18 PM
lancake added a comment.Apr 24 2017, 2:58 PM

The original issue wasn't there anymore, although shop interaction (take and put in as owner) were not working properly. Buttons were greyed out when they should not have been, an ownership problem even though I was the owner.
That's fixed now.

lancake changed Last tested (version) from 0.198.416 to 0.199.533.Apr 24 2017, 2:58 PM
lancake closed this task as Closed.Apr 28 2017, 1:24 PM
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptApr 28 2017, 1:24 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript