Page MenuHomeSchine - Phabricator

Starmade | new tutorial menu doesn't end processes when closed
Closed, FinishedPublic

Description

You should take care of that one quickly (or at least warn community about it) since it could be harmfull for the hardware and it extremely easy to reproduce it inadvertently. It's sufficient to just open a less than a dozen times tutorial's menu for possibly toasting its computer.

When we execute SM the tutorial menu is automatically processed and appeared in task manager as ffmpeg64.exe (I guess one for each video) which eat between 35 000~ 38 800 K memory each.
When we close the tutorial menu it won't close that process, so they are still process in the background. But worst, when we open the menu again, it open again 5 new rows of ffmpeg64.exe which stack with the previous one.


Here screen from my task manager after I opened the tutorial menu 3 times.


Here the memory climb cause by (per stage):

  1. StarMade dedicated server
  2. StarMade play screen
  3. 1st auto-openning of tuto (& close menu)
  4. 2nd time I open it (then close menu)
  5. 3rd time (and then close game)

I can't join the sound which made my computer when I attempted 5 times but it was really really nasty and that does not bode well.

logs:

, , , ,

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.198.146
Category
Ingame GUI/HUD
First occurrence (version)
0.198.141
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
NVIDIA
Video Card Model
GeForce GTX 960
Steps to reproduce
  1. Close and open Tutorial Menu repeatedly.
  2. Look at your task manager.
Tester information (Internal use only)

Not fixed.

If you play a video *in background*, you can go back to the *main menu* and the 2 created processes for that video will not end.
If you go in-game again and start a video, you'll create 2 more processes and end up with 4. Those 2 get killed properly if you just close the video but the other 2 remain till you shut down the game.

Detected video (Graphicsinfo.txt)

Running on thread: main
Adapter: vrvd5
Driver Version: 5.3.0.40
Vendor: NVIDIA Corporation
OpenGL Version: 4.5.0 NVIDIA 365.19
Renderer: GeForce GTX 960/PCIe/SSE2
GLSL Ver: 4.50 NVIDIA

Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>
Java Version (64bit)

java version "1.8.0_91"
Java <TM> SE Runtime Environment <build 1.8.0_71-b14>
Java HotSpot<TM> 64-Bit Server VM <build 25.71-b14, mixed mode>

Event Timeline

Restricted Application added a project: Issue Navigation. · View Herald TranscriptJun 1 2016, 8:48 PM
AndyP shifted this object from the S1 Public space to the S3 Starmade space.Jun 2 2016, 12:01 AM
AndyP changed the visibility from "Custom Policy" to "Public (No Login Required)".
AndyP changed the edit policy from "Task Author" to "Starmade (Project)".
AndyP renamed this task from New tutorials menu glitch bring about tremendous memory eating and could be extremely harmfull for hardware to New tutorials menu glitch bring about tremendous memory eating and high cpu load.
AndyP claimed this task.
AndyP triaged this task as High priority.

-Validated-

Well, high CPU load is not harmful for the hardware.
However duplicating the threads and load from video is not wanted, and should be limited in some way.

AndyP added a subscriber: AndyP.Jun 2 2016, 12:04 AM
AndyP removed AndyP as the assignee of this task.
lancake claimed this task.

-Confirmed-

For each video, it creates a ffmpeg64.exe process. I suppose that isn't too bad. Each one takes about 35MB of memory so it could quickly add up if we have 20 or more videos.
If this can be reduced, great.

The real issue though is that it never ends the process during your session. Closing the tutorial menu and re-opening creates 5 new ffmpeg64.exe processes but doesn't kill the old ones.

After trying that for a few times you end up with something like this:

lancake edited Steps to reproduce. (Show Details)Jun 2 2016, 11:37 AM
lancake edited Tester information (Internal use only). (Show Details)
lancake moved this task from Open / Validated to Confirmed on the Issue Navigation board.
lancake renamed this task from New tutorials menu glitch bring about tremendous memory eating and high cpu load to new tutorial menu doesn't end processes when closed.
lancake changed the task status from Open to In Queue (Game).
lancake raised the priority of this task from High to Pre-Release Quality Assurance.
Restricted Application edited projects, added Starmade, Game Development; removed Issue Navigation. · View Herald TranscriptJun 2 2016, 11:38 AM
schema changed the task status from In Queue (Game) to Resolved.Jun 4 2016, 7:46 PM
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJun 4 2016, 7:46 PM
lancake changed the task status from Resolved to In Queue (Game).Jun 4 2016, 10:19 PM

-QA Testing-

Not fixed.

If you play a video *in background*, you can go back to the *main menu* and the 2 created processes for that video will not end.
If you go in-game again and start a video, you'll create 2 more processes and end up with 4. Those 2 get killed properly if you just close the video but the other 2 remain till you shut down the game.

Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptJun 4 2016, 10:19 PM
lancake edited Tester information (Internal use only). (Show Details)Jun 4 2016, 10:19 PM
lancake changed First occurrence (version) from 0.198.136 to 0.198.141.
lancake changed the task status from In Queue (Game) to Resolved.Jun 4 2016, 10:30 PM

Should be fixed for 0.198.143

Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJun 4 2016, 10:30 PM
lancake closed this task as Closed.Jun 5 2016, 9:32 PM

-QA Testing-

Fix confirmed.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJun 5 2016, 9:32 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
lancake changed Last tested (version) from 0.198.136 to 0.198.146.Jun 5 2016, 9:33 PM
Restricted Application added a project: GUI/HUD. · View Herald TranscriptMar 10 2017, 6:12 PM