Page MenuHomeSchine - Phabricator
Create Task
Maniphest T1330

Starmade | Search bar keeps focus when using right click resulting in unwanted behavior
Closed, FinishedPublic
Actions

Description



I used filter...


... and when I want split it, it's write the amount in the search bar instead of the Split Inventory Slot Menu ; even if the 1 is enlighted by default. The player as to click on that bar again to be able to write the amount.

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.197.37
Category
Ingame GUI/HUD
First occurrence (version)
0.197.2 (Dev)
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. Open storage inventory
  2. Put a test pile of items, i.e. Power reactor module
  3. Typing in search bar (i.e. "power")
  4. Right click on Power module in order to open the Split Menu
  5. Type the amount of chosen item
  6. This amount appear in search bar instead of Split Menu even if the 1 is enlighted.
Tester information (Internal use only)

If you use the split menu after searching for an item, the *search for name* filter will still have focus. If you type something in the split menu, it will do the same for the search filter.

All menus with search bars have this problem
While left clicking anywhere removes its focus, it doesn't work for right clicking.

Solution: right clicking anywhere, disables the focus on the search bar. (Left click already does that)

Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

Croquelune updated the task description. (Show Details)Apr 7 2016, 8:01 AM
Croquelune changed Category from none/unspecified to Ingame GUI/HUD.
Croquelune edited Serverconfig (server.cfg). (Show Details)
Croquelune edited Clientconfig (settings.cfg). (Show Details)
Croquelune changed Reproducible from uncertain to Yes.
Croquelune set Last tested (version) to 0.197.2 .
Croquelune edited Steps to reproduce. (Show Details)
Croquelune added a subscriber: Croquelune.
Croquelune created this task.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptApr 7 2016, 8:01 AM
Croquelune updated the task description. (Show Details)Apr 7 2016, 8:03 AM
Croquelune set Task Type to Bug.
Croquelune set OS-Specific to No.
Croquelune set Hardware-Specific to No.
Croquelune set Video Card Vendor to uncertain.
Croquelune set Affected Gamemode(s) to none/unspecified.
lancake added a subscriber: lancake.Apr 7 2016, 11:55 AM
lancake claimed this task.

-Validated-
-Confirmed-

If you use the split menu after searching for an item, the *search for name* filter will still have focus. If you type something in the split menu, it will do the same for the search filter.

Solution: right clicking in anywhere, disables the focus on the search bar. (Left click already does that)

lancake shifted this object from the S1 Public space to the S3 Starmade space.Apr 7 2016, 11:58 AM
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
lancake set First occurrence (version) to 0.197.2 (Dev).
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.
lancake changed Last tested (version) from 0.197.2 to 0.197.2 (Dev).
lancake edited Tester information (Internal use only). (Show Details)
lancake moved this task from New / Unconfirmed to Confirmed on the Issue Navigation board.
lancake renamed this task from Impossible to choose the amount of items while using inventory search bar to Search bar keeps focus when using right click resulting in unwanted behavior.
lancake changed the task status from Open to In Queue (Game).
lancake triaged this task as Trivial priority.
Restricted Application edited projects, added Starmade, Game Development; removed Issue Navigation. · View Herald TranscriptApr 7 2016, 11:59 AM
Croquelune added a comment.EditedApr 9 2016, 7:41 AM
In T1330#50760, @lancake wrote:

Solution: right clicking in anywhere, disables the focus on the search bar. (Left click already does that)

I would rather said "Solution : When a filling number menu open, let him take priority on everything else"

Because players are lazy, they'll be quite irratated while have their hands on the keyboards for filter menu, to be force to hand away to their mouse just to unfocus menu when they'll have to choose a number and have their hands over keyboard again. It's quite nonsense from ergonomics point of view.
The split menu should react like the display module since the text is highlighted, that means typing text will filling the right menu (= the highlighted text from menu in the foreground).

schema added a commit: Restricted Diffusion Commit.Apr 15 2016, 1:07 AM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptApr 15 2016, 1:07 AM
lancake added a comment.Apr 15 2016, 5:31 PM
In T1330#51261, @Croquelune wrote:
In T1330#50760, @lancake wrote:

Solution: right clicking in anywhere, disables the focus on the search bar. (Left click already does that)

I would rather said "Solution : When a filling number menu open, let him take priority on everything else"
Because players are lazy, they'll be quite irratated while have their hands on the keyboards for filter menu, to be force to hand away to their mouse just to unfocus menu when they'll have to choose a number and have their hands over keyboard again. It's quite nonsense from ergonomics point of view.
The split menu should react like the display module since the text is highlighted, that means typing text will filling the right menu (= the highlighted text from menu in the foreground).

That's what I suggested. Currently both the search bar and the number menu takes focus. The solution would only make the number menu take focus.
I probably misread/misunderstood you since your explanation is a bit confusing.

lancake closed this task as Closed.Apr 15 2016, 5:40 PM

-QA Testing-

Works as suggested.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptApr 15 2016, 5:40 PM
lancake changed Last tested (version) from 0.197.2 (Dev) to 0.197.37.Apr 15 2016, 5:40 PM
Croquelune added a comment.Apr 16 2016, 7:05 AM
In T1330#51977, @lancake wrote:

I probably misread/misunderstood you since your explanation is a bit confusing.

Eventually I was the one who misread & misunderstood you. ;-)

lancake mentioned this in Unknown Object (Maniphest Task).Apr 17 2016, 10:33 AM
Restricted Application added a project: GUI/HUD. · View Herald TranscriptMar 10 2017, 6:14 PM