Page MenuHomeSchine - Phabricator
Create Task
Maniphest T1105

Launcher | Add hotfix indication to version dropdown entries
Closed, FinishedPublic
Actions

Description

Currently the version dropdown shows multiple identical-looking versions when there are hotfix builds. Whether by using a "(Hotfix #%i)" marker or actually showing their build timestamp, these hotfix versions should be marked in some way to make it obvious which is which.

Ex:

v0.19550
v0.19549
v0.19548
v0.19548
v0.19548
v0.19547

Any recommendations on how to differentiate these?

I'm strongly considering using (Hotfix #%i) because it's short and easy to read, and this change is entirely cosmetic anyway:

v0.19548 (Hotfix #2)
v0.19548 (Hotfix #1)
v0.19548

My only qualm about it is that Hotfix #2 doesn't actually mean anything: the marker only lives within the launcher and has no meaning outside of it.
Using the version's build id 20160116_005338 instead, however, is longer and far too ugly and hard to read.

... There's also the edge-case of (for example) v1.79952 (Hotfix #1) (Latest) to consider -- it's much too long for the dropdown.

Details

Commits
Restricted Diffusion Commit
Task Type
Feature
Testing Results
Affected Gamemode(s)
Launcher
Reproducible
uncertain
Last tested (version)
158 fe18f38
Category
Launcher
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Related Objects

Event Timeline

calani updated the task description. (Show Details)Jan 29 2016, 11:09 PM
calani shifted this object from the S1 Public space to the S5 Launcher space.
calani changed Task Type from Bug to Feature.
calani changed Category from none/unspecified to Launcher.
calani edited Serverconfig (server.cfg). (Show Details)
calani edited Clientconfig (settings.cfg). (Show Details)
calani added a subscriber: calani.
calani created this task.
calani raised the priority of this task from to Low.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptJan 29 2016, 11:09 PM
AndyP changed the visibility from "Custom Policy" to "Public (No Login Required)".Jan 30 2016, 2:57 PM
AndyP changed the edit policy from "Task Author" to "Starmade (Project)".
AndyP set OS-Specific to No.
AndyP set Hardware-Specific to No.
AndyP set Video Card Vendor to uncertain.
AndyP set Affected Gamemode(s) to none/unspecified.
AndyP set Reproducible to uncertain.
AndyP changed the task status from Open to In Queue (Launcher).
AndyP claimed this task.
Restricted Application edited projects, added Starmade, Launcher Development; removed Issue Navigation. · View Herald TranscriptJan 30 2016, 2:57 PM
calani added a comment.Mar 28 2016, 10:39 PM

Really, this should be handled by better versioning -- ex: SemVer

AndyP added a comment.Apr 3 2016, 7:09 PM

yeah, time to switch to it :P

calani added a commit: Restricted Diffusion Commit.Jun 30 2016, 2:17 AM
calani changed the task status from In Queue (Launcher) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Launcher Development. · View Herald TranscriptJun 30 2016, 2:17 AM
SmilingDemon added a subscriber: SmilingDemon.Aug 1 2016, 8:14 PM

-QA Testing-

fixed on win 7 and Ubuntu

duplicate clientside hotfixes do get a,b,c etc appended

SmilingDemon changed Affected Gamemode(s) from none/unspecified to Launcher.Aug 1 2016, 10:31 PM
SmilingDemon set Last tested (version) to 158 fe18f38 .
Valiant70 added a subscriber: Valiant70.Aug 2 2016, 12:00 AM

Fixed on OSX as well.

SmilingDemon closed this task as Closed.Aug 2 2016, 7:54 AM

Good .. thank you for checking

closing as fixed

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptAug 2 2016, 7:54 AM