An incorrect buildindex with multiple duplicate entries should not cause the launcher to misbehave and display them all.
Add some intelligence to the version parsing and remove duplicates.
Description
Description
Details
Details
- Commits
- Restricted Diffusion Commit
Restricted Diffusion Commit - Task Type
- Bug
Testing Results
- Affected Gamemode(s)
- none/unspecified
- Reproducible
- uncertain
- Category
- Launcher
Hardware/Software/System
- OS-Specific
- No
- Hardware-Specific
- No
- Video Card Vendor
- uncertain
Tester information (Internal use only)
Note:
version and build differ -- This ticket should apply to removing entries that are completely identical (path, version, and build all match), not just differing in the version that the launcher displays in the build-select dropdown.
(I may change how the launcher displays these versions in the future to prevent confusion, but that isn't the focus of this ticket)
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>
Related Objects
Related Objects
- Mentioned Here
- T1105: Add hotfix indication to version dropdown entries
Event Timeline
Comment Actions
Works fine for the windows version. I'm not sure how it deals with hotfix release builds since those have the exact same release version as the previous one.
Would it filter out the older duplicates or ignore them?
Comment Actions
@lancake:
"This ticket should apply to removing entries that are completely identical (path, version, and build all match), not just differing in the version that the launcher displays in the build-select dropdown."
Basically, it should only disallow complete duplicates (not just duplicate version numbers), e.g. within http://files.star-made.org/devbuildindex
Matching version numbers with differing builds is instead covered by T1105 (adding hotfix indication) though honestly, that is just sugar and really should be handled with thein game's actual version numbers instead. (ex: using SemVer)
Comment Actions
I second that recommendation to move to SemVer's scheme for version IDs, or at least something similar...