Page MenuHomeSchine - Phabricator

Launcher | The launcher run via steam should manage its own install directory.
Closed, DuplicatePublic

Description

The launcher should not ask for an install directory when run via steam. It should 'just work.'

That said, what's a good default directory? %appdata%\StarMade? documents\my_games?

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
none/unspecified
Reproducible
uncertain
Category
Launcher
First occurrence (version)
2.0.0
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

calani updated the task description. (Show Details)Jan 27 2016, 7:09 AM
calani shifted this object from the S1 Public space to the S5 Launcher space.
calani changed the edit policy from "Task Author" to "Launcher Development (Project)".
calani changed Category from none/unspecified to Launcher.
calani set First occurrence (version) to 2.0.0.
calani edited Serverconfig (server.cfg). (Show Details)
calani edited Clientconfig (settings.cfg). (Show Details)
calani added a subscriber: calani.
calani created this task.
calani raised the priority of this task from to High.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptJan 27 2016, 7:09 AM
Restricted Application added a subscriber: AndyP. · View Herald Transcript
calani set Task Type to Bug.Jan 27 2016, 7:10 AM
calani set OS-Specific to No.
calani set Hardware-Specific to No.
calani set Video Card Vendor to uncertain.
calani set Affected Gamemode(s) to none/unspecified.
calani set Reproducible to uncertain.
calani changed the task status from Open to In Queue (Launcher).
Restricted Application edited projects, added Starmade, Launcher Development; removed Issue Navigation. · View Herald TranscriptJan 27 2016, 7:10 AM
calani added a comment.Jun 3 2016, 8:55 PM

Okay, Steam installs (--steam on a first/clean run) should automatically select the install directory now based on path:

When SteamApps/common/StarMade:
automatically install to SteamApps/common/StarMade/StarMade

When SteamApps/common/???:
automatically install to SteamApps/common/???/StarMade
(??? can be any number of folders deep; this allows for users to move the game's folder around and have it still install correctly)

When SteamApps/common does not exist in the path:
display default install directory and let the user choose

When --steam flag is absent:
display default install directory and let the user choose


However, I am unsure if the "default install directory" is a good choice on Linux or OSX.
Please test this and the above conditions!

calani added a commit: Restricted Diffusion Commit.Jun 3 2016, 11:31 PM
calani changed the task status from In Queue (Launcher) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Launcher Development. · View Herald TranscriptJun 3 2016, 11:31 PM
calani changed the visibility from "Custom Policy" to "Schine (Project)".Jun 10 2016, 8:07 PM
calani changed the visibility from "Schine (Project)" to "All Users".Jun 10 2016, 8:23 PM
Restricted Application added a subscriber: Megacrafter127. · View Herald TranscriptJun 10 2016, 8:23 PM

Note: You do not need Steam installed to test this feature.

To mimic the Steam behavior, simply create Steam's folder structure (e.g. Steam/SteamApps/common/StarMade) and run the (clean) launcher from within that directory with the --steam flag.

lancake changed the visibility from "All Users" to "Public (No Login Required)".Jun 10 2016, 8:35 PM
lancake changed the edit policy from "Launcher Development (Project)" to "Starmade (Project)".
lancake added a subscriber: lancake.
lancake claimed this task.
lancake removed lancake as the assignee of this task.

Hm odd, I've tried both of the beta builds, and a normal build. but seems my launcher version on steam is 2.0.4, not 2.0.6.
I had it auto update only once and it didn't seem to update to the latest one (maybe a newer 2.0.4, didn't check build)

I threw the 2.0.6 version in there myself, deleted the appdata again but it still shows me the roaming path.

In your comments you mentioned ../SteamApps/common
However, steamapps is in lower case for me ../steamapps/common
So I guess in my case it would always use the default one?

I tried the "non steam" installation with my own test folder using the SteamApps path, that gave me something weird (see screenshot) and unfortunately the installation path is still referring to my appdata/roaming/Starmade folder

In the screenshot you already see the continue button even before accepting the Eula.

calani changed the task status from Resolved to Open.
Restricted Application edited projects, added Issue Navigation; removed Launcher Development. · View Herald TranscriptJun 14 2016, 1:26 AM
Restricted Application edited projects, added Issue Navigation; removed Launcher Development. · View Herald TranscriptJun 14 2016, 1:26 AM

I've removed the --steam requirement for the automatic install path, which should resolve this.
I also may have fixed the overlapping pages issue. I wasn't able to duplicate it, however, and couldn't find a cause.

I may additionally replace the default install directory with simply ./StarMade; i'm undecided as this could potentially cause permissions issues when installed within specific directories (e.g. %programfiles%, /bin, etc.)

calani added a commit: Restricted Diffusion Commit.Jun 14 2016, 2:25 AM
calani changed the task status from Open to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Issue Navigation. · View Herald TranscriptJun 14 2016, 2:25 AM
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJun 14 2016, 11:35 PM
Restricted Application removed subscribers: Megacrafter127, AndyP. · View Herald Transcript