Page MenuHomeSchine - Phabricator

Starmade | create docking doesn't create rail docker when going in an uninitialized chunk
Confirmed task for development, NormalPublic

Description

Outdated description below, see tester information for up-to-date info


You get a nullpointer when you move the highlight in an unintialized chunk while using "create docking"

Logs:

[2016-01-10 01:26:52] java.lang.NullPointerException
[2016-01-10 01:26:52] 	at obfuscated.hb.c(SourceFile:1593)
[2016-01-10 01:26:52] 	at obfuscated.hb.b_(SourceFile:239)
[2016-01-10 01:26:52] 	at obfuscated.hP.b_(SourceFile:401)
[2016-01-10 01:26:52] 	at obfuscated.hr.f(SourceFile:513)
[2016-01-10 01:26:52] 	at obfuscated.hr.b(SourceFile:673)
[2016-01-10 01:26:52] 	at obfuscated.hr.b_(SourceFile:368)
[2016-01-10 01:26:52] 	at obfuscated.auZ.e(SourceFile:782)
[2016-01-10 01:26:52] 	at obfuscated.auZ.a(SourceFile:1167)
[2016-01-10 01:26:52] 	at obfuscated.C.h(SourceFile:2845)
[2016-01-10 01:26:52] 	at obfuscated.OY.run(SourceFile:92)
[2016-01-10 01:26:52] 	at java.lang.Thread.run(Unknown Source)
[2016-01-10 01:26:56] AGAIN PRINTING STACK TRACE

easy to reproduce as described
got the same nullpointer on testing

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.197.2 (Dev)
Category
Engine
First occurrence (version)
0.19431
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce

# Spawn a shipcore, place a rail basic down near the core
# use "create docking" and click on that rail basic
# move away from it till you enter a chunk that should not be initialized yet
# get nullpointer


  1. Spawn a shipcore, place a rail basic down near the core
  2. use "create docking" and click on that rail basic
  3. move away from it, around 100 blocks should be enough
  4. confirm the location and create a dock
  5. notice how no rail docker was created
Tester information (Internal use only)

If you place down a ship core in an uninitialized chunk, it spawns one but it doesn't create a rail docker. I'm not entirely sure if it is related to initialized/uninitialized chunks but moving far enough from a new ship core should cause a rail docker to not spawn. It's fine when you're close enough.


Same behaviour as before, if you have problems reproducing it, pm me. It spawns a ship core, but the rail docker doesn't.

Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake updated the task description. (Show Details)Jan 10 2016, 12:30 AM
lancake shifted this object from the S1 Public space to the S3 Starmade space.
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
lancake changed Category from none/unspecified to Engine.
lancake set First occurrence (version) to 0.19431.
lancake edited Serverconfig (server.cfg). (Show Details)
lancake edited Clientconfig (settings.cfg). (Show Details)
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.
lancake changed Reproducible from uncertain to Yes.
lancake set Last tested (version) to 0.19542 (Dev).
lancake edited Steps to reproduce. (Show Details)
lancake added a subscriber: lancake.
lancake created this task.
lancake raised the priority of this task from to High.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptJan 10 2016, 12:30 AM
Restricted Application added a subscriber: AndyP. · View Herald Transcript
SmilingDemon changed the task status from Open to In Queue (Game).EditedJan 11 2016, 6:58 PM
SmilingDemon claimed this task.

-Confirmed-
using shift to move faster in build mode causes this to be very easily reproduceable

Restricted Application edited projects, added Starmade, Game Development; removed Issue Navigation. · View Herald TranscriptJan 11 2016, 6:59 PM
SmilingDemon updated the task description. (Show Details)Jan 11 2016, 7:01 PM
SmilingDemon set Task Type to Bug.
SmilingDemon set OS-Specific to No.
SmilingDemon set Hardware-Specific to No.
SmilingDemon set Video Card Vendor to uncertain.
SmilingDemon moved this task from Unclassed to Issue affecting current release on the Starmade board.
SmilingDemon changed Last tested (version) from 0.19542 (Dev) to 0.19543 (Dev).Jan 12 2016, 7:59 AM
SmilingDemon edited Tester information (Internal use only). (Show Details)
schema added a subscriber: schema.Jan 28 2016, 8:58 PM
schema changed the task status from In Queue (Game) to Resolved.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJan 28 2016, 8:58 PM
lancake changed the task status from Resolved to In Queue (Game).EditedJan 28 2016, 11:02 PM

-QA Testing-

Partially fixed.

If you place down a ship core in an uninitialized chunk, it spawns one but it doesn't create a rail docker. I'm not entirely sure if it is related to initialized/uninitialized chunks but moving far enough from a new ship core should cause a rail docker to not spawn. It's fine when you're close enough.

Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptJan 28 2016, 11:02 PM
lancake edited Steps to reproduce. (Show Details)Jan 28 2016, 11:05 PM
lancake edited Tester information (Internal use only). (Show Details)
schema changed the task status from In Queue (Game) to Resolved.Apr 6 2016, 7:10 PM
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptApr 6 2016, 7:10 PM

-QA Testing-

Same behaviour as before, if you have problems reproducing it, pm me.

lancake changed Last tested (version) from 0.19543 (Dev) to 0.197.2 (Dev).Apr 6 2016, 11:11 PM
lancake edited Tester information (Internal use only). (Show Details)
lancake changed the task status from Resolved to In Queue (Game).
Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptApr 6 2016, 11:11 PM
lancake edited Steps to reproduce. (Show Details)Apr 7 2016, 7:34 PM
lancake edited Tester information (Internal use only). (Show Details)
lancake updated the task description. (Show Details)Apr 25 2016, 11:55 AM
lancake renamed this task from create docking throws nullpointer when going in an uninitialized chunk to create docking doesn't create rail docker when going in an uninitialized chunk.
lancake mentioned this in Unknown Object (Maniphest Task).Apr 26 2016, 10:13 AM
AndyP changed the task status from In Queue (Game) to In Queue.Mar 10 2017, 5:06 PM
Restricted Application added a project: Engine. · View Herald TranscriptMar 10 2017, 5:06 PM
AndyP moved this task from Backlog / Unclassed to Building on the Engine board.Mar 15 2017, 8:03 PM
AndyP edited projects, added Engine (Building); removed Engine.
lancake lowered the priority of this task from High to Normal.Jul 4 2017, 2:01 PM