Page MenuHomeSchine - Phabricator

Starmade | Cargo visual representation is incorrect
Not feasible, TrivialPublic

Description

Currently 3 issues where the used cargo capacity versus max capacity isn't represented correctly:

Issue 1:
Slab blocks count as "full" blocks. In this example I have 5 cargo blocks, since each cargo block can have 4 different sizes, the representation changes every 5% capacity.
However, since slabs count as full blocks, it only changes for every 20% capacity.

Example: 99% capacity for 5 cargo blocks


Example: 79% capacity for 5 cargo blocks

In both cases the amount of cargo blocks used is correct:

  • 99% capacity is between 80 and 100 so 5 out of 5 are used.
  • 79% capacity is between 60 and 80 so 4 out of 5 are used.

Visually though, 99% capacity shows 2 full blocks which is 40% capacity. 79% capacity shows 1.5 full blocks so 30% capacity.

Issue 2: Reaching exactly 100% capacity with 2 or more stacks seems to count as 99.99999%
Example:


Versus

Issue 3: using multiple cargo groups uses each groups own capacity to fill, and not the total capacity.

Example: 2 cargo groups, each group has 100 capacity but 200 total.


As you can see, both groups appear full even though I only use 50% capacity. That's because it uses the wrong current capacity per group.

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.19514 (Dev)
Category
Control Block System: Functional
First occurrence (version)
0.19504 (Dev)
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain

Event Timeline

lancake updated the task description. (Show Details)Nov 29 2015, 1:43 PM
lancake shifted this object from the S1 Public space to the S3 Starmade space.
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
lancake changed Category from none/unspecified to Control Block System: Functional.
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.
lancake set First occurrence (version) to 0.19504 (Dev).
lancake changed Reproducible from uncertain to Yes.
lancake set Last tested (version) to 0.19504 (Dev).
lancake edited Serverconfig (server.cfg). (Show Details)
lancake edited Clientconfig (settings.cfg). (Show Details)
lancake added a subscriber: lancake.
lancake created this task.
lancake claimed this task.
lancake raised the priority of this task from to Release Blocker.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptNov 29 2015, 1:43 PM
Restricted Application added a subscriber: AndyP. · View Herald Transcript
lancake set Task Type to Bug.Nov 29 2015, 1:43 PM
lancake set OS-Specific to No.
lancake set Hardware-Specific to No.
lancake set Video Card Vendor to uncertain.
lancake moved this task from New / Unconfirmed to Open / Validated on the Issue Navigation board.
lancake moved this task from Open / Validated to Confirmed on the Issue Navigation board.
lancake changed the task status from Open to In Queue (Game).

-Confirmed-

Restricted Application edited projects, added Game Development, Starmade; removed Issue Navigation. · View Herald TranscriptNov 29 2015, 1:44 PM
AndyP lowered the priority of this task from Release Blocker to Pre-Release Quality Assurance.Nov 29 2015, 1:45 PM
schema added a commit: Restricted Diffusion Commit.Nov 30 2015, 3:55 PM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptNov 30 2015, 3:55 PM
lancake changed the task status from Resolved to In Queue (Game).Nov 30 2015, 7:15 PM

-QA Testing-

The grouping issue appears to be fixed, 2 issues remaining though:

  • the system doesn't account for the base capacity size of a chest. It immediately starts filling cargo space blocks even though every chest has its own default volume. It should only start doing that after the base capacity of that chest has been reached.
  • If you count up the full blocks with the slabs, you still don't reach the amount that it should be. The slab size never changes till it reaches a threshold where the block should be seen as a full one, then it changes into a full cargo block. Before that it doesn't use the other 2 slab types though and it seems to just randomly pick 1 slab and stick with it.

quick example for 1 cargo space of what it should be:

CapacitySlab used
[0%-25%]1/4 Slab
]25%-50%]2/4 Slab
]50%-75%]3/4 Slab
]75%-100%]4/4 Slab (full block)
Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptNov 30 2015, 7:16 PM
lancake changed Last tested (version) from 0.19504 (Dev) to 0.19507 (Dev).Nov 30 2015, 7:16 PM
schema added a subscriber: schema.Dec 1 2015, 4:51 PM

The goal here is more to visually please. if everything is uniform, it wouldn't look good

lancake changed Last tested (version) from 0.19507 (Dev) to 0.19514 (Dev).Dec 4 2015, 6:30 PM
lancake lowered the priority of this task from Pre-Release Quality Assurance to Trivial.
lancake changed the task status from In Queue (Game) to wontfix.Nov 30 2016, 11:04 AM
Restricted Application removed a project: Game Development. · View Herald TranscriptNov 30 2016, 11:04 AM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
Restricted Application added a project: CBS: Functional. · View Herald TranscriptMar 10 2017, 6:21 PM
AndyP edited Serverconfig (server.cfg). (Show Details)Mar 11 2017, 8:54 PM
AndyP edited Clientconfig (settings.cfg). (Show Details)
Restricted Application removed a project: CBS: Functional. · View Herald TranscriptMar 11 2017, 8:56 PM
Restricted Application added a project: CBS: Functional. · View Herald TranscriptMar 11 2017, 8:56 PM
AndyP added a comment.Mar 11 2017, 8:57 PM
This comment was removed by AndyP.
Restricted Application removed a project: CBS: Functional. · View Herald TranscriptMar 11 2017, 8:57 PM