Page MenuHomeSchine - Phabricator
Create Task
Maniphest T775

Launcher | Launcher should support a --steam flag
Closed, FinishedPublic
Actions

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Feature
Testing Results
Affected Gamemode(s)
none/unspecified
Reproducible
Yes
Last tested (version)
2.0.0 - 95
Category
Launcher
First occurrence (version)
0.0.3
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Tester information (Internal use only)

SmilingDemon added a comment.Edited · Via Web ·
Wed, Jan 27, 19:02
Comment Actions

-QA Testing-

Launcher now passes the Login section without problems on Win7 and ubuntu14.04 64bit and starts the game just fine.

asked around .. also starts with Steam client installed

Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Related Objects

Event Timeline

• wedtm updated the task description. (Show Details)Oct 26 2015, 7:24 AM
• wedtm shifted this object from the S1 Public space to the Restricted Space space.
• wedtm changed Task Type from Bug to Feature.
• wedtm changed Category from none/unspecified to Launcher.
• wedtm set First occurrence (version) to 0.0.3.
• wedtm changed Reproducible from uncertain to Yes.
• wedtm edited Serverconfig (server.cfg). (Show Details)
• wedtm edited Clientconfig (settings.cfg). (Show Details)
• wedtm added a subscriber: • wedtm.
• wedtm created this task.
• wedtm claimed this task.
• wedtm raised the priority of this task from to Urgent.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptOct 26 2015, 7:24 AM
Restricted Application added a subscriber: AndyP. · View Herald Transcript
lancake added a subscriber: lancake.Oct 26 2015, 12:16 PM
lancake claimed this task.

-Validated-

lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".Oct 26 2015, 12:16 PM
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
lancake set Affected Gamemode(s) to none/unspecified.
lancake set Last tested (version) to 0.0.3.
lancake set OS-Specific to No.
lancake set Hardware-Specific to No.
lancake set Video Card Vendor to uncertain.
lancake moved this task from New / Unconfirmed to Open / Validated on the Issue Navigation board.
lancake moved this task from Open / Validated to Confirmed on the Issue Navigation board.
lancake changed the task status from Open to In Queue (Game).
Restricted Application edited projects, added Game Development, Starmade; removed Issue Navigation. · View Herald TranscriptOct 26 2015, 12:17 PM
lancake changed the task status from In Queue (Game) to In Queue (Launcher).Oct 26 2015, 12:17 PM
lancake reassigned this task from lancake to • wedtm.
Restricted Application edited projects, added Launcher Development; removed Game Development. · View Herald TranscriptOct 26 2015, 12:17 PM
AndyP shifted this object from the Restricted Space space to the S5 Launcher space.Oct 26 2015, 10:17 PM
calani added a commit: Restricted Diffusion Commit.Jan 22 2016, 2:55 AM
calani changed the task status from In Queue (Launcher) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Launcher Development. · View Herald TranscriptJan 22 2016, 2:55 AM
calani added a subscriber: calani.Jan 22 2016, 3:44 AM

Note: this change currently only has one visible effect: the visibility of the steam account linking section of the launcher options.

SmilingDemon added a subscriber: SmilingDemon.Jan 22 2016, 10:35 PM
SmilingDemon changed the task status from Resolved to In Queue (Launcher).

Starting the Launcher as a fresh install without a Steam client installed crashes when trying to Login.
Skipping the Login part lets you start it just fine.
output from win7 cmd prompt:

Microsoft Windows [Version 6.1.7601]
Copyright (c) 2009 Microsoft Corporation. Alle Rechte vorbehalten.C:\Users\Q>"C:\Users\Q\Desktop\Starmade Launcher.lnk"C:\Users\Q>[2284:0122/231411:INFO:renderer_main.cc(200)] Renderer process starte
d[1408:0122/231458:INFO:renderer_main.cc(200)] Renderer process started
[3144:0122/231458:INFO:renderer_main.cc(200)] Renderer process started
[3632:0122/231514:INFO:CONSOLE(12450)] "ReferenceError: steam is not defined
   at D:\Starmade\starmade-launcher-win32-x64\resources\app.asar\lib\main.js:15
5:51
   at D:\Starmade\starmade-launcher-win32-x64\resources\app.asar\node_modules\a
ngular\angular.js:10249:13
   at processQueue (D:\Starmade\starmade-launcher-win32-x64\resources\app.asar\
node_modules\angular\angular.js:14678:28)
   at D:\Starmade\starmade-launcher-win32-x64\resources\app.asar\node_modules\a
ngular\angular.js:14694:27
   at Scope.$eval (D:\Starmade\starmade-launcher-win32-x64\resources\app.asar\n
ode_modules\angular\angular.js:15922:28)
   at Scope.$digest (D:\Starmade\starmade-launcher-win32-x64\resources\app.asar
\node_modules\angular\angular.js:15733:31)
   at Scope.$apply (D:\Starmade\starmade-launcher-win32-x64\resources\app.asar\
node_modules\angular\angular.js:16030:24)
   at done (D:\Starmade\starmade-launcher-win32-x64\resources\app.asar\node_mod
ules\angular\angular.js:10545:47)
   at completeRequest (D:\Starmade\starmade-launcher-win32-x64\resources\app.as
ar\node_modules\angular\angular.js:10717:7)
   at XMLHttpRequest.requestLoaded (D:\Starmade\starmade-launcher-win32-x64\res
ources\app.asar\node_modules\angular\angular.js:10658:9)", source: D:\Starmade\s
tarmade-launcher-win32-x64\resources\app.asar\node_modules\angular\angular.js (1
2450)
Restricted Application edited projects, added Launcher Development; removed Quality Assurance. · View Herald TranscriptJan 22 2016, 10:35 PM
SmilingDemon reassigned this task from • wedtm to calani.Jan 22 2016, 10:36 PM
calani added a commit: Restricted Diffusion Commit.Jan 23 2016, 8:52 AM
calani changed the task status from In Queue (Launcher) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Launcher Development. · View Herald TranscriptJan 23 2016, 8:52 AM
SmilingDemon changed the task status from Resolved to In Queue (Launcher).Jan 23 2016, 10:34 AM
Restricted Application edited projects, added Launcher Development; removed Quality Assurance. · View Herald TranscriptJan 23 2016, 10:34 AM
SmilingDemon raised the priority of this task from Urgent to Release Blocker.Jan 24 2016, 12:19 AM
calani added a comment.Jan 26 2016, 12:33 AM

@SmilingDemon: This should be fixed with one of the latest commits; I'm unsure, however, as we have been unable to reproduce the bug on any system or vm. You can test it when the build server is working again ~

SmilingDemon added a comment.Jan 26 2016, 8:43 AM

i did tried it last with download 79 ... will try again when there is a newer one

calani changed the task status from In Queue (Launcher) to Resolved.Jan 26 2016, 10:59 PM
Restricted Application edited projects, added Quality Assurance; removed Launcher Development. · View Herald TranscriptJan 26 2016, 10:59 PM
SmilingDemon added a comment.EditedJan 27 2016, 6:02 PM

-QA Testing-

Launcher now passes the Login section without problems on Win7 and ubuntu14.04 64bit and starts the game just fine.

asked around .. also starts with Steam client installed

SmilingDemon changed Last tested (version) from 0.0.3 to 2.0.0 - 95.Jan 27 2016, 10:23 PM
SmilingDemon edited Tester information (Internal use only). (Show Details)
SmilingDemon closed this task as Closed.
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJan 27 2016, 10:23 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
Restricted Application removed a subscriber: AndyP. · View Herald TranscriptJan 27 2016, 11:02 PM