Page MenuHomeSchine - Phabricator
Create Task
Maniphest T769

Starmade | Null pointer when pasting linked modules in un-initialized chunks.
Closed, FinishedPublic
Actions

Description

Can't seem to reproduce it immediately, but it happened right after I pasted a rotated race gate template. I pasted this at the end of a station so it probably crossed uninitialized chunks too.

log.txt.02 MBDownload

Stacktrace:

[2015-10-22 18:37:14] java.lang.NullPointerException
[2015-10-22 18:37:14] 	at obfuscated.cL.a(SourceFile:480)
[2015-10-22 18:37:14] 	at obfuscated.dd.a(SourceFile:351)
[2015-10-22 18:37:14] 	at obfuscated.dm.a(SourceFile:378)
[2015-10-22 18:37:14] 	at obfuscated.ch.a(SourceFile:320)
[2015-10-22 18:37:14] 	at obfuscated.ch.a(SourceFile:320)
[2015-10-22 18:37:14] 	at obfuscated.dd.a(SourceFile:1111)
[2015-10-22 18:37:14] 	at obfuscated.ch.a(SourceFile:320)
[2015-10-22 18:37:14] 	at obfuscated.ch.a(SourceFile:320)
[2015-10-22 18:37:14] 	at obfuscated.cP.a(SourceFile:315)
[2015-10-22 18:37:14] 	at obfuscated.ch.a(SourceFile:320)
[2015-10-22 18:37:14] 	at obfuscated.cn.a(SourceFile:228)
[2015-10-22 18:37:14] 	at obfuscated.C.updateStateInput(SourceFile:1322)
[2015-10-22 18:37:14] 	at obfuscated.asT.a(SourceFile:1162)
[2015-10-22 18:37:14] 	at obfuscated.C.h(SourceFile:2767)
[2015-10-22 18:37:14] 	at obfuscated.MT.run(SourceFile:92)
[2015-10-22 18:37:14] 	at java.lang.Thread.run(Unknown Source)

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.19457 (Dev)
Category
Control Block System: Functional
First occurrence (version)
0.19444 (Dev)
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake updated the task description. (Show Details)Oct 22 2015, 4:47 PM
lancake shifted this object from the S1 Public space to the S3 Starmade space.
lancake changed the visibility from "Custom Policy" to "Starmade (Project)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
lancake changed Category from none/unspecified to Control Block System: Functional.
lancake edited Serverconfig (server.cfg). (Show Details)
lancake edited Clientconfig (settings.cfg). (Show Details)
lancake added a subscriber: lancake.
lancake created this task.
lancake raised the priority of this task from to Normal.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptOct 22 2015, 4:47 PM
lancake changed the visibility from "Starmade (Project)" to "Public (No Login Required)".Oct 22 2015, 4:48 PM
lancake set Task Type to Bug.
lancake set Affected Gamemode(s) to none/unspecified.
lancake set First occurrence (version) to 0.19444 (Dev).
lancake set Reproducible to uncertain.
lancake set Last tested (version) to 0.19444 (Dev).
lancake set OS-Specific to No.
lancake set Hardware-Specific to No.
lancake set Video Card Vendor to uncertain.
thakyZ moved this task from Open / Validated to Feedback on the Issue Navigation board.Oct 28 2015, 9:30 PM
thakyZ claimed this task.

@lancake can you please attach the race gate template?

lancake added a comment.Oct 29 2015, 3:31 PM

Reproduced it again but this time with activation gates.

It seems that pasting it in an un-initialized chunk is causing it. Probably anything causes it.

lancake moved this task from Feedback to Open / Validated on the Issue Navigation board.Oct 29 2015, 3:34 PM
lancake renamed this task from Race gate null pointer to Null pointer when pasting linked modules in un-initialized chunks..
lancake added a subscriber: thakyZ.Oct 29 2015, 3:45 PM
lancake claimed this task.

-Confirmed-

Pasting templates that contain linked modules can cause a null pointer when it is pasted in a chunk that has not been initialized yet. At least that's what I think but it seems to be reproducible.

How to reproduce:

  1. Go in creative mode, make a new station block and place a build block on it
  2. Enter the build block and paste this template
    Modules.smtpl367 BDownload
    multiple times in a certain direction
  3. at around 72 blocks+ in length, it should crash you.
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.Oct 29 2015, 3:46 PM
lancake changed Reproducible from uncertain to Yes.
lancake changed Last tested (version) from 0.19444 (Dev) to 0.19452 (Dev).
lancake moved this task from Open / Validated to Confirmed on the Issue Navigation board.
lancake changed the task status from Open to In Queue (Game).
Restricted Application edited projects, added Game Development, Starmade; removed Issue Navigation. · View Herald TranscriptOct 29 2015, 3:46 PM
schema added a commit: Restricted Diffusion Commit.Oct 30 2015, 12:05 PM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptOct 30 2015, 12:05 PM
lancake closed this task as Closed.EditedOct 30 2015, 7:53 PM

-QA Testing-

Fix confirmed.
Gives you an error warning now if that's the case ("you should wait till it's initialized"). It doesn't link those specific modules that are over the line but that's ok.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptOct 30 2015, 7:53 PM
lancake changed Last tested (version) from 0.19452 (Dev) to 0.19457 (Dev).Oct 30 2015, 7:53 PM
Restricted Application added a project: CBS: Functional. · View Herald TranscriptMar 10 2017, 6:24 PM