Page MenuHomeSchine - Phabricator

Starmade | game config: computer limitation does not work and acts like group limitation
Closed, FinishedPublic

Description

As the title says: Having this in the gameconfig does not have any affect:

		<!-- JumpDrive -->
		<Controller>
			<ID>544</ID> 
			<ComputerMax>1</ComputerMax> 
		</Controller>

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.19533 (Dev)
Category
Blockconfig
First occurrence (version)
0.19431
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

Tarusol updated the task description. (Show Details)Sep 8 2015, 9:00 PM
Tarusol changed Category from none/unspecified to Blockconfig.
Tarusol changed Affected Gamemode(s) from none/unspecified to Single and Multi.
Tarusol set First occurrence (version) to 0.19431.
Tarusol changed Reproducible from uncertain to Yes.
Tarusol set Last tested (version) to 0.19431.
Tarusol edited Serverconfig (server.cfg). (Show Details)
Tarusol edited Clientconfig (settings.cfg). (Show Details)
Tarusol added a subscriber: Tarusol.
Tarusol created this task.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptSep 8 2015, 9:00 PM
lancake claimed this task.Sep 9 2015, 10:46 AM
lancake shifted this object from the S1 Public space to the S3 Starmade space.Sep 9 2015, 12:23 PM
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
lancake set Task Type to Bug.
lancake set OS-Specific to No.
lancake set Hardware-Specific to No.
lancake set Video Card Vendor to uncertain.
lancake renamed this task from Game Config: Jump Computer Limitation does not work to game config: computer limitation does not work and acts like group limitation.
lancake triaged this task as Low priority.
lancake added a comment.EditedSep 9 2015, 12:26 PM

-Validated-
Computermax doesn't work, when you use it it will act like a groupmax.

For a controller like a jump drive, it will give you a warning but it will still charge (It's not really a weapon/tool so I assume that's intended, this one doesn't get a benefit from multiple groups anyway).

-Confirmed-

How to reproduce:

  1. set computer max for a random controller you want to test out. Set the value to something small like 3
  2. try out 4 or more computers on the same entity, still works.
  3. try out 4 or more groups on 1 controller, doesn't work, you get a warning that you crossed the group max limit. (it's fine with 3 or less groups in this case).
NOTE: In case you have groupmax and computermax enabled for the same ID, it will use the last one as the real groupmax value.
lancake changed the task status from Open to In Queue (Game).
Restricted Application edited projects, added Game Development, Starmade; removed Issue Navigation. · View Herald TranscriptSep 9 2015, 12:30 PM

So what is expected to happen? Should it not let you place more than the computer max?

AndyP raised the priority of this task from Low to Release Blocker.
Restricted Application added a subscriber: AndyP. · View Herald TranscriptSep 14 2015, 12:15 PM
AndyP lowered the priority of this task from Release Blocker to Urgent.Sep 14 2015, 12:17 PM
schema added a commit: Restricted Diffusion Commit.Oct 29 2015, 12:49 PM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptOct 29 2015, 12:49 PM
lancake changed Last tested (version) from 0.19431 to 0.19533 (Dev).Dec 18 2015, 5:38 PM
lancake closed this task as Closed.
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptDec 18 2015, 5:38 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript

-QA Testing-

Fix confirmed.

Restricted Application added a project: Blockconfig. · View Herald TranscriptMar 10 2017, 6:26 PM