Page MenuHomeSchine - Phabricator
Create Task
Maniphest T61

Starmade | Setting sell price to 0 of a block can cause crash
Closed, FinishedPublic
Actions

Description

These crash issues are caused by the ability to set the sell(/buy?) price to 0 of any randomly chosen item. If you use the "put quantity in as owner" or the "sell amount" button for that item and enter any number that's higher than 0, it will crash you.

[2016-05-31 12:48:23] java.lang.ArithmeticException: / by zero
[2016-05-31 12:48:23] 	at obfuscated.RK.a(SourceFile:147)
[2016-05-31 12:48:23] 	at obfuscated.fh.check(SourceFile:57)
[2016-05-31 12:48:23] 	at obfuscated.aqN.a(SourceFile:328)
[2016-05-31 12:48:23] 	at obfuscated.aqN.d(SourceFile:495)
[2016-05-31 12:48:23] 	at obfuscated.ca.handleKeyEvent(SourceFile:88)
[2016-05-31 12:48:23] 	at obfuscated.aEd.a(SourceFile:300)
[2016-05-31 12:48:23] 	at obfuscated.de.d(SourceFile:121)
[2016-05-31 12:48:23] 	at obfuscated.cx.d(SourceFile:303)
[2016-05-31 12:48:23] 	at obfuscated.cD.d(SourceFile:147)
[2016-05-31 12:48:23] 	at obfuscated.D.k(SourceFile:3436)
[2016-05-31 12:48:23] 	at obfuscated.aEd.a(SourceFile:103)
[2016-05-31 12:48:23] 	at obfuscated.D.updateStateInput(SourceFile:1465)
[2016-05-31 12:48:23] 	at obfuscated.avm.a(SourceFile:633)
[2016-05-31 12:48:23] 	at obfuscated.avr.b(SourceFile:598)
[2016-05-31 12:48:23] 	at obfuscated.P.e(SourceFile:895)
[2016-05-31 12:48:23] 	at org.schema.game.common.Starter.startMainMenu(SourceFile:1221)
[2016-05-31 12:48:23] 	at org.schema.game.common.Starter.main(SourceFile:1023)

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
none/unspecified
Reproducible
Yes
Last tested (version)
0.198.142
Category
Ingame GUI/HUD
First occurrence (version)
0.19226
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. set sell price of a block to "0 amount of activation module"
  2. use "put in as owner" or "sell amount" and enter a number bigger than 0
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake updated the task description. (Show Details)Jun 8 2015, 8:14 AM
lancake added a project: Issue Navigation.
lancake changed Category from none/unspecified to Ingame GUI/HUD.
lancake set First occurrence (version) to 0.19226.
lancake changed Reproducible from uncertain to Yes.
lancake set Last tested (version) to 0.19247 (Dev).
lancake edited a custom field.
lancake edited Serverconfig (server.cfg). (Show Details)
lancake edited Clientconfig (settings.cfg). (Show Details)
lancake added a subscriber: lancake.
lancake created this task.
lancake raised the priority of this task from to Low.
lancake changed the task status from Open to In Queue (Game).Jun 8 2015, 2:56 PM
Restricted Application edited projects, added Game Development, Starmade; removed Issue Navigation. · View Herald TranscriptJun 8 2015, 2:56 PM
AndyP shifted this object from the S1 Public space to the S3 Starmade space.Aug 11 2015, 10:24 PM
AndyP changed the edit policy from "Starmade (Project)" to "All Users".
AndyP set Task Type to Bug.
AndyP set Affected Gamemode(s) to none/unspecified.
AndyP set OS-Specific to No.
AndyP set Hardware-Specific to No.
AndyP set Video Card Vendor to uncertain.
lancake claimed this task.Sep 21 2015, 10:48 AM
lancake added a comment.May 31 2016, 10:49 AM

Still happens but seems to happen with a more specific situation. Stacktrace is different too, updating description.

lancake updated the task description. (Show Details)May 31 2016, 10:53 AM
lancake edited Steps to reproduce. (Show Details)
lancake renamed this task from Setting sell/buy price to 0 of a block can cause crash to Setting sell price to 0 of a block can cause crash.
schema changed the task status from In Queue (Game) to Resolved.Jun 4 2016, 6:27 PM
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJun 4 2016, 6:27 PM
lancake closed this task as Closed.Jun 4 2016, 10:38 PM

-QA Testing-

Fix confirmed.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJun 4 2016, 10:38 PM
lancake changed Last tested (version) from 0.19247 (Dev) to 0.198.142.Jun 4 2016, 10:39 PM
Restricted Application added a project: GUI/HUD. · View Herald TranscriptMar 10 2017, 5:50 PM