Page MenuHomeSchine - Phabricator
Create Task
Maniphest T549

Registry | Usernames not sanity checked
Confirmed task for development, HighPublic
Actions

Description

The usernames given on signup are not sanity checked.

They allow "two-letter" names, and also way too long names like:

Login by mail, works from registry side.
However those names cause issues on starmadedock.net (as the forum does not seem to accept "too short" or "too long"names.

Also the game has issues authenticating when things like @ get into the name.

Details

Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

AndyP updated the task description. (Show Details)Aug 22 2015, 10:50 AM
AndyP shifted this object from the S1 Public space to the S7 Registry space.
AndyP changed the visibility from "Custom Policy" to "Public (No Login Required)".
AndyP changed the edit policy from "Task Author" to "All Users".
AndyP edited Serverconfig (server.cfg). (Show Details)
AndyP edited Clientconfig (settings.cfg). (Show Details)
AndyP added a subscriber: AndyP.
AndyP created this task.
AndyP raised the priority of this task from to High.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptAug 22 2015, 10:50 AM
AndyP changed the task status from Open to In Queue (Registry).Aug 22 2015, 10:51 AM

-Confirmed-

Currently we should aim toward making the limits "SMD-compatible".

Restricted Application edited projects, added Starmade, Registry Development; removed Issue Navigation. · View Herald TranscriptAug 22 2015, 10:51 AM
lancake added a subscriber: lancake.Sep 21 2015, 10:59 AM
lancake assigned this task to AndyP.
calani added a subscriber: calani.Apr 29 2016, 3:13 AM

Let's go with "increase username sanity" instead and validate them across StarMade, the Registry, and StarMadeDock for consistency.

ex: If there's a username that the game can't handle correctly (e.g. containing Chinese or Emoji), that's a problem.

calani added a comment.Apr 29 2016, 3:15 AM

Small update to this: null usernames are no longer accepted.

AndyP changed the task status from In Queue (Registry) to In Queue.Mar 10 2017, 5:13 PM
AndyP mentioned this in Unknown Object (Maniphest Task).Jan 8 2018, 8:04 PM