Page MenuHomeSchine - Phabricator
Create Task
Maniphest T423

Starmade | saving blueprint with docks causes StackOverflowError
Closed, FinishedPublic
Actions

Description

The new blueprint classification system that has 4 types of points does not work properly for blueprints that have docks.
It's fine for the ones without docks. (thanks for /destroy_entity_only_dock)

[2015-07-20 18:50:31] Exception in thread "ServerController" 
[2015-07-20 18:50:31] java.lang.StackOverflowError
[2015-07-20 18:50:31] 	at java.util.HashMap.hash(Unknown Source)
[2015-07-20 18:50:31] 	at java.util.HashMap.get(Unknown Source)
[2015-07-20 18:50:31] 	at org.luaj.vm2.lib.jse.JavaClass.getField(Unknown Source)
[2015-07-20 18:50:31] 	at org.luaj.vm2.lib.jse.JavaInstance.get(Unknown Source)
[2015-07-20 18:50:31] 	at org.luaj.vm2.LuaClosure.execute(Unknown Source)
[2015-07-20 18:50:31] 	at org.luaj.vm2.LuaClosure.call(Unknown Source)
[2015-07-20 18:50:31] 	at org.luaj.vm2.LuaClosure.execute(Unknown Source)
[2015-07-20 18:50:31] 	at org.luaj.vm2.LuaClosure.call(Unknown Source)
[2015-07-20 18:50:31] 	at org.schema.game.common.controller.elements.ModuleStatistics.calcRec(SourceFile:116)
[2015-07-20 18:50:31] 	at org.schema.game.common.controller.elements.ModuleStatistics.calcRec(SourceFile:122)
[2015-07-20 18:50:31] 	at org.schema.game.common.controller.elements.ModuleStatistics.calcRec(SourceFile:122)
[2015-07-20 18:50:31] 	at org.schema.game.common.controller.elements.ModuleStatistics.calcRec(SourceFile:122)
[2015-07-20 18:50:31] 	at org.schema.game.common.controller.elements.ModuleStatistics.calcRec(SourceFile:122)
[2015-07-20 18:50:31] 	at org.schema.game.common.controller.elements.ModuleStatistics.calcRec(SourceFile:122)
[repeats]

Full logs:

log.txt.0680 KBDownload

How to reproduce:

  1. make a ship, save it and see that it works
  2. make a dock on that ship and dock something else to it
  3. save the ship again and notice the server thread

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.19333
Category
Engine
First occurrence (version)
0.19331
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake updated the task description. (Show Details)Jul 20 2015, 4:56 PM
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
lancake changed Category from none/unspecified to Engine.
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.
lancake set First occurrence (version) to 0.19331 (Dev).
lancake changed Reproducible from uncertain to Yes.
lancake set Last tested (version) to 0.19331 (Dev).
lancake edited Serverconfig (server.cfg). (Show Details)
lancake edited Clientconfig (settings.cfg). (Show Details)
lancake added a subscriber: lancake.
lancake created this task.
lancake raised the priority of this task from to Urgent.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptJul 20 2015, 4:56 PM
Restricted Application added a subscriber: AndyP. · View Herald Transcript
lancake set Task Type to Bug.Jul 20 2015, 4:57 PM
lancake set OS-Specific to No.
lancake set Hardware-Specific to No.
lancake set Video Card Vendor to uncertain.
lancake changed the task status from Open to In Queue (Game).
Restricted Application edited projects, added Game Development, Starmade; removed Issue Navigation. · View Herald TranscriptJul 20 2015, 4:57 PM
AndyP moved this task from Backlog / Unclassed to schema on the Game Development board.Jul 20 2015, 4:58 PM
AndyP moved this task from Unclassed to Issue affecting current dev-build on the Starmade board.
AndyP changed the task status from In Queue (Game) to Resolved.
AndyP claimed this task.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJul 20 2015, 4:59 PM
AndyP added a comment.Jul 20 2015, 4:59 PM

Fixed in next dev

AndyP moved this task from Backlog / Unclassed to Confirmed fix on the Quality Assurance board.Jul 21 2015, 4:15 PM
AndyP closed this task as Closed.

fix confirmed

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJul 21 2015, 4:15 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
AndyP changed First occurrence (version) from 0.19331 (Dev) to 0.19333.Jul 21 2015, 4:16 PM
AndyP changed Last tested (version) from 0.19331 (Dev) to 0.19333.
AndyP changed First occurrence (version) from 0.19333 to 0.19331.
AndyP removed AndyP as the assignee of this task.Aug 4 2015, 7:31 PM
AndyP shifted this object from the S1 Public space to the S3 Starmade space.Aug 11 2015, 11:33 PM
AndyP changed the edit policy from "Starmade (Project)" to "All Users".
Restricted Application added a project: Engine. · View Herald TranscriptMar 10 2017, 6:30 PM