Page MenuHomeSchine - Phabricator
Create Task
Maniphest T391

Starmade | Client logs show confidential information
Closed, FinishedPublic
Actions

Description

#1
Client logs can be used to find information about ship locations, last time i checked you could also see a big part of chat (pm's/faction) but now with the reworked one I'm not too sure about it.

#2
could extract

[2015-07-06 18:50:11] [CLIENT] received playerstate sector change: 9353((-28, 7, -58)) -> 9458 ((-29, 7, -58))
[2015-07-06 18:50:11] [CLIENT] RECEIVED NEW SECTOR FOR PlayerCharacter[(ENTITY_PLAYERCHARACTER_Mordicon)(9590)]: 9353 -> 9458
[2015-07-06 18:50:11] [CLIENT] SCHEDULING SECTOR CHANGE FOR PlayerCharacter[(ENTITY_PLAYERCHARACTER_Mordicon)(9590)] FROM 9353 TO 9458

and id didnt know where he was before that

also things like

[2015-07-06 18:49:09] [CLIENT] Object: PlayerCharacter[(ENTITY_PLAYERCHARACTER_Mordicon)(9590)] Set NT hidden true -> false

get spammed in logs constantly

and faction information otherwise not access able in game afaik is also shown

[2015-07-06 18:46:12] [FACTION] Added to members ELstringer perm(4) of Faction [id=10085, name=TEC Network, description=a faction, size: 1; FP: -6472] on Client(27)

like this

none of these should get logged at the client side i think

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Multiplayer
Reproducible
Yes
Last tested (version)
0.19354 (Dev)
Category
Engine
First occurrence (version)
0,14
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

SmilingDemon updated the task description. (Show Details)Jul 6 2015, 5:12 PM
SmilingDemon added projects: Starmade, Issue Navigation.
SmilingDemon shifted this object from the S1 Public space to the Restricted Space space.
SmilingDemon changed the visibility from "Custom Policy" to "Starmade (Project)".
SmilingDemon changed the edit policy from "Task Author" to "Starmade (Project)".
SmilingDemon changed Category from none/unspecified to Engine.
SmilingDemon changed Affected Gamemode(s) from none/unspecified to Multiplayer.
SmilingDemon set First occurrence (version) to 0,14.
SmilingDemon changed Reproducible from uncertain to Yes.
SmilingDemon set Last tested (version) to 0.19308 (Dev).
SmilingDemon edited a custom field.
SmilingDemon edited Serverconfig (server.cfg). (Show Details)
SmilingDemon edited Clientconfig (settings.cfg). (Show Details)
SmilingDemon added a subscriber: SmilingDemon.
SmilingDemon created this task.
SmilingDemon changed the task status from Open to In Queue (Game).
SmilingDemon raised the priority of this task from to Normal.
Restricted Application edited projects, added Game Development; removed Issue Navigation. · View Herald TranscriptJul 6 2015, 5:12 PM
AndyP shifted this object from the Restricted Space space to the S1 Public space.Jul 11 2015, 12:42 PM
AndyP set Task Type to Bug.
AndyP set OS-Specific to No.
AndyP set Hardware-Specific to No.
AndyP set Video Card Vendor to uncertain.
AndyP added a subscriber: AndyP.Jul 12 2015, 9:19 AM
AndyP assigned this task to SmilingDemon.
schema added a commit: Restricted Diffusion Commit.Jul 25 2015, 5:27 PM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
schema added a subscriber: schema.Jul 25 2015, 5:27 PM

fixed for >= 0.19345

Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJul 25 2015, 5:27 PM
lancake added a subscriber: lancake.Jul 29 2015, 8:06 PM
lancake changed the task status from Resolved to In Queue (Game).

[FACTION] Added to members Vandooz perm(0) of Faction [id=10047, name=The Cafe, description=Buncha poopers, size: 3; FP: -3028]

It shows the faction points of a faction, this should be hidden (at least for client logs).

Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptJul 29 2015, 8:06 PM
lancake changed Last tested (version) from 0.19308 (Dev) to 0.19350 (Dev).Jul 29 2015, 8:06 PM
schema added a commit: Restricted Diffusion Commit.Jul 29 2015, 11:00 PM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJul 29 2015, 11:00 PM
SmilingDemon changed Last tested (version) from 0.19350 (Dev) to 0.19354 (Dev).Jul 30 2015, 7:12 PM
SmilingDemon closed this task as Closed.

Cant find any of that data any longer in a logfile
looks fixed to me

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJul 30 2015, 7:14 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
AndyP removed SmilingDemon as the assignee of this task.Aug 4 2015, 7:31 PM
AndyP shifted this object from the S1 Public space to the Restricted Space space.Aug 11 2015, 11:27 PM
AndyP changed the visibility from "Starmade (Project)" to "Public (No Login Required)".
AndyP changed the edit policy from "Starmade (Project)" to "All Users".
AndyP shifted this object from the Restricted Space space to the S3 Starmade space.Sep 7 2015, 9:07 PM

Publish -> Fixed in release

lancake mentioned this in Unknown Object (Maniphest Task).Jul 25 2016, 8:08 PM
Restricted Application added a project: Engine. · View Herald TranscriptMar 10 2017, 6:31 PM