Page MenuHomeSchine - Phabricator

Starmade | faction inheriting mechanics override faction ID's
Closed, FinishedPublic

Description

faction inheriting is opening up a few potential exploits:

  1. Docking a factioned ship to a neutral station will make your factioned ship inherit that ID, which is 0 and basically unfactions your ship and all its docks.

this would be possible for everything if you could dock a factioned ship to another faction's base without having to use permission modules.

  1. resetting (or destroying the faction module) faction signature of a ship/station will reset the faction signature of all other docked entities, even if some of them have their own faction module with entered signature. Undocking any entity with a faction module also resets their signature (it only stays if you manually entered the signature for that undocked entity, if it has a faction module it should keep the inherited faction ID even when it is undocked.

How to reproduce issue 1:

  1. use this blueprint: it has a station with 1 docked ship with a 2 chains
  2. enter faction signature for the ship, notice how the signature doesn't change since the station it is docked to is neutral (ID 0)
  3. undock the ship and it will appear factioned, redock it and the faction ID will be 0 again and anyone can edit it

How to reproduce issue 2:

  1. use the same blueprint
  2. enter faction signature for the mothership
  3. enter faction signature for the station
  4. dock the mothership to the station if it isn't already
  5. reset faction signature of station
  6. you'll see both the mothership AND its docks reset their faction signature, in this case the mothership should have kept its faction signature, and so would the 2 other chained entities (they inherit from the mothership, not the station!)

Pretty sure this is already in release, it can be used to quickly claim any docked entities if the station faction's module has been found and (destroyed first) replaced by your own.

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.193 (Dev)
Category
Engine
First occurrence (version)
0.193 (Dev)
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake updated the task description. (Show Details)Jul 2 2015, 11:07 AM
lancake shifted this object from the S1 Public space to the Restricted Space space.
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
lancake changed Category from none/unspecified to Engine.
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.
lancake set First occurrence (version) to 0.193 (Dev).
lancake changed Reproducible from uncertain to Yes.
lancake set Last tested (version) to 0.193 (Dev).
lancake edited a custom field.
lancake edited Serverconfig (server.cfg). (Show Details)
lancake edited Clientconfig (settings.cfg). (Show Details)
lancake added a subscriber: lancake.
lancake created this task.
lancake raised the priority of this task from to Release Blocker.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptJul 2 2015, 11:07 AM
lancake updated the task description. (Show Details)Jul 2 2015, 11:11 AM
lancake set Task Type to Bug.
lancake set OS-Specific to No.
lancake set Hardware-Specific to No.
lancake set Video Card Vendor to uncertain.
lancake changed the task status from Open to In Queue (Game).
Restricted Application edited projects, added Game Development, Starmade; removed Issue Navigation. · View Herald TranscriptJul 2 2015, 11:11 AM
schema added a subscriber: schema.Jul 2 2015, 8:42 PM
schema changed the task status from In Queue (Game) to Resolved.

neutral or non existing faction will no longer change the docked faction id.

Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJul 2 2015, 8:42 PM
lancake changed the task status from Resolved to In Queue (Game).Jul 3 2015, 11:16 AM

Issue 1 is partially fixed:

  • The docked entity to a neutral station keeps its faction signature, but its own docks don't inherit the faction signature from their mothership anymore.

Issue 2 suffers from the same issue + something I did not mention originally:

  • Resetting signature applies for all docks except for the entities who had their signature entered manually
  • Entering a new faction signature for the station overrides all signatures of the docked entities, even the ones who had their signature entered manually
Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptJul 3 2015, 11:16 AM
AndyP shifted this object from the Restricted Space space to the S1 Public space.Jul 3 2015, 6:07 PM
AndyP changed the visibility from "Public (No Login Required)" to "Starmade (Project)".
lancake updated the task description. (Show Details)Jul 7 2015, 9:14 PM
schema added a commit: Restricted Diffusion Commit.Jul 10 2015, 12:18 PM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJul 10 2015, 12:18 PM
lancake closed this task as Closed.Jul 14 2015, 5:34 PM
lancake claimed this task.

all mentioned issues fixed

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJul 14 2015, 5:34 PM
AndyP removed lancake as the assignee of this task.Aug 4 2015, 7:31 PM
AndyP shifted this object from the S1 Public space to the Restricted Space space.Aug 11 2015, 11:26 PM
AndyP changed the visibility from "Starmade (Project)" to "Public (No Login Required)".
AndyP changed the edit policy from "Starmade (Project)" to "All Users".
AndyP shifted this object from the Restricted Space space to the S3 Starmade space.Sep 7 2015, 9:07 PM
AndyP added a subscriber: AndyP.

Publish -> Fixed in release

Restricted Application removed a subscriber: AndyP. · View Herald TranscriptSep 7 2015, 9:07 PM
Restricted Application added a project: Engine. · View Herald TranscriptMar 10 2017, 6:31 PM