Page MenuHomeSchine - Phabricator
Create Task
Maniphest T36

Starmade | Too long names causes database issues
Closed, FinishedPublic
Actions

Description

the UID length (127 or 128) was doubled and chain docks don't have huge names anymore.

It's still possible to spawn a name with more characters in it than the database UID allows. The dialogs to spawn blueprints, ship cores and stations only allow X chars max and that works.

However, you are still allowed to admin load it with more than 128 characters in the name, this should also be capped.

Maybe capping all dialogues/admin commands to 90 characters or so would be good? gives you enough spare.

Then there's the issue of generated content, stations could have a longer than 128 length name so maybe letting the game just cut off the part that crosses it would be good enough?

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.199.535
Category
Engine
First occurrence (version)
0.1862
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Related Objects

Event Timeline

lancake updated the task description. (Show Details)Jun 5 2015, 4:09 PM
lancake added a project: Issue Navigation.
lancake changed Category from none/unspecified to Engine.
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.
lancake set First occurrence (version) to 0.1862.
lancake changed Reproducible from uncertain to Yes.
lancake set Last tested (version) to 0.19247.
lancake edited a custom field.
lancake edited Serverconfig (server.cfg). (Show Details)
lancake edited Clientconfig (settings.cfg). (Show Details)
lancake set Task Type to Bug.
lancake set OS-Specific to No.
lancake set Hardware-Specific to No.
lancake set Video Card Vendor to uncertain.
lancake added a subscriber: lancake.
lancake created this task.
lancake renamed this task from Game allows you to spawn entities with longer names than the UID supports to Too long names causes database issues.
lancake raised the priority of this task from to Low.
lancake changed the task status from Open to In Queue (Game).Jun 5 2015, 4:30 PM
Restricted Application edited projects, added Game Development, Starmade; removed Issue Navigation. · View Herald TranscriptJun 5 2015, 4:30 PM
AndyP shifted this object from the S1 Public space to the S3 Starmade space.Aug 11 2015, 8:59 PM
AndyP changed the edit policy from "Starmade (Project)" to "All Users".
lancake claimed this task.Sep 21 2015, 10:48 AM
schema added a subscriber: schema.Mar 9 2016, 7:21 PM
schema changed the task status from In Queue (Game) to Resolved.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptMar 9 2016, 7:21 PM
schema added a comment.Mar 12 2016, 4:36 PM

admin save is limited to 48 letters

Restricted Application added a project: Engine. · View Herald TranscriptMar 10 2017, 5:50 PM
lancake moved this task from Backlog / Unclassed to Confirmed fix on the Quality Assurance board.Jun 16 2017, 1:36 PM

-QA Testing-

Fix confirmed.

lancake changed Last tested (version) from 0.19247 to 0.199.535.Jun 16 2017, 1:36 PM
lancake closed this task as Closed.Jun 16 2017, 8:12 PM
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJun 16 2017, 8:12 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript