Page MenuHomeSchine - Phabricator

Starmade | Phantom weapon and effect computers
Closed, FinishedPublic

Description

A computer, that is linked to another (as support/effect) and that has linked module can cause a ghost link.

When you remove this computer by right clicking it will not completely "disappear". The shipcore will have a ghost link on that position the computer was on.

Putting a new but different computer on that exact location, linking it as support/effect will create a second computer in the weapons tab.

Using a weapon that has a computer on one of those ghost links can cause a nullpointer when used.

[2014-12-21 13:24:45] java.lang.NullPointerException
[2014-12-21 13:24:45]     at obfuscated.sR.a(SourceFile:477)
[2014-12-21 13:24:45]     at obfuscated.kN.a(SourceFile:619)
[2014-12-21 13:24:45]     at org.schema.game.common.controller.elements.weapon.WeaponElementManager.handle(SourceFile:131)
[2014-12-21 13:24:45]     at org.schema.game.common.controller.elements.ManagerContainer.handle(SourceFile:574)
[2014-12-21 13:24:45]     at org.schema.game.common.controller.elements.ShipManagerContainer.handle(SourceFile:414)
[2014-12-21 13:24:45]     at obfuscated.wL.a(SourceFile:515)
[2014-12-21 13:24:45]     at org.schema.game.common.data.player.ControllerState.handleClientControllerStateFor(SourceFile:148)
[2014-12-21 13:24:45]     at org.schema.game.common.data.player.ControllerState.update(SourceFile:586)
[2014-12-21 13:24:45]     at org.schema.game.common.data.player.PlayerState.updateLocal(SourceFile:4287)
[2014-12-21 13:24:45]     at obfuscated.C.a(SourceFile:3157)
[2014-12-21 13:24:45]     at obfuscated.C.update(SourceFile:2758)
[2014-12-21 13:24:45]     at obfuscated.Yq.a(SourceFile:1160)
[2014-12-21 13:24:45]     at obfuscated.Yq.a(SourceFile:1152)
[2014-12-21 13:24:45]     at obfuscated.C.j(SourceFile:2239)
[2014-12-21 13:24:45]     at obfuscated.vi.run(SourceFile:76)
[2014-12-21 13:24:45]     at java.lang.Thread.run(Unknown Source)
[2014-12-21 13:24:45] [GLFRAME] THROWN: class java.lang.RuntimeException Now Printing StackTrace
[2014-12-21 13:24:45] java.lang.RuntimeException: java.lang.NullPointerException
[2014-12-21 13:24:45]     at org.schema.game.common.data.player.PlayerState.updateLocal(SourceFile:4298)
[2014-12-21 13:24:45]     at obfuscated.C.a(SourceFile:3157)
[2014-12-21 13:24:45]     at obfuscated.C.update(SourceFile:2758)
[2014-12-21 13:24:45]     at obfuscated.Yq.a(SourceFile:1160)
[2014-12-21 13:24:45]     at obfuscated.Yq.a(SourceFile:1152)
[2014-12-21 13:24:45]     at obfuscated.C.j(SourceFile:2239)
[2014-12-21 13:24:45]     at obfuscated.vi.run(SourceFile:76)
[2014-12-21 13:24:45]     at java.lang.Thread.run(Unknown Source)

How to reproduce:

  1. Get 2 cannon computers and 2 cannon barrels (it doesn't really matter)
  2. Place 1 cannon computer and 1 cannon barrel down, link them together
  3. Do the same but for your 2nd computer and barrel
  4. Link cannon computer 1 to cannon computer 2, or do it via the weapons menu
    1. remove the support/slaved computer
    2. press C on the ship core and you'll notice a ghost link on the computer you just removed
    3. put any other computer in that spot and try to use that as a weapon, you should get nullpointers.

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.19338 (Dev)
Category
Control Block System: Weapons
First occurrence (version)
0.151
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake updated the task description. (Show Details)Jun 5 2015, 3:24 PM
lancake added a project: Issue Navigation.
lancake changed Category from none/unspecified to Control Block System: Weapons.
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.
lancake set First occurrence (version) to 0.151.
lancake changed Reproducible from uncertain to Yes.
lancake set Last tested (version) to 0.19247.
lancake edited a custom field.
lancake edited Serverconfig (server.cfg). (Show Details)
lancake edited Clientconfig (settings.cfg). (Show Details)
lancake added a subscriber: lancake.
lancake created this task.
lancake raised the priority of this task from to High.
lancake changed the task status from Open to In Queue (Game).Jun 5 2015, 4:30 PM
Restricted Application edited projects, added Game Development, Starmade; removed Issue Navigation. · View Herald TranscriptJun 5 2015, 4:30 PM
schema added a subscriber: schema.Jul 23 2015, 7:05 PM
schema changed the task status from In Queue (Game) to Resolved.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJul 23 2015, 7:05 PM
Restricted Application added a subscriber: AndyP. · View Herald Transcript
lancake closed this task as Closed.Jul 24 2015, 6:08 PM
lancake claimed this task.

Can't reproduce anymore, fix confirmed.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJul 24 2015, 6:08 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
lancake set Task Type to Bug.Jul 24 2015, 6:08 PM
lancake changed Last tested (version) from 0.19247 to 0.19338 (Dev).
lancake set OS-Specific to No.
lancake set Hardware-Specific to No.
lancake set Video Card Vendor to uncertain.
AndyP removed lancake as the assignee of this task.Aug 4 2015, 7:31 PM
AndyP shifted this object from the S1 Public space to the S3 Starmade space.Aug 11 2015, 8:59 PM
AndyP changed the edit policy from "Starmade (Project)" to "All Users".
lancake mentioned this in Unknown Object (Maniphest Task).Jun 24 2016, 4:13 PM
Restricted Application added a project: CBS: Weapons. · View Herald TranscriptMar 10 2017, 5:50 PM