Page MenuHomeSchine - Phabricator

Starmade | Ruleset remove buttons need confirmation
Resolved, needs quality check / confirm fix, Pre-Release Quality AssurancePublic

Description

  • Remove ruleset
  • Remove rule
  • Remove condition

Not all of these need a confirmation window before actually being removed, but at least "Ruleset" and "Rule" need it.

Best way to handle this would be to only ask for confirmation if the rule or ruleset contains something. If it is empty, nothing of value is lost anyway.
For removing a condition, you could do something similar where only a confirmation is shown when any value is different from the default setting.

Could also get rid of those buttons and put a "X" icon on reach row item of a list. Should be small and out of the way enough to not require any confirmation.

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.201.313
Category
Ingame GUI/HUD
First occurrence (version)
0.201.3xx
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. Make a complicated rule
  2. Accidentally click the "Remove Rule" button
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake created this task.Dec 1 2018, 4:53 PM
Restricted Application added a project: GUI/HUD. · View Herald TranscriptDec 1 2018, 4:53 PM
schema added a commit: Restricted Diffusion Commit.Dec 2 2018, 12:19 PM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptDec 2 2018, 12:19 PM
Restricted Application added a subscriber: AndyP. · View Herald Transcript
AndyP moved this task from Backlog / Unclassed to Alpha on the GUI/HUD board.Jan 22 2019, 9:25 AM