Page MenuHomeSchine - Phabricator
Create Task
Maniphest T310

Starmade | Network data too large: priceUpdateBuffer, controllerKeyNameBuffer and controllerKeyBuffer
Closed, FinishedPublic
Actions

Description

These 3 pop up often enough with a considerable size.

On a popular server, which has a fairly large database it seems that periodically updating the shop prices takes a large amount of network data. I included an example where it is almost 600KB big. This should normally be a very small amount. I've seen it hit 1000KB:

statistics_1428603803828_2015-04-09_20-23-23_RECEIVED.txt17 KBDownload

The other 2 have the same thing although they appear less frequent. I've seen the keynamebuffer reach 100+KB. The network statistics file uploaded on this issue is one of the "normal" ones I see often on a popular server:

statistics_1428604876791_2015-04-09_20-41-16_RECEIVED (1).txt23 KBDownload

How to reproduce:

  1. join a server with 10+ guys on it that has a large database
  2. press F12 and look at the large spikes you have every minute or 2

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.19320
Category
Engine
First occurrence (version)
0.19174
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake updated the task description. (Show Details)Jun 25 2015, 12:36 PM
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
lancake changed Category from none/unspecified to Engine.
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.
lancake set First occurrence (version) to 0.19174.
lancake changed Reproducible from uncertain to Yes.
lancake set Last tested (version) to 0.19291 (Dev).
lancake edited a custom field.
lancake edited Serverconfig (server.cfg). (Show Details)
lancake edited Clientconfig (settings.cfg). (Show Details)
lancake added a subscriber: lancake.
lancake created this task.
lancake raised the priority of this task from to High.
Restricted Application added projects: Issue Navigation, Starmade. · View Herald TranscriptJun 25 2015, 12:36 PM
lancake set Task Type to Bug.Jun 25 2015, 12:36 PM
lancake set OS-Specific to No.
lancake set Hardware-Specific to No.
lancake set Video Card Vendor to uncertain.
lancake changed the task status from Open to In Queue (Game).
Restricted Application edited projects, added Game Development; removed Issue Navigation. · View Herald TranscriptJun 25 2015, 12:36 PM
lancake updated the task description. (Show Details)Jun 25 2015, 12:37 PM
schema added a subscriber: schema.Jul 8 2015, 4:14 AM

controllerKeyNameBuffer and controllerKeyBuffer are already fixed with the new hotbar system

schema added a commit: Restricted Diffusion Commit.Jul 8 2015, 5:49 AM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJul 8 2015, 5:49 AM
lancake closed this task as Closed.Jul 19 2015, 9:34 AM
lancake claimed this task.

Checked on a popular server, didn't see any large spikes (except for the initial loading ones and chunk requests etc) related to these 3. Fix confirmed.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJul 19 2015, 9:34 AM
lancake changed Last tested (version) from 0.19291 (Dev) to 0.19320.Jul 19 2015, 9:35 AM
AndyP removed lancake as the assignee of this task.Aug 4 2015, 7:31 PM
AndyP shifted this object from the S1 Public space to the S3 Starmade space.Aug 11 2015, 11:22 PM
AndyP changed the edit policy from "Starmade (Project)" to "All Users".
Restricted Application added a project: Engine. · View Herald TranscriptMar 10 2017, 6:32 PM