Page MenuHomeSchine - Phabricator

Starmade | effect computers are not capped at max main size
Closed, FinishedPublic

Description

You can have effects go past 100%.

It looks fine in the weapon menu.

It does act as if you have 414 effect blocks in this case. It's not a UI only issue as it does amplify damage with the said amount.


Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.201.089
Category
Control Block System: Weapons
First occurrence (version)
0.201.059
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. add more blocks to your weapon effect so that it becomes bigger than your main weapon size
  2. see the effects against shields and block damage
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake created this task.Jun 7 2018, 3:57 PM
Restricted Application added a project: CBS: Weapons. · View Herald TranscriptJun 7 2018, 3:57 PM
schema added a commit: Restricted Diffusion Commit.Jun 7 2018, 4:15 PM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJun 7 2018, 4:15 PM
Restricted Application added a subscriber: AndyP. · View Herald Transcript
33Cav added a subscriber: 33Cav.Jun 8 2018, 2:32 PM

Capping at 100% ratio doesnt allow for 100% conversion to a damage type. The numbers for primary, secondary and tertiary damage types (at 100% ratio) will thus be capped at 83%, 67% and 50% respectively.

lancake closed this task as Closed.

-QA Testing-

Fix confirmed.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJun 28 2018, 5:52 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
lancake changed Last tested (version) from 0.201.059 to 0.201.089.Jun 28 2018, 5:52 PM