Page MenuHomeSchine - Phabricator
Create Task
Maniphest T3016

Starmade | lowest missile damage prioritization doesn't work
Closed, FinishedPublic
Actions

Description

The PD turrets don't fire, and in the logs you can find this being spammed by them.

Exception: Error occured updating AI (ExcMessage: null): Current Program: org.schema.game.server.ai.program.turret.TurretProgram@899721b; state: SeachingForTurretTarget; in Ship[PD Turret boat_1528381234049rl20](11)
java.util.NoSuchElementException
	at it.unimi.dsi.fastutil.objects.ObjectRBTreeSet$SetIterator.previousEntry(ObjectRBTreeSet.java:994)
	at it.unimi.dsi.fastutil.objects.ObjectRBTreeSet$SetIterator.previous(ObjectRBTreeSet.java:989)
	at org.schema.game.common.data.missile.ServerMissileManager.getLowestDamage(ServerMissileManager.java:97)
	at org.schema.game.server.ai.program.turret.states.SeachingForTurretTarget.findMissileToTarget(SeachingForTurretTarget.java:112)
	at org.schema.game.server.ai.program.turret.states.SeachingForTurretTarget.onUpdate(SeachingForTurretTarget.java:346)
	at org.schema.schine.ai.stateMachines.FiniteStateMachine.update(FiniteStateMachine.java:173)
	at org.schema.schine.ai.stateMachines.AiEntityState.updateOnActive(AiEntityState.java:145)
	at org.schema.schine.ai.stateMachines.AIGameEntityState.updateOnActive(AIGameEntityState.java:48)
	at org.schema.game.server.ai.ShipAIEntity.updateOnActive(ShipAIEntity.java:320)
	at org.schema.schine.ai.MachineProgram.update(MachineProgram.java:119)
	at org.schema.game.common.controller.ai.AIGameConfiguration.update(AIGameConfiguration.java:225)
	at org.schema.game.common.controller.ManagedUsableSegmentController.updateLocal(ManagedUsableSegmentController.java:180)
	at org.schema.game.common.controller.Ship.updateLocal(Ship.java:534)
	at org.schema.game.server.controller.GameServerController.update(GameServerController.java:1374)
	at org.schema.schine.network.server.ServerController.run(ServerController.java:275)
	at java.lang.Thread.run(Thread.java:745)

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.201.089
Category
Control Block System: Weapons
First occurrence (version)
0.201.069
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. Set PD turret to lowest damage prioritization
  2. Fire missile

Turret does nothing, check logs for exceptions.

Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake created this task.Jun 7 2018, 3:25 PM
schema added a commit: Restricted Diffusion Commit.Jun 7 2018, 4:15 PM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJun 7 2018, 4:15 PM
Restricted Application added a subscriber: AndyP. · View Herald Transcript
lancake moved this task from Backlog / Unclassed to Confirmed fix on the Quality Assurance board.Jun 28 2018, 6:04 PM
lancake closed this task as Closed.

-QA Testing-

Fix confirmed.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJun 28 2018, 6:04 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
lancake set Last tested (version) to 0.201.089.Jun 28 2018, 6:04 PM
lancake changed Category from none/unspecified to Control Block System: Weapons.
lancake set First occurrence (version) to 0.201.069.
Restricted Application added a project: CBS: Weapons. · View Herald TranscriptJun 28 2018, 6:04 PM