Page MenuHomeSchine - Phabricator
Create Task
Maniphest T2974

Starmade | Latchon beam and acid damage beam at the same time can cause nullpointer
Resolved, needs quality check / confirm fix, Pre-Release Quality AssurancePublic
Actions

Description

If you fire a death beam at a target (asteroid in my case), and while this is happening you fire a second normal latchon beam near the area you're hitting, you should run into a nullpointer.

Client(1) LATCH ON TO null
Client(1) LATCH ON TO (39, -3, -10)[Ice]o[FRONT][inactive][127Bhp; 25 Fhp][BLOCK]
Client(1) BEAM DIED
Server(0) BEAM DIED
MOUSE EVENT MouseEvent [button=0, state=true, dx=0, dy=0, x=0, y=0, dWheel=0]
MOUSE EVENT MouseEvent [button=0, state=true, dx=0, dy=0, x=0, y=0, dWheel=0]
Server(0) LATCH ON TO (-10, -12, -35)[Dolom]o[FRONT][inactive][127Bhp; 50 Fhp][BLOCK]
Client(1) BEAM DIED
Client(1) HITTTING INVALID PIECE
Server(0) BEAM DIED
Server(0) LATCH ON TO (-10, -12, -34)[Dolom]o[FRONT][inactive][127Bhp; 50 Fhp][BLOCK]
Client(1) HITTTING INVALID PIECE
Server(0) LATCH ON TO (-10, -12, -33)[Dolom]o[FRONT][inactive][127Bhp; 50 Fhp][BLOCK]
Client(1) LATCH ON TO null
java.lang.NullPointerException
	at org.schema.game.common.data.element.beam.AbstractBeamHandler.doTicks(AbstractBeamHandler.java:502)
	at org.schema.game.common.data.element.beam.AbstractBeamHandler.updateBeam(AbstractBeamHandler.java:405)
	at org.schema.game.common.data.element.beam.AbstractBeamHandler.update(AbstractBeamHandler.java:323)
	at org.schema.game.common.controller.elements.beam.BeamCollectionManager.update(BeamCollectionManager.java:45)
	at org.schema.game.common.controller.elements.ManagerModuleCollection.update(ManagerModuleCollection.java:177)
	at org.schema.game.common.controller.elements.ManagerContainer.updateLocal(ManagerContainer.java:2414)
	at org.schema.game.common.controller.elements.ShipManagerContainer.updateLocal(ShipManagerContainer.java:707)
	at org.schema.game.common.controller.ManagedUsableSegmentController.updateLocal(ManagedUsableSegmentController.java:166)
	at org.schema.game.common.controller.Ship.updateLocal(Ship.java:441)
	at org.schema.game.client.controller.GameClientController.update(GameClientController.java:1319)
	at org.schema.schine.graphicsengine.core.GLFrame.update(GLFrame.java:805)
	at org.schema.schine.graphicsengine.core.GLFrame.doFrameAndUpdate(GLFrame.java:658)
	at org.schema.schine.graphicsengine.core.GraphicsContext.mainLoop(GraphicsContext.java:854)
	at org.schema.schine.graphicsengine.core.GraphicsContext.startUp(GraphicsContext.java:751)
	at org.schema.game.client.controller.GameMainMenuController.startGraphics(GameMainMenuController.java:1158)
	at org.schema.game.common.Starter.startMainMenu(Starter.java:1431)
	at org.schema.game.common.Starter.main(Starter.java:974)

logstarmade.0.log296 KBDownload

Probably a similar issue that explosion damage with acid damage has in T2971

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.201.004
Category
Control Block System: Weapons
First occurrence (version)
0.201.001
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. fire a beam + beam (death beam) at a target
  2. fire a latchon beam (normal beam without support) near the place where the death beam is hitting
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Related Objects

Event Timeline

lancake created this task.Apr 22 2018, 9:51 PM
Restricted Application added a project: CBS: Weapons. · View Herald TranscriptApr 22 2018, 9:51 PM
schema changed the task status from In Queue to Resolved.Apr 26 2018, 9:24 PM
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptApr 26 2018, 9:24 PM
Restricted Application added a subscriber: AndyP. · View Herald Transcript
schema added a commit: Restricted Diffusion Commit.Apr 26 2018, 9:31 PM