Page MenuHomeSchine - Phabricator

Starmade | V0.199.651 Docked entity doesnt inherit faction ownership of main ship if ownership is changed with the faction module.
Closed, FinishedPublic

Description

Spawned a ship through the blueprint owned by faction A. Get inside of it and re-set the Faction Module to Neutral. Some turrets still retain the previous ownership of Faction A. Then set the Faction Module to Faction B. Still those turrets retain Faction A ownership

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Serverside
Reproducible
uncertain
Category
Control Block System: Rails/Docking
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. Spawn a ship with faction owned through Blueprint
  2. Use the Faction Module in it to set it to Neutral
  3. Enabled Docked and Turrets Nav View.
  4. Note some of the turrets is still owned by the Previous Faction
  5. Claim it using a different Faction.
  6. Note that the turrets still havent changed their Faction signature

Event Timeline

Ellorien created this task.Jul 29 2017, 2:40 AM
Ellorien renamed this task from Docked entity doesnt inherit faction ownership of main ship if ownership is changed with the faction modules. to V0.199.651 Docked entity doesnt inherit faction ownership of main ship if ownership is changed with the faction modules..
Ellorien renamed this task from V0.199.651 Docked entity doesnt inherit faction ownership of main ship if ownership is changed with the faction modules. to V0.199.651 Docked entity doesnt inherit faction ownership of main ship if ownership is changed with the faction module..Jul 29 2017, 2:42 AM
AndyP shifted this object from the S1 Public space to the S3 Starmade space.Jul 29 2017, 6:18 AM
AndyP changed the visibility from "Custom Policy" to "Public (No Login Required)".
AndyP changed the edit policy from "Task Author" to "Starmade (Project)".
AndyP edited Serverconfig (server.cfg). (Show Details)
AndyP edited Clientconfig (settings.cfg). (Show Details)
AndyP changed Affected Gamemode(s) from none/unspecified to Serverside.
AndyP changed Category from none/unspecified to Control Block System: Rails/Docking.
AndyP claimed this task.
AndyP changed the task status from Open to Feedback.

Do the turrets or other docks that do not switch have permission modules beside the rails, rail docker or rail turret axis?
The does exempt them from any faction change propagation, to prevent takeover of docked neutral ships.

Feel free to upload a sample blueprint and we can look into the exact docks to examine the situation.

  • Andy
Restricted Application added a project: Waiting on Author. · View Herald TranscriptJul 29 2017, 6:23 AM

They do not have any permission module beside the rail.

Restricted Application edited projects, added Customer responded; removed Waiting on Author. · View Herald TranscriptAug 2 2017, 11:12 PM
Restricted Application changed the task status from Feedback to Open. · View Herald Transcript
AndyP changed the task status from Open to Feedback.Aug 3 2017, 12:15 AM

Examined it:

Well looks like the problem is caused by the faction modules on the turrets.

There are 3 inheritance modes:

  • no Faction Module - Result: Will inherit setting of parent
  • with Faction Module - Passive - Result: Will inherit setting of parent
  • with Faction Module - Active - Result: Will not inherit setting of parent

A faction module can either be "Active" or "Passive".
If the last command of the faction module was: "Reset Faction Signature" it will disable its force inheritance, it will set the entity on your faction if you dock it, but it will be a "soft-setting" and never overwrite the parent.

In the other case, you would actively set the faction on the module. This turns this Faction Module to active faction enforcement. It will never accept any parent setting again.

The reason for this is:
If you set a faction Module to have the entity being operated/used by a low-rank member, or 'personal' you do not want this setting to change when the station or parent changes.
This also applies in the case when many ships dock to a large ship or station, resetting the faction on the parent, should not take over the docked player ships.

So to fix it, reset the faction of the ship, and manually reset the faction on all turrets or docks that keep the faction, to turn them back into "follow parent" mode.
Once you reset them all, they will work as expected again.

Restricted Application edited projects, added Waiting on Author; removed Customer responded. · View Herald TranscriptAug 3 2017, 12:15 AM
AndyP closed this task as Closed.May 11 2021, 3:05 PM

Waiting for feedback for a long time now.
Cleanup -> Closed

Restricted Application edited projects, added CBS: Rails; removed Waiting on Author, Issue Navigation. · View Herald TranscriptMay 11 2021, 3:05 PM