Repeatedly linking and unlinking a large amount of blocks causes a memory leak.
Tested on a 100 000 block group, memory usage went from 600 MB to 2GB and higher.
Description
Description
Details
Details
- Commits
- Restricted Diffusion Commit
- Task Type
- Bug
Testing Results
- Affected Gamemode(s)
- Single and Multi
- Reproducible
- Yes
- Last tested (version)
- 0.199.535
- Category
- Control Block System: Weapons
- First occurrence (version)
- 0.1885
Hardware/Software/System
- OS-Specific
- No
- Hardware-Specific
- No
- Video Card Vendor
- uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>
Event Timeline
Comment Actions
It's still there, but you really have to try to get a memory increase. Tested it out on the same 100 000 blocks. Had to press shift + V rapidly 30-50 times before noticing it climbing steadily. FPS did go down rapidly at the end till I got stuck at 1-2 fps.
Lowered priority since you really need to abuse it hard before it goes wrong.
Comment Actions
I've looked at this a bit, and it appears to be quite a serious issue that may be the source of a lot of out of memory issues. Simply spamming V on a single module block will cause a memory leak, see the attached screenshot (the area between the red lines is when V is being spammed). I'm going to pass this issue on because schema has a better understanding of the data structures being used to store connection information.
More debug info for @schema :
Comment Actions
Solved by previous optimization in the group calculation (reusing variable sized threads)
Comment Actions
-QA Testing-
Fix confirmed, can still make it climb slowly but you require quite a lot of spamming and blocks to even make a dent. Spammed Shift + V on 25 000 blocks for about 30 seconds, memory usage increased by about 300MB.
It fully recovered afterwards so no permanent impact.