Page MenuHomeSchine - Phabricator
Create Task
Maniphest T2486

Starmade | Middle mouse ship transfer allows too much
Closed, FinishedPublic
Actions

Description

Several things the middle mouse switching allows that it really shouldn't:

  1. You can switch to other ships that are not docked to you. Could be abused easily, and it also suffers from an issue where the entity you were just in, disappears for a minute or so before re-appearing.
  2. You can use middle mouse button as astronaut, which will crash you as it doesn't find the ship you're currently in, it doesn't exist.

Log of crash

java.lang.NullPointerException
	at org.schema.game.client.controller.manager.ingame.ship.InShipControlManager.checkEnter(InShipControlManager.java:123)
	at org.schema.game.client.controller.manager.ingame.PlayerInteractionControlManager.switchToLookAt(PlayerInteractionControlManager.java:1436)
	at org.schema.game.client.controller.manager.ingame.PlayerInteractionControlManager.handleMouseEvent(PlayerInteractionControlManager.java:1277)
	at org.schema.game.client.controller.manager.AbstractControlManager.handleMouseEvent(AbstractControlManager.java:316)
	at org.schema.game.client.controller.manager.AbstractControlManager.handleMouseEvent(AbstractControlManager.java:316)
	at org.schema.game.client.controller.manager.ingame.InGameControlManager.handleMouseEvent(InGameControlManager.java:317)
	at org.schema.game.client.controller.manager.AbstractControlManager.handleMouseEvent(AbstractControlManager.java:316)
	at org.schema.game.client.controller.manager.GlobalGameControlManager.handleMouseEvent(GlobalGameControlManager.java:237)
	at org.schema.game.client.controller.GameClientController.handleMouseEvent(GameClientController.java:3471)
	at org.schema.game.client.controller.GameClientController.onMouseEvent(GameClientController.java:3493)
	at org.schema.schine.input.BasicInputController.updateInput(BasicInputController.java:227)
	at org.schema.game.client.controller.GameClientController.updateStateInput(GameClientController.java:1461)
	at org.schema.schine.graphicsengine.core.GLFrame.doFrameAndUpdate(GLFrame.java:673)
	at org.schema.schine.graphicsengine.core.GraphicsContext.mainLoop(GraphicsContext.java:808)
	at org.schema.schine.graphicsengine.core.GraphicsContext.startUp(GraphicsContext.java:705)
	at org.schema.game.client.controller.GameMainMenuController.startGraphics(GameMainMenuController.java:1148)
	at org.schema.game.common.Starter.startMainMenu(Starter.java:1450)
	at org.schema.game.common.Starter.main(Starter.java:995)

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.199.645
Category
Engine
First occurrence (version)
0.199.644
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. spawn 2 ship cores
  2. get in one
  3. look at the other one, press middle mouse button

-> You transfer control

for the crash:

  1. be in astronaut mode
  2. look at any entity within range and press middle mouse button

-> you crash, nullpointer.

Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake created this task.Jul 13 2017, 5:12 PM
Restricted Application added a project: Engine. · View Herald TranscriptJul 13 2017, 5:12 PM
schema changed the task status from In Queue to Resolved.Jul 13 2017, 9:54 PM
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJul 13 2017, 9:54 PM
Restricted Application added a subscriber: AndyP. · View Herald Transcript
lancake moved this task from Backlog / Unclassed to Confirmed fix on the Quality Assurance board.Jul 14 2017, 1:09 PM

-QA Testing-

Fix confirmed.

lancake changed Last tested (version) from 0.199.644 to 0.199.645.Jul 14 2017, 1:09 PM
schema added a commit: Restricted Diffusion Commit.Jul 17 2017, 10:25 PM
AndyP moved this task from Backlog / Unclassed to General on the Engine board.Jul 20 2017, 11:08 PM
AndyP edited projects, added Engine (General); removed Engine.
AndyP moved this task from Backlog / Unclassed to Alpha on the Engine (General) board.
lancake closed this task as Closed.Jul 21 2017, 3:54 PM
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJul 21 2017, 3:54 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
AndyP moved this task from Unclassed to Archived on the Starmade board.Jul 22 2017, 9:52 PM