Page MenuHomeSchine - Phabricator

Starmade | Scrollbar appearing when it shouldn't
Closed, FinishedPublic

Description

Related to T2427.
Some menus or dialogs have a scrollbar (that functions) when its content should already fit within its dimensions. The majority of that was fixed, but managed to find at least one more menu that has it:

  • Top bar of the Filter in the storage block menu

You can also see that the stash menu has too much padding at the bottom still, something that was missed in the QA of T2427

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.199.644
Category
Ingame GUI/HUD
First occurrence (version)
0.199.639
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. Place down a storage block
  2. open it and notice too much padding at the bottom
  3. Click on "Change items to auto-pull"
  4. Scroll in the top area of the filter
Tester information (Internal use only)

-QA Testing-

Not 100% sure if this fix caused it, but I know that a few builds ago it was still fine:

  • Fleet order menu doesn't stay within the dialogue box.

  • Creating mail has some weird padding/scaling issues, same goes for the create New Post dialogue


Example of how it should look like (this dialogue is correct in-game too):

Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake created this task.Jul 12 2017, 2:42 PM
Restricted Application added a project: GUI/HUD. · View Herald TranscriptJul 12 2017, 2:42 PM
schema changed the task status from In Queue to Resolved.Jul 12 2017, 4:48 PM
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJul 12 2017, 4:48 PM
Restricted Application added a subscriber: AndyP. · View Herald Transcript
lancake changed the task status from Resolved to In Queue.Jul 13 2017, 1:19 PM

-QA Testing-

Not 100% sure if this fix caused it, but I know that a few builds ago it was still fine:

  • Fleet order menu doesn't stay within the dialogue box.

  • Creating mail has some weird padding/scaling issues, same goes for the create New Post dialogue


Example of how it should look like (this dialogue is correct in-game too):

Restricted Application edited projects, added Game Development, QA-Return; removed Quality Assurance. · View Herald TranscriptJul 13 2017, 1:19 PM
lancake edited Tester information (Internal use only). (Show Details)Jul 13 2017, 1:19 PM
lancake changed Last tested (version) from 0.199.639 to 0.199.643.
schema added a subscriber: schema.Jul 13 2017, 2:03 PM

Yeah, this is the result of cleaning stuff up a bit more. Other stuff has to be adapted for it

schema changed the task status from In Queue to Resolved.Jul 13 2017, 2:45 PM
Restricted Application edited projects, added Quality Assurance; removed QA-Return, Game Development. · View Herald TranscriptJul 13 2017, 2:45 PM
lancake changed the task status from Resolved to In Queue.Jul 13 2017, 5:40 PM

-QA Testing-

One more remaining issue, too much padding on the shipyard "place order" menu:

Restricted Application edited projects, added Game Development, QA-Return; removed Quality Assurance. · View Herald TranscriptJul 13 2017, 5:40 PM
lancake changed Last tested (version) from 0.199.643 to 0.199.644.Jul 13 2017, 5:40 PM
schema changed the task status from In Queue to Resolved.Jul 13 2017, 9:50 PM
Restricted Application edited projects, added Quality Assurance; removed QA-Return, Game Development. · View Herald TranscriptJul 13 2017, 9:50 PM

-QA Testing-

Can't find any remaining issues.

schema added a commit: Restricted Diffusion Commit.Jul 17 2017, 10:25 PM
schema added a commit: Restricted Diffusion Commit.
AndyP moved this task from Backlog / Unclassed to Alpha on the GUI/HUD board.Jul 20 2017, 11:07 PM
lancake closed this task as Closed.Jul 21 2017, 3:54 PM
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJul 21 2017, 3:54 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
AndyP moved this task from Unclassed to Archived on the Starmade board.Jul 22 2017, 9:53 PM