Page MenuHomeSchine - Phabricator
Create Task
Maniphest T2469

Starmade | Crash after recalculating build helper and using fill tool
Closed, FinishedPublic
Actions

Description

If your fill tool is set on a build helper grid (filling empty air) and is restricted, fill a few times, then you recalculate the set build helper to be outside, and use the fill tool again. You may experience the crash below, seems to be inconsistent/rare.

java.lang.NullPointerException
	at it.unimi.dsi.fastutil.longs.LongOpenHashSet$SetIterator.nextLong(LongOpenHashSet.java:343)
	at org.schema.game.client.controller.manager.ingame.FillTool.doFill(FillTool.java:83)
	at org.schema.game.client.view.gui.advancedbuildmode.AdvancedBuildModeFill$2$2.pressedLeftMouse(AdvancedBuildModeFill.java:150)
	at org.schema.game.client.view.gui.advanced.tools.ButtonResult.leftClick(ButtonResult.java:30)
	at org.schema.game.client.view.gui.advanced.tools.GUIAdvButton$1.callback(GUIAdvButton.java:28)
	at org.schema.schine.network.client.GUICallbackController.execute(GUICallbackController.java:64)
	at org.schema.schine.input.BasicInputController.updateInput(BasicInputController.java:234)
	at org.schema.game.client.controller.GameClientController.updateStateInput(GameClientController.java:1461)
	at org.schema.schine.graphicsengine.core.GLFrame.doFrameAndUpdate(GLFrame.java:667)
	at org.schema.schine.graphicsengine.core.GraphicsContext.mainLoop(GraphicsContext.java:808)
	at org.schema.schine.graphicsengine.core.GraphicsContext.startUp(GraphicsContext.java:705)
	at org.schema.game.client.controller.GameMainMenuController.startGraphics(GameMainMenuController.java:1142)
	at org.schema.game.common.Starter.startMainMenu(Starter.java:1450)
	at org.schema.game.common.Starter.main(Starter.java:995)

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.199.633
Category
Engine
First occurrence (version)
0.199.630
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. Set build helper (circle)
  2. Set fill tool + retstricted on a build helper block grid
  3. fill a few times
  4. modify build helper and recalculate
  5. fill a few times again

-> should normally crash

Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake created this task.Jul 5 2017, 12:53 PM
Restricted Application added a project: Engine. · View Herald TranscriptJul 5 2017, 12:53 PM
lancake changed the task status from In Queue to Resolved.Jul 5 2017, 12:53 PM
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJul 5 2017, 12:53 PM
Restricted Application added a subscriber: AndyP. · View Herald Transcript
lancake moved this task from Backlog / Unclassed to Confirmed fix on the Quality Assurance board.Jul 6 2017, 3:10 PM

-QA Testing-

Assuming it's fixed, can't reproduce although you need to get lucky anyway to even get this issue before it was fixed.

lancake changed Last tested (version) from 0.199.630 to 0.199.633.Jul 6 2017, 3:11 PM
lancake closed this task as Closed.Jul 7 2017, 12:33 PM
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJul 7 2017, 12:33 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
AndyP moved this task from Unclassed to Archived on the Starmade board.Jul 20 2017, 10:38 PM