Page MenuHomeSchine - Phabricator

Starmade | Fill tool crash with meta item and shape selection
Closed, FinishedPublic

Description

Trying to fill with a meta item selected or the multi slot shape selection + icon (to select or add shapes), results in the following exception.

java.lang.ArrayIndexOutOfBoundsException: -1
	at org.schema.game.common.data.element.ElementKeyMap.getInfoFast(ElementKeyMap.java:652)
	at org.schema.game.client.view.gui.advancedbuildmode.AdvancedBuildModeShape$5$3.pressedLeftMouse(AdvancedBuildModeShape.java:324)
	at org.schema.game.client.view.gui.advanced.tools.ButtonResult.leftClick(ButtonResult.java:29)
	at org.schema.game.client.view.gui.advanced.tools.GUIAdvButton$1.callback(GUIAdvButton.java:28)
	at org.schema.schine.network.client.GUICallbackController.execute(GUICallbackController.java:64)
	at org.schema.schine.input.BasicInputController.updateInput(BasicInputController.java:232)
	at org.schema.game.client.controller.GameClientController.updateStateInput(GameClientController.java:1461)
	at org.schema.schine.graphicsengine.core.GLFrame.doFrameAndUpdate(GLFrame.java:667)
	at org.schema.schine.graphicsengine.core.GraphicsContext.mainLoop(GraphicsContext.java:808)
	at org.schema.schine.graphicsengine.core.GraphicsContext.startUp(GraphicsContext.java:705)
	at org.schema.game.client.controller.GameMainMenuController.startGraphics(GameMainMenuController.java:1119)
	at org.schema.game.common.Starter.startMainMenu(Starter.java:1449)
	at org.schema.game.common.Starter.main(Starter.java:994)

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.199.614
Category
Engine
First occurrence (version)
0.199.611
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. Select a meta item
  2. Set fill location
  3. "Do Fill"
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake created this task.Jun 19 2017, 1:42 PM
Restricted Application added a project: Engine. · View Herald TranscriptJun 19 2017, 1:42 PM
lancake added a commit: Restricted Diffusion Commit.Jun 20 2017, 9:07 PM
lancake changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJun 20 2017, 9:07 PM
Restricted Application added a subscriber: AndyP. · View Herald Transcript

-QA Testing-

Fix confirmed, although it may pop up again if we allow filling with shapes too.

lancake changed Last tested (version) from 0.199.611 to 0.199.614.Jun 21 2017, 7:58 PM
lancake closed this task as Closed.
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJun 21 2017, 7:58 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
AndyP moved this task from Unclassed to Archived on the Starmade board.Jul 20 2017, 10:40 PM