Page MenuHomeSchine - Phabricator

Starmade | Fill tool ignores "restrict building to helper"
Closed, FinishedPublic

Description

The option to not place or remove blocks outside the outline, does not work for the fill tool.
If it works, it also needs to make sure it progresses as there's tons of blocks where the tool is not allowed to place blocks down, yet still subtracts that from the "block to place down" count as reported in T2432

Otherwise, you'll end up with extremely slow filling for medium to large build helper outlines.

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.199.641
Category
Engine
First occurrence (version)
0.199.611
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. Set a build helper
  2. Restrict building to helper
  3. Use the fill tool on it

-> Fill tool just fills, doesn't stay within the build helper outline.

Tester information (Internal use only)

Partial fix.

Issue 1

With "Restrict to building helper" disabled and having a build helper set, filling does nothing when it should act like a normal fill.

Issue 2

Setting a fill origin with already a build helper set, and then toggling on later "Restrict to building helper" doesn't actually do anything. It still acts as if it's disabled.
You have to have "Restrict to building helper" enabled before you put down the fill origin.

Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake created this task.Jun 19 2017, 9:34 AM
schema added a commit: Restricted Diffusion Commit.Jun 21 2017, 5:57 AM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJun 21 2017, 5:57 AM
Restricted Application added a subscriber: AndyP. · View Herald Transcript
lancake changed the task status from Resolved to In Queue.Jun 22 2017, 11:09 AM

-QA Testing-

Issue 1

It works too well :(
The fill tool will only fill the touching build helper blocks and unfortunately they often don't touch, filling stops because of that.


In theory, if it looks 1 block further after encountering air, it should be able to continue with any current build helper.

Issue 2

It doesn't care about the "Restrict Building to Helper" setting. It always assumes that option is enabled.

Restricted Application edited projects, added Game Development, QA-Return; removed Quality Assurance. · View Herald TranscriptJun 22 2017, 11:09 AM
lancake edited Tester information (Internal use only). (Show Details)Jun 22 2017, 11:09 AM
lancake set Last tested (version) to 0.199.614.
lancake changed Category from none/unspecified to Engine.
lancake set First occurrence (version) to 0.199.611.
Restricted Application added a project: Engine. · View Herald TranscriptJun 22 2017, 11:09 AM
schema added a commit: Restricted Diffusion Commit.Jun 23 2017, 1:40 PM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed QA-Return, Game Development. · View Herald TranscriptJun 23 2017, 1:40 PM

-QA Testing-

Partial fix, almost there though.

Issue 1

It ignores the "Restrict to building helper" setting. Now it just assumes it's always enabled if there is a build helper.

Issue 2

Filling a build helper fails like before like this

after doing the following steps:

  1. set a circle build helper
  2. set tool and fill the build helper completely
  3. undo some or all steps (just so you get some empty areas again)
  4. reset the fill tool
  5. place the fill tool origin again
  6. do a fill step

-> Now it behaves like before, only fills the touching blocks and nothing more.

lancake changed Last tested (version) from 0.199.614 to 0.199.618.Jun 27 2017, 1:26 PM
lancake edited Tester information (Internal use only). (Show Details)
lancake moved this task from Confirmed fix to Backlog / Unclassed on the Quality Assurance board.
lancake changed the task status from Resolved to In Queue.
Restricted Application edited projects, added Game Development, QA-Return; removed Quality Assurance. · View Herald TranscriptJun 27 2017, 1:27 PM
schema added a commit: Restricted Diffusion Commit.Jun 28 2017, 11:48 AM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed QA-Return, Game Development. · View Herald TranscriptJun 28 2017, 11:48 AM
lancake changed the task status from Resolved to In Queue.Jun 29 2017, 2:06 PM

-QA Testing-

Partial fix.

Issue 1

With "Restrict to building helper" disabled and having a build helper set, filling does nothing when it should act like a normal fill.

Issue 2

Setting a fill origin with already a build helper set, and then toggling on later "Restrict to building helper" doesn't actually do anything. It still acts as if it's disabled.
You have to have "Restrict to building helper" enabled before you put down the fill origin.

Restricted Application edited projects, added Game Development, QA-Return; removed Quality Assurance. · View Herald TranscriptJun 29 2017, 2:06 PM
lancake edited Tester information (Internal use only). (Show Details)Jun 29 2017, 2:06 PM
lancake changed Last tested (version) from 0.199.618 to 0.199.625.
schema added a commit: Restricted Diffusion Commit.Jul 5 2017, 12:59 PM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed QA-Return, Game Development. · View Herald TranscriptJul 5 2017, 12:59 PM

-QA Testing-

Works, but some of the build helpers, depending on angle and size don't fill properly. Different issue so this one can be closed.

lancake changed Last tested (version) from 0.199.625 to 0.199.641.Jul 13 2017, 5:51 PM
lancake claimed this task.
AndyP moved this task from Backlog / Unclassed to Building on the Engine board.Jul 20 2017, 11:09 PM
AndyP edited projects, added Engine (Building); removed Engine.
AndyP moved this task from Backlog / Unclassed to Alpha on the Engine (Building) board.
lancake closed this task as Closed.Jul 21 2017, 3:54 PM
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJul 21 2017, 3:54 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
AndyP moved this task from Unclassed to Archived on the Starmade board.Jul 22 2017, 9:54 PM