Page MenuHomeSchine - Phabricator

Starmade | Shipyards causing disconnect and class cast exceptions
Closed, FinishedPublic

Description

On version 0.199.528, shipyards are a bit broken. They disconnect my client when attempting to undock a ship that has been created and then cause class cast exceptions when attempting to load another design. I also had an error where it stated the design was too large for the shipyard, but it clearly wasn't. I was doing the experiment on the copy of the LvD world on the dev server at sector 2000, 2000, 2000.

Crash to main menu:

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Serverside
Reproducible
uncertain
Last tested (version)
0.199.528
Category
Engine
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. Build a shipyard with an attached storage. Set the shipyard to pull on build. Fill the storage will every kind of item.
  2. Create a design from a blueprint.
  3. Load the design.
  4. Put in an order to build the ship. Give it a name with spaces (to be congruent with my own tests).
  5. Click the "Undock" button. <-- this is what caused my client to disconnect with a null pointer exception disconnect.
  6. Rejoin the server (does not seem to matter if you fully restart the client or not).
  7. Try to load the design again. It will either give a class cast exception, or it will cancel loading the design stating the design is too large for the shipyard.

You can then repeat the process to reproduce the problem consistently.

Tester information (Internal use only)

Logs for the nullpointer:

[2017-04-20 01:35:56] [RAIL] Client(1) DISCONNECTED FROM RAIL: Ship[schema_1492644932863](517) LEFT IN RAIL SpaceStation[ENTITY_SPACESTATION_Big shipyard V2_1492644923502(516)]: []
[2017-04-20 01:35:56] java.lang.NullPointerException
[2017-04-20 01:35:56] 	at obfuscated.aaz.a(SourceFile:952)
[2017-04-20 01:35:56] 	at obfuscated.Yc.updateLocal(SourceFile:2731)
[2017-04-20 01:35:56] 	at obfuscated.Yr.updateLocal(SourceFile:403)
[2017-04-20 01:35:56] 	at org.schema.game.common.controller.EditableSendableSegmentController.updateLocal(SourceFile:1168)
[2017-04-20 01:35:56] 	at obfuscated.YA.updateLocal(SourceFile:493)
[2017-04-20 01:35:56] 	at obfuscated.J.update(SourceFile:1333)
[2017-04-20 01:35:56] 	at obfuscated.aFN.a(SourceFile:719)
[2017-04-20 01:35:56] 	at obfuscated.aFT.b(SourceFile:698)
[2017-04-20 01:35:56] 	at obfuscated.V.e(SourceFile:1110)
[2017-04-20 01:35:56] 	at org.schema.game.common.Starter.startMainMenu(SourceFile:1489)
[2017-04-20 01:35:56] 	at org.schema.game.common.Starter.main(SourceFile:1034)
Serverconfig (server.cfg)
<replace this block with the file content,
but do not remove the first and last line.
Before using the paste function,
mark the area from the opening angle bracket to the closing angle bracket>
Clientconfig (settings.cfg)
<replace this block with the file content,
but do not remove the first and last line.
Before using the paste function,
mark the area from the opening angle bracket to the closing angle bracket>

Event Timeline

Restricted Application added a project: Issue Navigation. · View Herald TranscriptApr 19 2017, 8:55 PM
AndyP claimed this task.Apr 19 2017, 8:57 PM
AndyP shifted this object from the S1 Public space to the S3 Starmade space.Apr 19 2017, 9:04 PM
AndyP changed the visibility from "Custom Policy" to "Public (No Login Required)".
AndyP changed the edit policy from "Task Author" to "Starmade (Project)".
AndyP changed Affected Gamemode(s) from none/unspecified to Serverside.
AndyP changed Last tested (version) from 0.199.596 to 0.199.528.
AndyP changed Category from none/unspecified to Engine.
Restricted Application added a project: Starmade. · View Herald TranscriptApr 19 2017, 9:04 PM

Also possibly related. If you enter the design ship (not physical), then bring up the DEL menu and click the "Undock all" button, it will crash you. Upon rejoining, all the docked entities on the design are gone. Unloading the design and reloading it works, but the entities are still undocked.

AndyP added a project: Engine (Crashes).
AndyP changed the task status from Open to In Queue.
Restricted Application edited projects, added Game Development; removed Issue Navigation. · View Herald TranscriptApr 19 2017, 9:06 PM
Benevolent27 added a comment.EditedApr 19 2017, 9:07 PM

And furthermore, when docking a ship to the shipyard and manually undocking, also causes a crash to main menu. When rejoining the server, the ship was also gone.
No trace of it.

Thread dump when class cast exception occurs (taken with VisualVM):


Application Snapshot:

Benevolent27 added a comment.EditedApr 19 2017, 10:55 PM

I decided to also test on our server, since I have full access to the logs and could submit them here. I thought it might also be useful to have a snapshot from whatever the issue may have been on the version we are currently running.

It seems there was a class cast exception on version 523, which our server is currently on. I'll include this here as well. This copy of the logs also contains a thread dump. However, on this version, there was no crash to main menu when undocking the entity. Unloading and reloading the design DOES yield another class cast exception though.

Class cast exception when creating design from blueprint.
StarMade Version: 0.199.523#20170415_011448
http://lvdserver.b33r.us/logsForAndy/StarMade/[04-19-17][18:54:27]-Summon.zip

AndyP changed the task status from In Queue to Open.Apr 19 2017, 10:57 PM
Restricted Application edited projects, added Issue Navigation, Dev-Return; removed Game Development. · View Herald TranscriptApr 19 2017, 10:57 PM
schema added a subscriber: schema.Apr 19 2017, 11:29 PM

Fixed class cast exception

Logs for the nullpointer:

[2017-04-20 01:35:56] [RAIL] Client(1) DISCONNECTED FROM RAIL: Ship[schema_1492644932863](517) LEFT IN RAIL SpaceStation[ENTITY_SPACESTATION_Big shipyard V2_1492644923502(516)]: []
[2017-04-20 01:35:56] java.lang.NullPointerException
[2017-04-20 01:35:56] 	at obfuscated.aaz.a(SourceFile:952)
[2017-04-20 01:35:56] 	at obfuscated.Yc.updateLocal(SourceFile:2731)
[2017-04-20 01:35:56] 	at obfuscated.Yr.updateLocal(SourceFile:403)
[2017-04-20 01:35:56] 	at org.schema.game.common.controller.EditableSendableSegmentController.updateLocal(SourceFile:1168)
[2017-04-20 01:35:56] 	at obfuscated.YA.updateLocal(SourceFile:493)
[2017-04-20 01:35:56] 	at obfuscated.J.update(SourceFile:1333)
[2017-04-20 01:35:56] 	at obfuscated.aFN.a(SourceFile:719)
[2017-04-20 01:35:56] 	at obfuscated.aFT.b(SourceFile:698)
[2017-04-20 01:35:56] 	at obfuscated.V.e(SourceFile:1110)
[2017-04-20 01:35:56] 	at org.schema.game.common.Starter.startMainMenu(SourceFile:1489)
[2017-04-20 01:35:56] 	at org.schema.game.common.Starter.main(SourceFile:1034)
lancake edited Tester information (Internal use only). (Show Details)Apr 19 2017, 11:38 PM
schema closed this task as Closed.Apr 19 2017, 11:50 PM

fixed Nullpointer. Both fixes 0.199.531 or later

Restricted Application removed projects: Dev-Return, Issue Navigation. · View Herald TranscriptApr 19 2017, 11:50 PM
schema reopened this task as Resolved.Apr 19 2017, 11:50 PM
Restricted Application added a project: Quality Assurance. · View Herald TranscriptApr 19 2017, 11:50 PM

misclicked on "closed" instead of "resolved"

schema added a commit: Restricted Diffusion Commit.Apr 21 2017, 1:09 PM
lancake moved this task from Unclassed to Archived on the Starmade board.Apr 24 2017, 2:34 PM
lancake closed this task as Closed.Apr 28 2017, 1:23 PM
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptApr 28 2017, 1:23 PM