Page MenuHomeSchine - Phabricator

Starmade | When selling many items to a shop, it might say not enough money in shop even though there is
Closed, FinishedPublic

Description

When trying to sell bulk of items (for example 1.000.000 Rocks) to a shop in one go, it will display the right price but will then correct itself to a very low number (maybe 100 to 1000) because the shop doesn't have enough money to buy all the items (but it definetly does have more then enough money)

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Multiplayer
Reproducible
Yes
Last tested (version)
0.199.346
Category
Tradenetwork/Shops
First occurrence (version)
0.199.334
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce

Give yourself 1.000.000 Rocks (id 73)
Sell it from inventory to a shop that has around 10million credits
You will notice that you can't sell all 1.000.000 at once, but rather a small amount each time and it says the shop has not enough money

OR

Try to buy large amounts

Tester information (Internal use only)

Amount entered is too big, pressing OK should bring it back to the stock limit: 1020

Pressing OK doesn't bring it to 1020 but to 6276 which is the actual stock of the item, error message is about "Item out of stock"

Pressing OK again brings it to 1020 now which is correct, error message this time is "You can't afford that many! You can only afford 1020" which is not true, I can afford more but it's the shop that doesn't offer me more blocks.


Selling an item caps properly but also gives the wrong error message. "Shop can't pay fully you! You can only ..."


Summation, 3 issues:

  1. BUYING BLOCKS: First time pressing OK, it will enter the total stock amount in the display and not the actual stock limit
  2. BUYING BLOCKS: Error message that caps it to the stock limit, is wrong.
  3. SELLING BLOCKS: Error message that caps it to amount the shop accept, is wrong.
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

ThaHenry created this task.Dec 12 2016, 7:53 PM
SmilingDemon shifted this object from the S1 Public space to the S3 Starmade space.Dec 12 2016, 8:41 PM
SmilingDemon changed the visibility from "Custom Policy" to "Public (No Login Required)".
SmilingDemon changed the edit policy from "Task Author" to "Starmade (Project)".
SmilingDemon changed Category from Typos/Content to Engine.
SmilingDemon claimed this task.
SmilingDemon triaged this task as Pre-Release Quality Assurance priority.
Restricted Application added a subscriber: AndyP. · View Herald TranscriptDec 12 2016, 8:42 PM
SmilingDemon edited Tester information (Internal use only). (Show Details)Dec 12 2016, 8:43 PM
lancake added a subscriber: SmilingDemon.
lancake changed the task status from Open to In Queue (Game).
lancake claimed this task.
Restricted Application edited projects, added Game Development; removed Issue Navigation. · View Herald TranscriptDec 13 2016, 12:33 AM
lancake edited Steps to reproduce. (Show Details)Dec 13 2016, 12:36 AM
lancake edited Tester information (Internal use only). (Show Details)
lancake changed Category from Engine to Tradenetwork/Shops.
lancake set First occurrence (version) to 0.199.334.
schema changed the task status from In Queue (Game) to Resolved.Dec 13 2016, 3:05 PM
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptDec 13 2016, 3:05 PM

not completely fixed but better at least. Seems to be some issue with the shop limit or related to it at least.

lancake changed the task status from Resolved to In Queue (Game).Dec 15 2016, 5:35 PM

Amount entered is too big, pressing OK should bring it back to the stock limit: 1020

Pressing OK doesn't bring it to 1020 but to 6276 which is the actual stock of the item, error message is about "Item out of stock"

Pressing OK again brings it to 1020 now which is correct, error message this time is "You can't afford that many! You can only afford 1020" which is not true, I can afford more but it's the shop that doesn't offer me more blocks.


Selling an item caps properly but also gives the wrong error message. "Shop can't pay fully you! You can only ..."


Summation, 3 issues:

  1. BUYING BLOCKS: First time pressing OK, it will enter the total stock amount in the display and not the actual stock limit
  2. BUYING BLOCKS: Error message that caps it to the stock limit, is wrong.
  3. SELLING BLOCKS: Error message that caps it to amount the shop accept, is wrong.
Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptDec 15 2016, 5:35 PM
lancake edited Tester information (Internal use only). (Show Details)Dec 15 2016, 5:35 PM
lancake changed Last tested (version) from 0.199.334 to 0.199.338.
schema changed the task status from In Queue (Game) to Resolved.Dec 15 2016, 5:57 PM
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptDec 15 2016, 5:57 PM
lancake closed this task as Closed.

-QA Testing-
Fix confirmed.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptDec 17 2016, 9:46 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
lancake changed Last tested (version) from 0.199.338 to 0.199.346.Dec 17 2016, 9:46 PM
Restricted Application added a project: Tradenetwork. · View Herald TranscriptMar 10 2017, 6:06 PM