Page MenuHomeSchine - Phabricator
Create Task
Maniphest T2052

Starmade | Selling bug in the trade network
Closed, FinishedPublic
Actions

Description

If you sell goods of your shop via trade network, the selling shop receives the credits, but the sold goods will not be substracted.

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.199.342
Category
Tradenetwork/Shops
First occurrence (version)
0.199.276
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. Search for a shop in the trade network that buys one of your goods, for example power reactors.
  2. Sell your whole stock.
  3. You receive immediatly the profit on your shop account, the power reactors are still in your stock.
  4. You can sell immediatly them again and can bail the complete shop account within minutes!!!
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

Skorpjon updated the task description. (Show Details)Nov 19 2016, 12:16 PM
Skorpjon edited Steps to reproduce. (Show Details)
lancake added a subscriber: lancake.Nov 19 2016, 6:14 PM
lancake claimed this task.

-validated-

The fleet is supposed to pick up those goods but that should happen quickly, I'll look into it.
Thanks for the report!

lancake shifted this object from the S1 Public space to the S3 Starmade space.Nov 19 2016, 6:15 PM
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.
lancake changed Reproducible from uncertain to Yes.
lancake set Last tested (version) to 0.199.276.
lancake set First occurrence (version) to 0.199.276.
lancake triaged this task as Pre-Release Quality Assurance priority.
Restricted Application added a subscriber: AndyP. · View Herald TranscriptNov 19 2016, 6:15 PM
Skorpjon added a comment.Nov 19 2016, 6:56 PM

You're welcome and I hope it will be fixed soon. The shop owner doesn't get a message about it. So there is no warning and no easy way to catch a bug user.

StormWing0 added a subscriber: StormWing0.Nov 26 2016, 8:10 PM

I've been noticing that the NPC Stations don't have shop blocks and in some cases won't trade with anyone, also the ones that do trade seem to ignore the player.

schema changed the task status from Open to Resolved.Dec 1 2016, 9:43 PM
Restricted Application edited projects, added Quality Assurance; removed Issue Navigation. · View Herald TranscriptDec 1 2016, 9:43 PM
lancake changed Category from none/unspecified to Tradenetwork/Shops.Dec 13 2016, 12:53 AM
lancake moved this task from Backlog / Unclassed to Confirmed fix on the Quality Assurance board.Dec 16 2016, 2:15 PM
lancake closed this task as Closed.

-QA Testing-

Fix confirmed:

  1. Buying from a shop:
    1. They lose those blocks
    2. They gain the "Raw block credit cost"
    3. You pay the "Raw block credit cost" + "delivery cost"
  1. Selling to a shop:
    1. They gain those blocks
    2. They lose the "Raw block credit cost"
    3. You receive the "Raw block credit cost" - "delivery cost"

It makes a bit more sense if the target shop you sell to pays for the delivery costs maybe...but this is fine I believe.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptDec 16 2016, 2:15 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
lancake changed Last tested (version) from 0.199.276 to 0.199.342.Dec 16 2016, 2:15 PM
Restricted Application added a project: Tradenetwork. · View Herald TranscriptMar 10 2017, 6:07 PM