Page MenuHomeSchine - Phabricator
Create Task
Maniphest T1801

Starmade | Editing "HpConditionTriggerList" with customBlockBehaviorConfig.xml results in a failed merge
Confirmed task for development, LowPublic
Actions

Description

Using customBlockBehaviorConfig.xml to change the values in <HpConditionTriggerList> crashes on universe load with this error:

"[GLFrame] Error Message: HpConditionTriggerList -> Item; trigger amount must be a positive value in <Amount>
(FixSuggestion: check your xml config files)"

This happens even with all values in <Amount> left at the default.

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
none/unspecified
Reproducible
Yes
Last tested (version)
0.200.269
Category
Engine
First occurrence (version)
0.199.132
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
NVIDIA
Steps to reproduce
  1. Use the attached customBlockBehaviorConfig.xml
Tester information (Internal use only)

The merge seems to end up with 2 missing <Amount> nodes. The type is always THRUST and condition HP is never altered from the original. Probably because these are not unique nodes.

I'm not really sure how a custom config is supposed to merge with this even. It's probably easier to wipe any value within the HPTriggerConditions and repopulate it with the custom values.

failedMergeResult.xml3 KBDownload

Java Version (64bit)

1.80_101

Event Timeline

e4278 created this task.Aug 8 2016, 4:08 PM

customBlockBehaviorConfig.xml3 KBDownload

log.txt.03 MBDownload

Config and log attached.

AndyP shifted this object from the S1 Public space to the S3 Starmade space.Mar 3 2017, 11:27 AM
AndyP changed the visibility from "Custom Policy" to "Public (No Login Required)".
AndyP changed the edit policy from "Task Author" to "Starmade (Project)".
AndyP moved this task from New / Unconfirmed to Open / Validated on the Issue Navigation board.
AndyP claimed this task.
AndyP triaged this task as Normal priority.

-Validated-

will look into this

AndyP edited Serverconfig (server.cfg). (Show Details)Mar 3 2017, 11:28 AM
AndyP edited Clientconfig (settings.cfg). (Show Details)
lancake moved this task from Open / Validated to Confirmed on the Issue Navigation board.Dec 28 2017, 2:58 PM
lancake added subscribers: AndyP, lancake.
lancake changed the task status from Open to In Queue.
lancake claimed this task.

The merge seems to end up with 2 missing <Amount> nodes. The type is always THRUST and condition HP is never altered from the original. Probably because these are not unique nodes.

I'm not really sure how a custom config is supposed to merge with this even. It's probably easier to wipe any value within the HPTriggerConditions and repopulate it with the custom values.

failedMergeResult.xml3 KBDownload

Restricted Application edited projects, added Game Development; removed Issue Navigation. · View Herald TranscriptDec 28 2017, 2:58 PM
lancake edited Steps to reproduce. (Show Details)Dec 28 2017, 3:00 PM
lancake edited Tester information (Internal use only). (Show Details)
lancake changed Last tested (version) from v0.199.132 to 0.200.269.
lancake changed Category from none/unspecified to Engine.
lancake set First occurrence (version) to 0.199.132.
lancake renamed this task from Editing "HpConditionTriggerList" with customBlockBehaviorConfig.xml gives error even when using default values. to Editing "HpConditionTriggerList" with customBlockBehaviorConfig.xml results in a failed merge.
lancake lowered the priority of this task from Normal to Low.
Restricted Application added a project: Engine. · View Herald TranscriptDec 28 2017, 3:00 PM