Page MenuHomeSchine - Phabricator
Create Task
Maniphest T1704

Launcher | Move default Electron cache directory
Closed, FinishedPublic
Actions

Description

Prior to release, the launcher cache should be located within the launcher directory.
This will help keep our install clean and self-contained.

As a byproduct, it will also perform a one-time reset of launcher data for the public release. This is needed because previous versions changed the default directory to ./StarMade, and that behavior should be the default, especially on Steam so that Steam may manage game updates itself.

current cache directories: %AppData%/.StarMade (windows), ~/.StarMade (posix)

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Task
Testing Results
Affected Gamemode(s)
Launcher
Reproducible
uncertain
Last tested (version)
159 1eae39f
Category
Launcher
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Related Objects

Event Timeline

calani created this task.Jul 19 2016, 3:21 AM
Restricted Application added a subscriber: AndyP. · View Herald TranscriptJul 19 2016, 3:21 AM
calani changed Task Type from Bug to Task.Jul 19 2016, 3:22 AM
calani edited Serverconfig (server.cfg). (Show Details)
calani edited Clientconfig (settings.cfg). (Show Details)
calani moved this task from Backlog / Unclassed to Active on the Launcher Development board.
Valck added a subscriber: Valck.Jul 19 2016, 3:51 AM

I'm not familiar with the directory structure on MacOS, but for Linux at least, would you consider using ~/.config/StarMade as the cache location in order to avoid cluttering ~ ?

calani added a commit: Restricted Diffusion Commit.Jul 21 2016, 4:33 AM
calani changed the task status from In Queue (Launcher) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Launcher Development. · View Herald TranscriptJul 21 2016, 4:33 AM
SmilingDemon added a subscriber: SmilingDemon.Aug 1 2016, 2:04 PM
SmilingDemon changed the task status from Resolved to In Queue (Launcher).

-QA Testing-

on windows it creates a .cache folder and places info there
like this
starmade-launcher-win32-x64\.cache\StarMade\Launcher

on Ubuntu it did create a folder .cache and a folder Launcher next to its own install path

i would prefer the windows version .. which makes it possible to use more than one launcher at the same time with different settings.

Restricted Application edited projects, added Launcher Development; removed Quality Assurance. · View Herald TranscriptAug 1 2016, 2:04 PM
SmilingDemon changed Last tested (version) from v2.0.8 / build 152 to 158 fe18f38 .Aug 1 2016, 2:04 PM
SmilingDemon changed Category from none/unspecified to Launcher.
calani added a comment.Aug 2 2016, 5:45 AM

Yes, that cache location is a bug -- it should live within launcher/.cache as with Windows.

(The timestamp, however, is quite confusing -- though largely irrelevant. I may give it some consideration if it continues happening with the correct .cache location.)

SmilingDemon added a comment.Aug 2 2016, 8:12 AM

ignore the timestamp ... didnt happen again on the following tests.

maybe the server was still half asleep or dreaming of its glorious past ;)

calani added a comment.EditedAug 13 2016, 4:17 AM

Update: the cache should live within ~/Library/Application Support/... on OSX to prevent breaking the .app code signature

calani added a commit: Restricted Diffusion Commit.Aug 13 2016, 10:03 AM
calani changed the task status from In Queue (Launcher) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Launcher Development. · View Herald TranscriptAug 13 2016, 10:03 AM
calani added a commit: Restricted Diffusion Commit.Aug 13 2016, 10:03 AM
SmilingDemon added a comment.Aug 14 2016, 1:18 PM

-QA Testing-

Looks good now on Ubuntu for me

SmilingDemon changed Last tested (version) from 158 fe18f38 to 159 1eae39f.Aug 14 2016, 1:21 PM
AndyP closed this task as Closed.Dec 15 2016, 12:44 AM
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptDec 15 2016, 12:44 AM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript