Page MenuHomeSchine - Phabricator
Create Task
Maniphest T1659

Starmade | shop permissions lock out everyone
Resolved, needs quality check / confirm fix, HighPublic
Actions

Description

NO ENEMIES
ALLIES ONLY
FACTION ONLY

These 3 don't do what they're supposed to do.

With this enabled, everyone *except for the owner* will have:

  • buy button disabled
  • sell button enabled, but you get an error when trying it out: You are not allowed to buy at this shop! (no permission)

The owner will have:

  • both buttons enabled, but both give you an error when trying it out: You are not allowed to buy at this shop! (no permission)
NOTE: I'm not entirely sure if this is reproducible, we noticed that the trade system itself refused to enable on that shop soon afterwards. On other shops, enabling/disabling the trade network resets the permission so perhaps that has something to do with it.

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.198.416
Category
Tradenetwork/Shops
First occurrence (version)
0.198.416
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Related Objects

Event Timeline

lancake created this task.Jul 8 2016, 6:22 PM
Restricted Application added a subscriber: AndyP. · View Herald TranscriptJul 8 2016, 6:22 PM
lancake updated the task description. (Show Details)Jul 8 2016, 6:56 PM
schema changed the task status from In Queue (Game) to Resolved.Jul 11 2016, 8:04 PM
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJul 11 2016, 8:04 PM
Benevolent27 added a subscriber: Benevolent27.EditedJul 31 2016, 5:51 AM

Confirmed for "no enemies" permission.

The "allies" and "faction only" options will block outside users, but I have not tested yet to see if they allow users that do meet the requirements.

lancake lowered the priority of this task from Pre-Release Quality Assurance to High.Dec 14 2016, 11:54 PM
lancake changed Category from Engine to Tradenetwork/Shops.Mar 10 2017, 2:55 PM
lancake merged a task: T1933: Bug in Shop Permissions.
lancake added a subscriber: Skorpjon.
Restricted Application added a project: Tradenetwork. · View Herald TranscriptMar 10 2017, 6:11 PM
AndyP moved this task from Backlog / Unclassed to Alpha on the Tradenetwork board.Mar 15 2017, 4:10 PM
lancake added a comment.Jun 16 2017, 4:10 PM

This one is still a bit bugged in current release although close to being fixed in unreleased dev. Will have to check it again then.