Page MenuHomeSchine - Phabricator

Starmade | Spawning ships with same names as formerly existing one may lack docked entities
Closed, FinishedPublic

Description

I Have no idea what causes this bug, but it can be rather frustrating losing random parts of a ship that were docked. Especially since it consumes/deletes the materials from that missing entity.

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.199.491
Category
Engine
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. Spawn a ship with easyname and docked entities
  2. undock enities and delete the main ship
  3. Spawn in same ship with the same name
  4. formerly uindocked entites are missing on new ship
Tester information (Internal use only)

looks better but its not quite right yet


spawning in the ship with the same name causes those two to drift in space and as far as i could find
testrl30,testrl400,testrl40 (names from the original ship)
are missing from the new spawned ship

a newly spawned ship with a different name is just fine!

Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

Napther updated the task description. (Show Details)Apr 5 2016, 1:00 PM
Napther changed Category from none/unspecified to Engine.
Napther edited Serverconfig (server.cfg). (Show Details)
Napther edited Clientconfig (settings.cfg). (Show Details)
Napther changed Affected Gamemode(s) from none/unspecified to Single and Multi.
Napther changed Reproducible from uncertain to Not on purpose.
Napther set Last tested (version) to 0.19624.
Napther edited Steps to reproduce. (Show Details)
Napther added a subscriber: Napther.
Napther created this task.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptApr 5 2016, 1:00 PM
SmilingDemon shifted this object from the S1 Public space to the S3 Starmade space.Apr 6 2016, 4:56 PM
SmilingDemon changed the visibility from "Custom Policy" to "Public (No Login Required)".
SmilingDemon changed the edit policy from "Task Author" to "Starmade (Project)".
SmilingDemon set Task Type to Bug.
SmilingDemon set OS-Specific to No.
SmilingDemon set Hardware-Specific to No.
SmilingDemon set Video Card Vendor to uncertain.
SmilingDemon claimed this task.
SmilingDemon triaged this task as High priority.
Restricted Application added a subscriber: AndyP. · View Herald TranscriptApr 6 2016, 4:57 PM

What is it that you call large in this case ?
How many docked entities are being spawned with the blueprint?
How many other entities are in the sector while spawning from the BP?
Have you made sure the enities arnt floating somewhere after unloading/loading the sector ?
are you able to provide a sample BP (in case it did happen mostly with one specific BP often enough)

When travelling, the original got a little star-struck. I lost some entities in the damage from the star.
Spawning the ship in on the same name a month later, some entities were missing upon deconstruction

respawning a month later under the same name, it was missing entities.

After now reading this (My apologies, there isnt much of a warning on these things for Phabricator messages) I spawned in the ship under the original name. It was missing 2 hanger doors and an Injector. Respawning the ship with a randomly typed name, the blueprint loaded with all entities as it should. I believe this is the exact issue at hand.

Steps to reproduce:

  1. Spawn in any ship with at least 1 entity docked to it. Call it something like "test2test"
  2. Select mothership, do a /destroy_entity -> Turrets are now free floating, etc.

3)Spawn in the same ship (Or even any other ship) under the exact name of the deleted Mothership

  1. Notice missing docked entities from the mothership based on the rl0, rl1, rl2 that already exists under the same name
SmilingDemon renamed this task from Blueprint Spawning ships sometimes delete random entities from it to Spawning ships with same names as formerly existing one may lack docked entities.
SmilingDemon raised the priority of this task from High to Release Blocker.
SmilingDemon changed Reproducible from Not on purpose to Yes.
SmilingDemon changed Last tested (version) from 0.19624 to 0.197.46 (DEV).
SmilingDemon changed the task status from Open to In Queue (Game).
Restricted Application edited projects, added Starmade, Game Development; removed Issue Navigation. · View Herald TranscriptApr 23 2016, 5:30 PM
schema changed the task status from In Queue (Game) to In Queue (Launcher).Mar 9 2017, 4:24 PM
Restricted Application edited projects, added Launcher Development; removed Game Development. · View Herald TranscriptMar 9 2017, 4:24 PM
schema changed the task status from In Queue (Launcher) to In Queue (Game).Mar 9 2017, 4:25 PM
Restricted Application edited projects, added Game Development; removed Launcher Development. · View Herald TranscriptMar 9 2017, 4:25 PM
schema added a commit: Restricted Diffusion Commit.Mar 9 2017, 11:18 PM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptMar 9 2017, 11:18 PM
Restricted Application added a project: Engine. · View Herald TranscriptMar 10 2017, 6:14 PM
SmilingDemon added a comment.EditedMar 10 2017, 7:17 PM

-QA Testing-

no clue why and what i did to this that it was closed as "Unkown Status" ??!!

anyways ... its not fixed

spawned in a ship with docks - removed it with /destroy_entity - respawned the same thing under the same name .. no docks present

left the remaining docks .. right the ships core

SmilingDemon edited Tester information (Internal use only). (Show Details)Mar 10 2017, 7:17 PM
SmilingDemon changed Last tested (version) from 0.197.46 (DEV) to 0.199.476.
SmilingDemon changed the task status from Resolved to In Queue.
Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptMar 10 2017, 7:17 PM
SmilingDemon edited Tester information (Internal use only). (Show Details)Mar 10 2017, 7:18 PM
schema added a subscriber: schema.Mar 11 2017, 2:28 AM

Possibly tested on wrong build

schema changed the task status from In Queue to Resolved.Mar 11 2017, 2:28 AM
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptMar 11 2017, 2:28 AM

yeah definitely wrong version. I forgot to upload yesterday

-QA Testing-

looks better but its not quite right yet


spawning in the ship with the same name causes those two to drift in space and as far as i could find
testrl30,testrl400,testrl40 (names from the original ship)
are missing from the new spawned ship

a newly spawned ship with a different name is just fine!

SmilingDemon edited Tester information (Internal use only). (Show Details)Mar 11 2017, 10:33 AM
SmilingDemon changed Last tested (version) from 0.199.476 to 0.199.478.
SmilingDemon changed the task status from Resolved to In Queue.
Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptMar 11 2017, 10:33 AM

It's using different names for me

schema added a commit: Restricted Diffusion Commit.Mar 12 2017, 7:01 PM
schema changed the task status from In Queue to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptMar 12 2017, 7:01 PM

Should be finally fixed in 0.199.483 or higher

AndyP moved this task from Backlog / Unclassed to General on the Engine board.Mar 15 2017, 8:02 PM
AndyP edited projects, added Engine (General); removed Engine.
lancake added subscribers: SmilingDemon, lancake.
lancake claimed this task.

-QA Testing-

Fix confirmed, the "d" number gets added properly and works well multiple times for the same shipname.

lancake changed Last tested (version) from 0.199.478 to 0.199.491.Mar 22 2017, 1:11 PM
lancake closed this task as Closed.Apr 28 2017, 1:24 PM
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptApr 28 2017, 1:24 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript