Page MenuHomeSchine - Phabricator
Create Task
Maniphest T1144

Starmade | a completely removed fleet member stays in the list
Closed, FinishedPublic
Actions

Description

  1. Removing a fleet member with /destroy_entity or letting it overheat and despawn doesn't remove it from the fleet list.
  2. Removing the flagship in the same way will cause a server nullpointerexception

Logs:

log.txt.02 MBDownload

[2016-02-14 15:59:36] java.lang.NullPointerException
[2016-02-14 15:59:36] 	at obfuscated.WQ.a(SourceFile:19)
[2016-02-14 15:59:36] 	at obfuscated.WV.onUpdate(SourceFile:66)
[2016-02-14 15:59:36] 	at obfuscated.arX.update(SourceFile:167)
[2016-02-14 15:59:36] 	at obfuscated.arT.updateOnActive(SourceFile:145)
[2016-02-14 15:59:36] 	at obfuscated.arQ.update(SourceFile:115)
[2016-02-14 15:59:36] 	at obfuscated.WJ.a(SourceFile:57)
[2016-02-14 15:59:36] 	at org.schema.game.server.controller.GameServerController.update(SourceFile:1114)
[2016-02-14 15:59:36] 	at org.schema.schine.network.server.ServerController.run(SourceFile:256)
[2016-02-14 15:59:36] 	at java.lang.Thread.run(Unknown Source)
[2016-02-14 15:59:36] Exception: Error occured updating AI (ExcMessage: null): Current Program: obfuscated.ani@2ce60cbd; state: anp; in Ship[Fleet Member Team 1](15)
[2016-02-14 15:59:36] java.lang.NullPointerException
[2016-02-14 15:59:36] 	at org.schema.common.util.linAlg.Vector3i.<init>(SourceFile:45)
[2016-02-14 15:59:36] 	at obfuscated.anp.onUpdate(SourceFile:105)
[2016-02-14 15:59:36] 	at obfuscated.arX.update(SourceFile:167)
[2016-02-14 15:59:36] 	at obfuscated.arT.updateOnActive(SourceFile:145)
[2016-02-14 15:59:36] 	at obfuscated.arS.updateOnActive(SourceFile:44)
[2016-02-14 15:59:36] 	at obfuscated.amv.updateOnActive(SourceFile:261)
[2016-02-14 15:59:36] 	at obfuscated.arQ.update(SourceFile:115)
[2016-02-14 15:59:36] 	at obfuscated.SH.a(SourceFile:217)
[2016-02-14 15:59:36] 	at obfuscated.Sf.updateLocal(SourceFile:546)
[2016-02-14 15:59:36] 	at org.schema.game.server.controller.GameServerController.update(SourceFile:1278)
[2016-02-14 15:59:36] 	at org.schema.schine.network.server.ServerController.run(SourceFile:256)
[2016-02-14 15:59:36] 	at java.lang.Thread.run(Unknown Source)
NOTE: After restarting my SP, the removed member was not in the list anymore so it just doesn't update immediately.

Details

Task Type
Bug
Testing Results
Affected Gamemode(s)
Singleplayer
Reproducible
Yes
Last tested (version)
0.19564 (DEV)
Category
Fleets
First occurrence (version)
0.19557 (Dev)
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce
  1. make a fleet with a few ships in it
  2. /destroy_entity a fleet member and check fleet list, it's still there
  1. for the nullpointer, remove the flag ship instead
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake updated the task description. (Show Details)Feb 14 2016, 3:04 PM
lancake added a project: Issue Navigation.
lancake shifted this object from the S1 Public space to the S3 Starmade space.
lancake changed the visibility from "Custom Policy" to "Public (No Login Required)".
lancake changed the edit policy from "Task Author" to "Starmade (Project)".
lancake changed Category from none/unspecified to Fleets.
lancake set First occurrence (version) to 0.19557.
lancake edited Serverconfig (server.cfg). (Show Details)
lancake edited Clientconfig (settings.cfg). (Show Details)
lancake edited Steps to reproduce. (Show Details)
lancake set Task Type to Bug.
lancake changed First occurrence (version) from 0.19557 to 0.19557 (Dev).
lancake set OS-Specific to No.
lancake set Hardware-Specific to No.
lancake set Video Card Vendor to uncertain.
lancake set Affected Gamemode(s) to Singleplayer.
lancake set Reproducible to Yes.
lancake set Last tested (version) to 0.19557 (Dev).
lancake added subscribers: AndyP, lancake.
lancake created this task.
lancake raised the priority of this task from to Pre-Release Quality Assurance.
lancake claimed this task.Feb 14 2016, 11:21 PM
lancake changed the task status from Open to In Queue (Game).Feb 14 2016, 11:33 PM

-Confirmed-

Restricted Application edited projects, added Starmade, Game Development; removed Issue Navigation. · View Herald TranscriptFeb 14 2016, 11:33 PM
schema added a subscriber: schema.Feb 25 2016, 11:28 PM
schema changed the task status from In Queue (Game) to Resolved.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptFeb 25 2016, 11:28 PM
SmilingDemon closed this task as Closed.Feb 27 2016, 2:40 PM

-QA Testing-

deleting or killing a ship due to damage is now removing it from the fleet
a flagship gets removed and the next ship in line gets promoted to Flagship

no nullpointers to be seen

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptFeb 27 2016, 2:40 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript
SmilingDemon changed Last tested (version) from 0.19557 (Dev) to 0.19564 (DEV).Feb 27 2016, 3:10 PM
AndyP moved this task from Unclassed to Archived on the Starmade board.Mar 2 2016, 12:18 AM
Restricted Application added a project: Fleets. · View Herald TranscriptMar 10 2017, 6:17 PM