Page MenuHomeSchine - Phabricator

Starmade | shooting factioned planet with missiles crashes all players not in that sector
Closed, FinishedPublic

Description

Shooting a factioned planet plate (homebase or not) will cause everyone that does not have this sector loaded to crash. This might be the result of an exploit fix but I'm unsure.

How to reproduce:

  1. get 2 clients
  2. load a planet with the 1st client and get a ship that can shoot a missile
  3. enter a faction with that 1st client, put a faction module on the planet and enter a faction signature
  4. put your 2nd client somewhere not close to the planet (not in load of range of that planet)
  5. shoot the planet with your 1st client
[2015-06-09 14:21:13] java.lang.NullPointerException
[2015-06-09 14:21:13] 	at obfuscated.Kt.d(SourceFile:521)
[2015-06-09 14:21:13] 	at obfuscated.Kt.isHomeBaseFor(SourceFile:504)
[2015-06-09 14:21:13] 	at org.schema.game.common.data.world.SimpleTransformableSendableObject.isHomeBase(SourceFile:1310)
[2015-06-09 14:21:13] 	at obfuscated.Kt.isHomeBase(SourceFile:499)
[2015-06-09 14:21:13] 	at obfuscated.Uo.a(SourceFile:538)
[2015-06-09 14:21:13] 	at obfuscated.Uo.handleHitMissile(SourceFile:572)
[2015-06-09 14:21:13] 	at obfuscated.PA.a(SourceFile:71)
[2015-06-09 14:21:13] 	at obfuscated.Ps.a(SourceFile:53)
[2015-06-09 14:21:13] 	at obfuscated.C.update(SourceFile:2753)
[2015-06-09 14:21:13] 	at obfuscated.aoa.a(SourceFile:1191)
[2015-06-09 14:21:13] 	at obfuscated.aoa.a(SourceFile:1183)
[2015-06-09 14:21:13] 	at obfuscated.C.h(SourceFile:2307)
[2015-06-09 14:21:13] 	at obfuscated.JA.run(SourceFile:86)
[2015-06-09 14:21:13] 	at java.lang.Thread.run(Unknown Source)

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Multiplayer
Reproducible
Yes
Last tested (version)
0.19247 (Dev)
Category
Engine
First occurrence (version)
0.19247 (Dev)
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake updated the task description. (Show Details)Jun 9 2015, 12:49 PM
lancake changed Category from none/unspecified to Engine.
lancake changed Affected Gamemode(s) from none/unspecified to Multiplayer.
lancake set First occurrence (version) to 0.19247 (Dev).
lancake changed Reproducible from uncertain to Yes.
lancake set Last tested (version) to 0.19247 (Dev).
lancake edited a custom field.
lancake edited Serverconfig (server.cfg). (Show Details)
lancake edited Clientconfig (settings.cfg). (Show Details)
lancake added a subscriber: lancake.
lancake created this task.
lancake raised the priority of this task from to Release Blocker.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptJun 9 2015, 12:49 PM
lancake set Task Type to Bug.Jun 9 2015, 12:49 PM
lancake set OS-Specific to No.
lancake set Hardware-Specific to No.
lancake set Video Card Vendor to uncertain.
lancake changed the task status from Open to In Queue (Game).
Restricted Application edited projects, added Game Development, Starmade; removed Issue Navigation. · View Herald TranscriptJun 9 2015, 12:49 PM
Restricted Application added a commit: Restricted Diffusion Commit.Jun 9 2015, 8:43 PM
Restricted Application changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJun 9 2015, 8:43 PM
SmilingDemon closed this task as Closed.
SmilingDemon claimed this task.

couldnt crash anything as per description
fixed

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJun 10 2015, 7:03 PM
AndyP removed SmilingDemon as the assignee of this task.Jul 11 2015, 12:49 PM
AndyP shifted this object from the S1 Public space to the S3 Starmade space.Aug 11 2015, 10:36 PM
AndyP changed the edit policy from "Starmade (Project)" to "All Users".
Restricted Application added a project: Engine. · View Herald TranscriptMar 10 2017, 6:34 PM