Page MenuHomeSchine - Phabricator

Starmade | Enable/Disable all AI only works for last chain
Closed, FinishedPublic

Description

The enable/disable all AI in the structure menu only enables (and sets the type to turret) for the last chain on a turret axis.
This works for most applications but turrets docked on turrets would not enable properly.

Setting the type also only works for turrets, its impossible to activate drones via the structure menu (still possible via logic)

Possible solution:

  • Enable AI for all entities that have a bobby AI module on them, this includes all - types of docks: turret/rail basic/rotator/...
  • Do not change the AI 'type' of those entities

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.19316 (Dev)
Category
Control Block System: Rails/Docking
First occurrence (version)
0.19226
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake updated the task description. (Show Details)Jun 2 2015, 9:36 PM
lancake added a project: Issue Navigation.
lancake changed Category from none/unspecified to Control Block System: Rails/Docking.
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.
lancake set First occurrence (version) to 0.19226.
lancake changed Reproducible from uncertain to Yes.
lancake set Last tested (version) to 0.19242.
lancake edited a custom field.
lancake edited Serverconfig (server.cfg). (Show Details)
lancake edited Clientconfig (settings.cfg). (Show Details)
lancake added a subscriber: lancake.
lancake created this task.
lancake raised the priority of this task from to High.
lancake changed the task status from Open to In Queue (Game).Jun 3 2015, 1:04 PM
Restricted Application edited projects, added Game Development; removed Issue Navigation. · View Herald TranscriptJun 3 2015, 1:04 PM
Restricted Application removed a project: Starmade. · View Herald TranscriptJun 3 2015, 4:15 PM
schema added a commit: Restricted Diffusion Commit.Jul 9 2015, 3:15 AM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJul 9 2015, 3:15 AM
lancake changed the task status from Resolved to In Queue (Game).Jul 9 2015, 6:34 PM

What happens:

  • activate all turret AI: all turret axis docks get their AI enabled, type switches to turret.
  • activate all docked AI: all rotator/rail basic docks get their AI enabled, type switches to turret (in most cases, not always...). This should always be ship if it has to switch.

I'm not sure but why does type need to be forced? Don't change it and "activate all turret AI" enables all AI for the turret type and "activate all docked AI" would do that for the ship type. In both cases the entity would need to have a bobby AI module. Else you enable AI on entities you don't want to, like elevators, docked ships, decorative parts (radar dishes).

If these get undocked (during combat for example), you'll end up with an elevator trying to attack your enemy not to mention that this mechanic completely makes the bobby AI useless. Since you can enable AI on entities without those without a problem.

Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptJul 9 2015, 6:34 PM
schema added a commit: Restricted Diffusion Commit.Jul 10 2015, 11:51 AM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJul 10 2015, 11:51 AM
lancake closed this task as Closed.Jul 10 2015, 3:41 PM
lancake claimed this task.

enable all turret ai: enables all entities with bobby AI and docked to a turret axis
enable all docked entities: the rest (if they have a bobby AI)

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptJul 10 2015, 3:41 PM
lancake set Task Type to Bug.Jul 10 2015, 3:42 PM
lancake changed Last tested (version) from 0.19242 to 0.19316 (Dev).
lancake set OS-Specific to No.
lancake set Hardware-Specific to No.
lancake set Video Card Vendor to uncertain.
AndyP removed lancake as the assignee of this task.Jul 11 2015, 12:48 PM
AndyP shifted this object from the S1 Public space to the S3 Starmade space.Aug 11 2015, 8:55 PM
AndyP changed the edit policy from "Starmade (Project)" to "All Users".
Restricted Application added a project: CBS: Rails. · View Herald TranscriptMar 10 2017, 5:50 PM