Page MenuHomeSchine - Phabricator
Create Task
Maniphest T104

Starmade | Safety element: Faction Menu
Closed, FinishedPublic
Actions

Description

Part of the Hub issue list on safety.

Menuoptions in the faction menu that need safety guards:

  • Abandon Home
  • Leave faction - (extended warning about loosing build, activation control on your current ship!)

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.197.46
Category
Engine
First occurrence (version)
0.1639 (Dev)
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce

Partially fixed:

  • The "Reset Homebase" button should grey-out if you don't have the permission rank for it. It should look at the "homebase set/clear" rank option but it looks at the "'Permission edit' Permission". You can't use the button without "homebase set/clear" so it's just a visual issue.


  • "Reset faction signature" should be grey-ed out if its the faction module for a homebase and if you don't have permissions to reset/set a homebase.
  • "Leave faction" message content needs more info, copy/paste the following:
Do you really want to leave this faction? You'll be unable to access any ship/structure that belongs to this faction except for your ships that use the Personal Permission Rank.
If you are the last member, the faction will also automatically disband!
  • "Make faction home" when you already have a homebase is incorrect, copy/paste the following:
Do you really want to do this?
You already have a Homebase!
  • The warning dialogs of Make faction home and reset homebase have an incorrect title. It shows you WARN but it should be Confirm

Related Objects
Search...

Event Timeline

lancake updated the task description. (Show Details)Jun 9 2015, 8:55 AM
lancake added a project: Issue Navigation.
lancake changed Category from none/unspecified to Engine.
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.
lancake set First occurrence (version) to 0.1639 (Dev).
lancake changed Reproducible from uncertain to Yes.
lancake set Last tested (version) to 0.19247 (Dev).
lancake edited a custom field.
lancake edited Serverconfig (server.cfg). (Show Details)
lancake edited Clientconfig (settings.cfg). (Show Details)
lancake added a subscriber: lancake.
lancake created this task.
lancake raised the priority of this task from to Normal.
lancake changed the task status from Open to In Queue (Game).Jun 10 2015, 9:27 AM
Restricted Application edited projects, added Game Development, Starmade; removed Issue Navigation. · View Herald TranscriptJun 10 2015, 9:27 AM
schema added a subscriber: schema.Jul 22 2015, 7:58 PM
schema changed the task status from In Queue (Game) to Resolved.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptJul 22 2015, 7:58 PM
Megacrafter127 set Task Type to Bug.Jul 23 2015, 12:35 PM
Megacrafter127 changed Last tested (version) from 0.19247 (Dev) to 0.19336 (Dev) [20150723_005238].
Megacrafter127 set OS-Specific to No.
Megacrafter127 set Hardware-Specific to No.
Megacrafter127 set Video Card Vendor to uncertain.
Megacrafter127 edited Serverconfig (server.cfg). (Show Details)
Megacrafter127 edited Clientconfig (settings.cfg). (Show Details)
Megacrafter127 added a subscriber: Megacrafter127.EditedJul 23 2015, 12:43 PM
Megacrafter127 removed Megacrafter127 as the assignee of this task.

Cannot confirm fix in 0.19336 (built on 23.07.2015, 00:52:38).

  1. 'Abandon home' option missing from faction menu
  2. no change in behaviour of 'Leave faction', message only states, that the faction will disband if you are the last member
SmilingDemon added a subscriber: SmilingDemon.Jul 25 2015, 1:40 PM
SmilingDemon changed the task status from Resolved to In Queue (Game).

The Faction Blocks lets you claim a Homebase ... without warning you that already one does exist.

On the homebase faction block there is no button for "Abandon Home" ... only for reset faction settings

Leave Faction message also still doesnt informs you about loss of control over factionend ships/stations

Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptJul 25 2015, 1:40 PM
SmilingDemon changed Last tested (version) from 0.19336 (Dev) [20150723_005238] to 0.19342 (Dev).Jul 25 2015, 1:41 PM
AndyP shifted this object from the S1 Public space to the S3 Starmade space.Aug 11 2015, 10:34 PM
AndyP changed the edit policy from "Starmade (Project)" to "All Users".
lancake claimed this task.Sep 21 2015, 10:48 AM
lancake mentioned this in Unknown Object (Maniphest Task).Apr 17 2016, 10:01 PM
schema added a commit: Restricted Diffusion Commit.Apr 21 2016, 2:06 PM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptApr 21 2016, 2:06 PM
lancake changed the task status from Resolved to In Queue (Game).Apr 22 2016, 1:44 PM

-QA Testing-

Partially fixed:

  • The "Reset Homebase" button should grey-out if you don't have the permission rank for it. It should look at the "homebase set/clear" rank option but it looks at the "'Permission edit' Permission". You can't use the button without "homebase set/clear" so it's just a visual issue.


  • "Reset faction signature" should be grey-ed out if its the faction module for a homebase and if you don't have permissions to reset/set a homebase.
  • "Leave faction" message content needs more info, copy/paste the following:
Do you really want to leave this faction? You'll be unable to access any ship/structure that belongs to this faction except for your ships that use the Personal Permission Rank.
If you are the last member, the faction will also automatically disband!
  • "Make faction home" when you already have a homebase is incorrect, copy/paste the following:
Do you really want to do this?
You already have a Homebase!
  • The warning dialogs of Make faction home and reset homebase have an incorrect title. It shows you WARN but it should be Confirm
Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptApr 22 2016, 1:44 PM
lancake edited Steps to reproduce. (Show Details)Apr 22 2016, 1:44 PM
schema added a commit: Restricted Diffusion Commit.Apr 23 2016, 2:08 PM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptApr 23 2016, 2:08 PM
schema added a comment.Apr 23 2016, 2:09 PM

Faction Block dialog unchanged except removal of hombase related stuff when no permission is given. Pls move into separate issue because that dialog will be redesigned anyways, so currently i don't put to much time into the old one.

lancake moved this task from Backlog / Unclassed to Confirmed fix on the Quality Assurance board.Apr 23 2016, 4:55 PM
lancake closed this task as Closed.

-QA Testing-

Alright, fix confirmed then.

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptApr 23 2016, 4:55 PM
lancake changed Last tested (version) from 0.19342 (Dev) to 0.197.46.Apr 23 2016, 4:55 PM
Restricted Application added a project: Engine. · View Herald TranscriptMar 10 2017, 5:49 PM