Page MenuHomeSchine - Phabricator

Starmade | Safety element: Structure Menu
Closed, FinishedPublic

Description

Part of the Hub issue list on safety.

Buttons in the structure menu that need a second click to confirm the action. (Anything non-reversible by the menu)

Example for a simple and fast implementation:


clicking leads to:

clicking the 'red button' then instantly undocks.

Menuoptions that need this functionality:

  • Undock all

This applies for the rail system now, and not for the old docking system.

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
Single and Multi
Reproducible
Yes
Last tested (version)
0.197.46
Category
Engine
First occurrence (version)
0.1639 (Dev)
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Steps to reproduce

Works, but just like T104:

  • The warning dialog of "Undock all" shows you WARN_UNDOCK but it should be Confirm
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

lancake updated the task description. (Show Details)Jun 9 2015, 8:53 AM
lancake added a project: Issue Navigation.
lancake changed Category from none/unspecified to Engine.
lancake changed Affected Gamemode(s) from none/unspecified to Single and Multi.
lancake set First occurrence (version) to 0.1639 (Dev).
lancake changed Reproducible from uncertain to Yes.
lancake set Last tested (version) to 0.19247 (Dev).
lancake edited a custom field.
lancake edited Serverconfig (server.cfg). (Show Details)
lancake edited Clientconfig (settings.cfg). (Show Details)
lancake added a subscriber: lancake.
lancake created this task.
lancake raised the priority of this task from to Normal.
lancake changed the task status from Open to In Queue (Game).Jun 10 2015, 9:27 AM
Restricted Application edited projects, added Game Development, Starmade; removed Issue Navigation. · View Herald TranscriptJun 10 2015, 9:27 AM
AndyP shifted this object from the S1 Public space to the S3 Starmade space.Aug 11 2015, 10:34 PM
AndyP changed the edit policy from "Starmade (Project)" to "All Users".
AndyP set Task Type to Bug.
AndyP set OS-Specific to No.
AndyP set Hardware-Specific to No.
AndyP set Video Card Vendor to uncertain.
lancake claimed this task.Sep 21 2015, 10:48 AM
lancake mentioned this in Unknown Object (Maniphest Task).Apr 17 2016, 10:01 PM
schema added a commit: Restricted Diffusion Commit.Apr 21 2016, 1:41 PM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptApr 21 2016, 1:41 PM
lancake changed the task status from Resolved to In Queue (Game).Apr 22 2016, 1:47 PM

-QA Testing-

Works, but just like T104:

  • The warning dialog of "Undock all" shows you WARN_UNDOCK but it should be Confirm
Restricted Application edited projects, added Game Development; removed Quality Assurance. · View Herald TranscriptApr 22 2016, 1:47 PM
lancake edited Steps to reproduce. (Show Details)Apr 22 2016, 1:48 PM
schema added a commit: Restricted Diffusion Commit.Apr 23 2016, 2:08 PM
schema changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptApr 23 2016, 2:08 PM
lancake closed this task as Closed.Apr 23 2016, 4:43 PM
Restricted Application removed a project: Quality Assurance. · View Herald TranscriptApr 23 2016, 4:43 PM

-QA Testing-

Fix confirmed.

lancake changed Last tested (version) from 0.19247 (Dev) to 0.197.46.Apr 23 2016, 4:43 PM
Restricted Application added a project: Engine. · View Herald TranscriptMar 10 2017, 5:49 PM