Page MenuHomeSchine - Phabricator
Create Task
Maniphest T576

Starmade | Amount sellable appended instead of replace when overselling using sell amount
Closed, FinishedPublic
Actions

Description

  1. open up the shop menu (using b) and select any item in the shop that you have in your inventory

  1. click sell amount and enter any amount higher than the amount the shop can buy (ie: 50000-stock+1 or higher), it doesn't matter if you don't have enough of the item

  1. click ok and it append the amount it could buy, even if we had less than the amount.

it should replace the amount with the amount it could buy only if we had more than the amount otherwise it should replace it with the amount we have.

Details

Commits
Restricted Diffusion Commit
Task Type
Bug
Testing Results
Affected Gamemode(s)
none/unspecified
Reproducible
Yes
Last tested (version)
0.19412
Category
none/unspecified
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Java Version (32bit)

Error: This Java instance does not support a 32-bit JVM.
Please install the desired version.

Java Version (64bit)

openjdk version "1.8.0_51"
OpenJDK Runtime Environment (build 1.8.0_51-b16)
OpenJDK 64-Bit Server VM (build 25.51-b03, mixed mode)

Event Timeline

free.for.all.to.use.z updated the task description. (Show Details)Aug 27 2015, 1:41 AM
free.for.all.to.use.z changed Reproducible from uncertain to Yes.
free.for.all.to.use.z set Last tested (version) to 0.19401.
free.for.all.to.use.z edited Serverconfig (server.cfg). (Show Details)
free.for.all.to.use.z edited Clientconfig (settings.cfg). (Show Details)
free.for.all.to.use.z edited Java Version (32bit). (Show Details)
free.for.all.to.use.z edited Java Version (64bit). (Show Details)
free.for.all.to.use.z added a subscriber: free.for.all.to.use.z.
free.for.all.to.use.z created this task.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptAug 27 2015, 1:41 AM
AndyP shifted this object from the S1 Public space to the S3 Starmade space.Aug 27 2015, 8:05 AM
AndyP changed the visibility from "Custom Policy" to "Public (No Login Required)".
AndyP changed the edit policy from "Task Author" to "Starmade (Project)".
AndyP set Task Type to Bug.
AndyP set Category to none/unspecified.
AndyP set Affected Gamemode(s) to none/unspecified.
AndyP set OS-Specific to No.
AndyP set Hardware-Specific to No.
AndyP set Video Card Vendor to uncertain.
AndyP moved this task from New / Unconfirmed to Open / Validated on the Issue Navigation board.
AndyP added a subscriber: AndyP.
AndyP claimed this task.
AndyP removed AndyP as the assignee of this task.
AndyP triaged this task as Trivial priority.

-Validated-

NuclearFun moved this task from Open / Validated to Confirmed on the Issue Navigation board.Aug 27 2015, 11:13 AM
NuclearFun changed Last tested (version) from 0.19401 to 0.19412.
NuclearFun changed the task status from Open to In Queue (Game).Aug 27 2015, 11:20 AM

confirmed

Reproducible exactly as described in the report.
First click appends the amount as described in the report, click OK and a error message is displayed ("Shop cannot stock...") a second click on OK will display the correct amount the shop could buy and a third click on OK will sell the item.

Restricted Application edited projects, added Game Development, Starmade; removed Issue Navigation. · View Herald TranscriptAug 27 2015, 11:20 AM
free.for.all.to.use.z added a comment.Aug 27 2015, 11:39 AM

just fyi, on 0.19401.

the second click error with "Please only enter numbers!", the amount in the text entry or whatever it is call is the same as the third screenshot, 9999947841.

only when i put in an amount equal to or less than 50000-stock and click OK then it show the correct amount (ie: the amount i have).

then the final (third) click on OK sell the item.

Restricted Application added a commit: Restricted Diffusion Commit.Sep 4 2015, 6:09 AM
Restricted Application changed the task status from In Queue (Game) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Game Development. · View Herald TranscriptSep 4 2015, 6:09 AM
NuclearFun moved this task from Backlog / Unclassed to Confirmed fix on the Quality Assurance board.Sep 13 2015, 9:47 PM
NuclearFun closed this task as Closed.

-QA Testing-

Fix confirmed

Restricted Application removed a project: Quality Assurance. · View Herald TranscriptSep 13 2015, 9:48 PM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript