Page MenuHomeSchine - Phabricator

Launcher | jvm function -server (for jvm not the game option) should be added, it takes slightly longer to start but the runtime performance is higher
Closed, FinishedPublic

Details

Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
Task Type
Feature
Testing Results
Affected Gamemode(s)
none/unspecified
Reproducible
uncertain
Category
Launcher
Hardware/Software/System
OS-Specific
No
Hardware-Specific
No
Video Card Vendor
uncertain
Serverconfig (server.cfg)
<replace this line with the file content>
Clientconfig (settings.cfg)
<replace this line with the file content>

Event Timeline

AndyP updated the task description. (Show Details)Aug 15 2015, 6:07 AM
AndyP shifted this object from the S1 Public space to the Restricted Space space.
AndyP changed the visibility from "Custom Policy" to "Public (No Login Required)".
AndyP changed the edit policy from "Task Author" to "All Users".
AndyP changed Task Type from Bug to Feature.
AndyP changed Category from none/unspecified to Launcher.
AndyP edited Serverconfig (server.cfg). (Show Details)
AndyP edited Clientconfig (settings.cfg). (Show Details)
AndyP added a subscriber: AndyP.
AndyP created this task.
AndyP raised the priority of this task from to Urgent.
Restricted Application added a project: Issue Navigation. · View Herald TranscriptAug 15 2015, 6:07 AM
AndyP set Affected Gamemode(s) to none/unspecified.Aug 15 2015, 6:07 AM
AndyP set Reproducible to uncertain.
AndyP set OS-Specific to No.
AndyP set Hardware-Specific to No.
AndyP set Video Card Vendor to uncertain.
AndyP added a subscriber: schema.
AndyP changed the task status from Open to In Queue (Launcher).
Restricted Application edited projects, added Starmade, Launcher Development; removed Issue Navigation. · View Herald TranscriptAug 15 2015, 6:07 AM
AndyP assigned this task to schema.Aug 15 2015, 6:10 AM

Feature request by: schema

AndyP shifted this object from the Restricted Space space to the S5 Launcher space.Oct 26 2015, 10:17 PM
calani lowered the priority of this task from Urgent to Normal.
calani added a commit: Restricted Diffusion Commit.Jan 14 2016, 7:48 AM
calani changed the task status from In Queue (Launcher) to Resolved by committing Restricted Diffusion Commit.
Restricted Application edited projects, added Quality Assurance; removed Launcher Development. · View Herald TranscriptJan 14 2016, 7:48 AM
calani added a commit: Restricted Diffusion Commit.Jan 23 2016, 8:52 AM
AndyP changed the task status from Resolved to In Queue (Launcher).EditedJan 23 2016, 11:21 AM

-QA Testing-

Seems to be not fixed.

Using custom Java:

Using bundled java:

It seems to pass two arguments as "undefined" too.

Restricted Application edited projects, added Launcher Development; removed Quality Assurance. · View Herald TranscriptJan 23 2016, 11:21 AM
calani added a subscriber: calani.Jan 24 2016, 7:49 AM

The -server option passed to the jvm is strangely not listed in your screenshot, but is present in the code.

Additionally, the listed arguments (left of the red box) are those passed to the jar, not to the jvm. It's confusing having two options with the same name in different places in the same command that do very different things. e.g. the jar's -server option hosts a dedicated server.

in particular, the launcher passes these options to the jar:

  • -force (if not dedicatedServer)
  • -server (if dedicatedServer)
  • -gui (if dedicatedServer)
  • -port
  • -auth value

when not starting a dedicated server, two of these options (-server, -gui) are replaced with undefined -- i'll fix this in a future build! but it's pretty minor right now.

so this issue is definitely still fixed.
the jvm performance, however, might do better with some further scrutiny!

AndyP closed this task as Closed.Jan 24 2016, 9:29 AM

-QA Testing-

Okay, checked that again.
The -server option gets passed to the dedicated server part.
All fine then. =)

Restricted Application removed a project: Launcher Development. · View Herald TranscriptJan 24 2016, 9:29 AM
Restricted Application removed a subscriber: AndyP. · View Herald Transcript